From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752407AbdBCL5F (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Feb 2017 06:57:05 -0500
Received: from foss.arm.com ([217.140.101.70]:48142 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751762AbdBCL5E (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Feb 2017 06:57:04 -0500
Subject: Re: irqdomain patch prevents booting qemu
To: Jiri Slaby <jslaby@suse.cz>, Thomas Gleixner <tglx@linutronix.de>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>
References: <922d42de-635a-ffd7-b6bd-2e4edf7d4307@suse.cz>
Cc: andre.przywara@arm.com
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <3794a89f-ee5f-bc15-d9f8-cb7c8b9b8fcc@arm.com>
Date: Fri, 3 Feb 2017 11:57:01 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.5.1
MIME-Version: 1.0
In-Reply-To: <922d42de-635a-ffd7-b6bd-2e4edf7d4307@suse.cz>
Content-Type: text/plain; charset=iso-8859-2
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jiri,

On 03/02/17 11:49, Jiri Slaby wrote:
> Hi,
> 
> with this -next commit:
> 
> commit 08d85f3ea99f1eeafc4e8507936190e86a16ee8c
> Author: Marc Zyngier <marc.zyngier@arm.com>
> Date:   Tue Jan 17 16:00:48 2017 +0000
> 
>     irqdomain: Avoid activating interrupts more than once
> 
> 
> 
> I can no longer boot qemu machine. It stops booting at:
> [    0.477566] x2apic enabled
> [    0.478154] Switched APIC routing to physical x2apic.
> [    0.479405] ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1
> 
> 
> It loops in:
> #0  calibrate_APIC_clock () at arch/x86/kernel/apic/apic.c:757
> #1  setup_boot_APIC_clock () at arch/x86/kernel/apic/apic.c:880
> #2  0xffffffff81f7bef2 in apic_bsp_setup (upmode=<optimized out>)
>     at arch/x86/kernel/apic/apic.c:2300
> #3  0xffffffff81f79c84 in native_smp_prepare_cpus (max_cpus=<optimized out>)
>     at arch/x86/kernel/smpboot.c:1339
> #4  0xffffffff81f6801d in smp_prepare_cpus (max_cpus=<optimized out>)
>     at ./arch/x86/include/asm/smp.h:85
> #5  kernel_init_freeable () at init/main.c:1020
> #6  0xffffffff8192372e in kernel_init (unused=<optimized out>)
>     at init/main.c:956
> #7  0xffffffff8192ac5c in ret_from_fork () at arch/x86/entry/entry_64.S:430
> 
> 
> which is:
> 757             while (lapic_cal_loops <= LAPIC_CAL_LOOPS)
> 758                     cpu_relax();
> 
> 
> lapic_cal_loops is not incrementing, so it seems that interrupts are not
> coming.
> 
> Reverting the commit makes the machine boot again.

I think Thomas fixed this in
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1322872.html

which is currently in tip/irq/urgent

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...