From: Valdis.Kletnieks@vt.edu
To: Xi Wang <xi.wang@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: signedness bug in cma3000_thread_irq()
Date: Wed, 14 Dec 2011 22:21:00 -0500 [thread overview]
Message-ID: <3797.1323919260@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Wed, 14 Dec 2011 21:35:22 EST." <ECD4A42B-AC97-417B-99CA-3856B5DAFAC6@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
On Wed, 14 Dec 2011 21:35:22 EST, Xi Wang said:
> On Dec 14, 2011, at 9:27 PM, Valdis.Kletnieks@vt.edu wrote:
> > That will fix the signed/unsigned issue. However, was there a reason
> > the field was an 8-bit-wide to begin with?
>
> Which field? The ->read() function pointer?
No, the variable that used to be a u8 - was it 8 bits wide for a reason?
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2011-12-15 3:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 6:49 Xi Wang
2011-12-12 7:42 ` Dmitry Torokhov
2011-12-15 2:27 ` Valdis.Kletnieks
2011-12-15 2:35 ` Xi Wang
2011-12-15 3:21 ` Valdis.Kletnieks [this message]
2011-12-15 22:17 ` Xi Wang
2011-12-22 17:50 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3797.1323919260@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®