From: Marek Vasut <marex@denx.de>
To: Christophe Roullier <christophe.roullier@foss.st.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Richard Cochran <richardcochran@gmail.com>,
Jose Abreu <joabreu@synopsys.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 07/12] net: stmmac: dwmac-stm32: Mask support for PMCR configuration
Date: Fri, 7 Jun 2024 14:45:53 +0200 [thread overview]
Message-ID: <379a013a-5385-4b74-ad68-12e73253a8b5@denx.de> (raw)
In-Reply-To: <20240607095754.265105-8-christophe.roullier@foss.st.com>
On 6/7/24 11:57 AM, Christophe Roullier wrote:
[...]
> @@ -348,8 +352,15 @@ static int stm32_dwmac_parse_data(struct stm32_dwmac *dwmac,
> return PTR_ERR(dwmac->regmap);
>
> err = of_property_read_u32_index(np, "st,syscon", 1, &dwmac->mode_reg);
> - if (err)
> + if (err) {
> dev_err(dev, "Can't get sysconfig mode offset (%d)\n", err);
> + return err;
> + }
> +
> + dwmac->mode_mask = SYSCFG_MP1_ETH_MASK;
> + err = of_property_read_u32_index(np, "st,syscon", 2, &dwmac->mode_mask);
> + if (err)
> + pr_debug("Warning sysconfig register mask not set\n");
Isn't this ^ an error ? If so, use dev_err(), else use dev_dbg()
> return err;
> }
[...]
next prev parent reply other threads:[~2024-06-07 12:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 9:57 [PATCH v5 00/12] Series to deliver Ethernet for STM32MP13 Christophe Roullier
2024-06-07 9:57 ` [PATCH v5 01/12] dt-bindings: net: add STM32MP13 compatible in documentation for stm32 Christophe Roullier
2024-06-07 9:57 ` [PATCH v5 02/12] net: stmmac: dwmac-stm32: Separate out external clock rate validation Christophe Roullier
2024-06-10 11:46 ` Ratheesh Kannoth
2024-06-10 11:54 ` Christophe ROULLIER
2024-06-07 9:57 ` [PATCH v5 03/12] net: stmmac: dwmac-stm32: Separate out external clock selector Christophe Roullier
2024-06-07 9:57 ` [PATCH v5 04/12] net: stmmac: dwmac-stm32: Extract PMCR configuration Christophe Roullier
2024-06-07 9:57 ` [PATCH v5 05/12] net: stmmac: dwmac-stm32: Clean up the debug prints Christophe Roullier
2024-06-07 9:57 ` [PATCH v5 06/12] net: stmmac: dwmac-stm32: Fix Mhz to MHz Christophe Roullier
2024-06-07 9:57 ` [PATCH v5 07/12] net: stmmac: dwmac-stm32: Mask support for PMCR configuration Christophe Roullier
2024-06-07 12:45 ` Marek Vasut [this message]
2024-06-07 9:57 ` [PATCH v5 08/12] net: stmmac: dwmac-stm32: add management of stm32mp13 for stm32 Christophe Roullier
2024-06-07 12:48 ` Marek Vasut
[not found] ` <c3e21cbf-bf9e-45d5-b6eb-f1f4d50e39a3@foss.st.com>
2024-06-07 19:54 ` Marek Vasut
2024-06-07 9:57 ` [PATCH v5 09/12] ARM: dts: stm32: add ethernet1 and ethernet2 support on stm32mp13 Christophe Roullier
2024-06-07 12:48 ` Marek Vasut
2024-06-10 7:55 ` Christophe ROULLIER
2024-06-10 8:06 ` Alexandre TORGUE
2024-06-10 10:37 ` Marek Vasut
2024-06-10 12:47 ` Alexandre TORGUE
2024-06-07 9:57 ` [PATCH v5 10/12] ARM: dts: stm32: add ethernet1/2 RMII pins for STM32MP13F-DK board Christophe Roullier
2024-06-07 9:57 ` [PATCH v5 11/12] ARM: dts: stm32: add ethernet1 for STM32MP135F-DK board Christophe Roullier
2024-06-07 12:49 ` Marek Vasut
2024-06-07 9:57 ` [PATCH v5 12/12] ARM: multi_v7_defconfig: Add MCP23S08 pinctrl support Christophe Roullier
2024-06-07 12:50 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=379a013a-5385-4b74-ad68-12e73253a8b5@denx.de \
--to=marex@denx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=broonie@kernel.org \
--cc=christophe.roullier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®