From: Niklas Cassel <niklas.cassel@axis.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"David S. Miller" <davem@davemloft.net>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Giuseppe CAVALLARO <peppe.cavallaro@st.com>,
Thierry Reding <treding@nvidia.com>,
Eric Engestrom <eric@engestrom.ch>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] bindings: net: stmmac: add missing note about LPI interrupt
Date: Mon, 10 Apr 2017 09:43:08 +0200 [thread overview]
Message-ID: <379cb3b6-4b4f-b4f0-d5e2-1896c7b677b1@axis.com> (raw)
In-Reply-To: <c1e78674-64d1-0e51-3ca4-48d8500a3528@cogentembedded.com>
On 04/07/2017 06:48 PM, Sergei Shtylyov wrote:
> Hello!
>
> On 04/07/2017 05:30 PM, Niklas Cassel wrote:
>
>> From: Niklas Cassel <niklas.cassel@axis.com>
>>
>> The hardware has a LPI interrupt.
>> There is already code in the stmmac driver to parse and handle the
>> interrupt. However, this information was missing from the DT binding.
>>
>> Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
>> ---
>> Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
>> index f652b0c384ce..8977abc266ac 100644
>> --- a/Documentation/devicetree/bindings/net/stmmac.txt
>> +++ b/Documentation/devicetree/bindings/net/stmmac.txt
>> @@ -8,8 +8,8 @@ Required properties:
>> that services interrupts for this device
>> - interrupts: Should contain the STMMAC interrupts
>> - interrupt-names: Should contain the interrupt names "macirq"
>> - "eth_wake_irq" if this interrupt is supported in the "interrupts"
>> - property
>> + "eth_wake_irq" if this interrupt is supported in the "interrupts property
>
> Missed closing quote?
Thanks for pointing it out.
Will send a v2.
>
>> + "eth_lpi" if this interrupt is supported in the "interrupts" property
>> - phy-mode: See ethernet.txt file in the same directory.
>> - snps,reset-gpio gpio number for phy reset.
>> - snps,reset-active-low boolean flag to indicate if phy reset is active low.
> [...]
>
> MBR, Sergei
>
prev parent reply other threads:[~2017-04-10 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 14:30 Niklas Cassel
2017-04-07 16:48 ` Sergei Shtylyov
2017-04-10 7:43 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=379cb3b6-4b4f-b4f0-d5e2-1896c7b677b1@axis.com \
--to=niklas.cassel@axis.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eric@engestrom.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®