From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA20CC7EE25 for ; Tue, 2 May 2023 06:04:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233605AbjEBGEO (ORCPT ); Tue, 2 May 2023 02:04:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjEBGEF (ORCPT ); Tue, 2 May 2023 02:04:05 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D746273A; Mon, 1 May 2023 23:04:03 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AA2312245A; Tue, 2 May 2023 06:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683007442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=abkpTL2IrkzdKT1kp6lWlfq+hjGdGVNZtS/id2U7OuE=; b=uabnDJZz/iSXCFySLeqSs3/rcgaXWLjRcLWLAdj+p4MTjxDkEhYqjFqZSAuYJaiSNY9wmF +6KxxJDiALoa1Ep9lv2bruqX5tVDEEDSzJf9YXZJcbpbdeP3GPwGWxpOKjm5thzSLovsxl uncaCW1VD5fGVadJsPGwf9e94sau8x8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683007442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=abkpTL2IrkzdKT1kp6lWlfq+hjGdGVNZtS/id2U7OuE=; b=h2vkopyRLBeb5pgeINDylCcNMUJGDcK6Wnvnd/IdQZzl/M7gHalUhX4Kl9KPJqhd0/FwGP 7WosUh+3/HRZ9vBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 76F15134FB; Tue, 2 May 2023 06:04:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0hLMAtKnUGTeaAAAMHmgww (envelope-from ); Tue, 02 May 2023 06:04:02 +0000 Message-ID: <379eb282-843d-2b64-554a-8505aee263c2@suse.de> Date: Tue, 2 May 2023 08:04:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] nvmet-auth: remove some dead code Content-Language: en-US To: Christophe JAILLET , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-nvme@lists.infradead.org References: From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/17/23 22:41, Christophe JAILLET wrote: > 'status' is known to be 0 at the point. > And nvmet_auth_challenge() return a -E or 0. > So these lines of code should just be removed. > > Signed-off-by: Christophe JAILLET > --- > The dead code became obvious after commit be2ada6d0ed0 ("nvmet-auth: fix > return value check in auth receive") > --- > drivers/nvme/target/fabrics-cmd-auth.c | 9 --------- > 1 file changed, 9 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman