From: Sumit Gupta <sumitg@nvidia.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <rafael@kernel.org>, <linux-pm@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<treding@nvidia.com>, <jonathanh@nvidia.com>, <bbasu@nvidia.com>,
<amiettinen@nvidia.com>, Sumit Gupta <sumitg@nvidia.com>
Subject: Re: [Patch v2 1/2] cpufreq: tegra194: save CPU data to avoid repeated SMP calls
Date: Wed, 4 Oct 2023 19:41:30 +0530 [thread overview]
Message-ID: <379ee551-c2ef-72ca-9372-c812373a1e0c@nvidia.com> (raw)
In-Reply-To: <20231003050019.a6mcchw2o2z2wkrh@vireshk-i7>
On 03/10/23 10:30, Viresh Kumar wrote:
> External email: Use caution opening links or attachments
>
>
> On 29-09-23, 19:47, Sumit Gupta wrote:
>>
>>
>> On 28/09/23 12:35, Viresh Kumar wrote:
>>> External email: Use caution opening links or attachments
>>>
>>>
>>> On 01-09-23, 22:11, Sumit Gupta wrote:
>>>> @@ -131,19 +132,10 @@ static int tegra234_get_cpu_ndiv(u32 cpu, u32 cpuid, u32 clusterid, u64 *ndiv)
>>>> static void tegra234_set_cpu_ndiv(struct cpufreq_policy *policy, u64 ndiv)
>>>> {
>>>
>>>> + for_each_cpu_and(cpu, policy->cpus, cpu_online_mask)
>>>
>>> (Yes this is existing code, but ..) you don't need to perform AND with
>>> cpu_online_mask as policy->cpus should only contain currently online CPUs.
>>>
>>> Please check if you ever see it differently.
>>>
>>
>> I think this was kept to be safe.
>> Should I removed the AND in v3 or send separate patch?
>
> Sending it separately would be ideal.
>
> --
> viresh
Sent v3 with the "sizeof(*data->cpu_data)" change.
Will send a separate patch with change to remove AND with mask as suggested.
Thank you,
Sumit Gupta
next prev parent reply other threads:[~2023-10-04 14:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 16:41 [Patch v2 0/2] Improvements to the Tegra CPUFREQ driver Sumit Gupta
2023-09-01 16:41 ` [Patch v2 1/2] cpufreq: tegra194: save CPU data to avoid repeated SMP calls Sumit Gupta
2023-09-01 17:58 ` Jon Hunter
2023-09-01 19:51 ` Sumit Gupta
2023-09-28 7:05 ` Viresh Kumar
2023-09-29 14:17 ` Sumit Gupta
2023-10-03 5:00 ` Viresh Kumar
2023-10-04 14:11 ` Sumit Gupta [this message]
2023-09-01 16:41 ` [Patch v2 2/2] cpufreq: tegra194: use refclk delta based loop instead of udelay Sumit Gupta
2023-09-01 17:59 ` Jon Hunter
2023-09-01 19:53 ` Sumit Gupta
2023-09-19 11:28 ` [Patch v2 0/2] Improvements to the Tegra CPUFREQ driver Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=379ee551-c2ef-72ca-9372-c812373a1e0c@nvidia.com \
--to=sumitg@nvidia.com \
--cc=amiettinen@nvidia.com \
--cc=bbasu@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=treding@nvidia.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®