From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758855AbbJISbb (ORCPT <rfc822;w@1wt.eu>);
	Fri, 9 Oct 2015 14:31:31 -0400
Received: from mga09.intel.com ([134.134.136.24]:17028 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757270AbbJISba convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 9 Oct 2015 14:31:30 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,659,1437462000"; 
   d="scan'208";a="823351992"
From: "Liang, Kan" <kan.liang@intel.com>
To: Jiri Olsa <jolsa@redhat.com>
CC: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>,
        Andi Kleen <andi@firstfloor.org>, Ulrich Drepper <drepper@gmail.com>,
        "Will Deacon" <will.deacon@arm.com>,
        Stephane Eranian <eranian@google.com>,
        "Don Zickus" <dzickus@redhat.com>, lkml <linux-kernel@vger.kernel.org>,
        "David Ahern" <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: RE: [PATCHv3 00/56] perf stat: Add scripting support
Thread-Topic: [PATCHv3 00/56] perf stat: Add scripting support
Thread-Index: AQHRAHD+gfZhBCqHf0i6+ZEc6Oxtc55h5Iqg//+faICAAZ0+kA==
Date: Fri, 9 Oct 2015 18:31:23 +0000
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F0770196ED30@SHSMSX103.ccr.corp.intel.com>
References: <1444161335-26734-1-git-send-email-jolsa@kernel.org>
 <37D7C6CF3E00A74B8858931C1DB2F0770196C933@SHSMSX103.ccr.corp.intel.com>
 <20151008201109.GA8621@krava.landal.opennet>
In-Reply-To: <20151008201109.GA8621@krava.landal.opennet>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



> 
> >
> >
> > 3. I think you have already handled new record type for perf stat record.
> > But the "unhandled!" message still show in the perf report -D.
> >
> > 0x598 [0x30]: PERF_RECORD_STAT
> > ... id 22385, cpu 0, thread 0
> > ... value 1752, enabled 501473097, running 501473097
> > : unhandled!      <-------
> 
> yep, I was wondering about that as well.. but it's not 'handled' in perf
> report, it just displays the raw output of the event.. but I think we could
> remove that not to confuse
> 
> and perhaps we could also add -D for perf stat report

Agree.

> 
> >
> >
> > 4. Core dump when applying --per-core -a for stat record.
> >
> > sudo ./perf stat -e 'cycles' --per-core -a record sleep 1
> >
> > ** Error in `./perf': corrupted double-linked list: 0x00000000036eb560
> > ** ======= Backtrace: ========= /lib64/libc.so.6[0x3002e7bbe7]
> > /lib64/libc.so.6[0x3002e7d2b5] ./perf(perf_env__exit+0xfd)[0x484d1d]
> > ./perf[0x47c45f]
> > ./perf(main+0x610)[0x421ac0]
> > /lib64/libc.so.6(__libc_start_main+0xf5)[0x3002e21b45]
> > ./perf[0x421bd9]
> 
> could not reproduce this one.. any chance you could compile with
> DEBUG=1 and re-run in gdb for more details? like which of the frees got
> crazy.. ?
>
The crash is not caused by this patch set. It's also a bug in current perf.
I've submitted a patch for that.
https://lkml.org/lkml/2015/10/9/575

Thanks,
Kan