From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: wangweidong.a@awinic.com, lgirdwood@gmail.com,
broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
perex@perex.cz, tiwai@suse.com, herve.codina@bootlin.com,
shumingf@realtek.com, rf@opensource.cirrus.com, arnd@arndb.de,
13916275206@139.com, ryans.lee@analog.com,
linus.walleij@linaro.org, ckeepax@opensource.cirrus.com,
fido_max@inbox.ru, sebastian.reichel@collabora.com,
colin.i.king@gmail.com, liweilei@awinic.com, trix@redhat.com,
dan.carpenter@linaro.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver
Date: Fri, 13 Oct 2023 13:50:41 +0200 [thread overview]
Message-ID: <37a2d2d1-5ede-4f88-b4e7-d9750336465d@linaro.org> (raw)
In-Reply-To: <20231013104220.279953-4-wangweidong.a@awinic.com>
On 13/10/2023 12:42, wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>
>
> Add i2c and amplifier registration for
> aw88399 and their associated operation functions.
>
> +
> +static void aw88399_hw_reset(struct aw88399 *aw88399)
> +{
> + if (aw88399->reset_gpio) {
> + gpiod_set_value_cansleep(aw88399->reset_gpio, 0);
> + usleep_range(AW88399_1000_US, AW88399_1000_US + 10);
> + gpiod_set_value_cansleep(aw88399->reset_gpio, 1);
Why do you leave the device in reset state? I think you wanted these
reverted.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-13 11:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 10:42 [PATCH V1 0/3] " wangweidong.a
2023-10-13 10:42 ` [PATCH V1 1/3] ASoC: dt-bindings: Add schema for "awinic,aw88399" wangweidong.a
2023-10-13 11:50 ` Krzysztof Kozlowski
2023-10-13 10:42 ` [PATCH V1 2/3] ASoC: codecs: Add code for bin parsing compatible with aw88399 wangweidong.a
2023-10-14 12:28 ` Herve Codina
2023-10-13 10:42 ` [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver wangweidong.a
2023-10-13 11:50 ` Krzysztof Kozlowski [this message]
2023-10-13 14:14 ` Mark Brown
2023-10-16 8:05 ` wangweidong.a
2023-10-13 14:10 ` Mark Brown
2023-10-16 8:10 ` wangweidong.a
2023-10-16 9:07 ` wangweidong.a
2023-10-16 11:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37a2d2d1-5ede-4f88-b4e7-d9750336465d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=colin.i.king@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fido_max@inbox.ru \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=ryans.lee@analog.com \
--cc=sebastian.reichel@collabora.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=trix@redhat.com \
--cc=wangweidong.a@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®