mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Jisheng Zhang <jszhang@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: dt-bindings: cdns,xspi: add sdma-io-width
Date: Wed, 20 May 2026 15:22:07 +0200	[thread overview]
Message-ID: <37a3e9dd-88c2-4d8d-8ae4-6037a1eeedcc@kernel.org> (raw)
In-Reply-To: <de325dba-0b82-4808-910b-68f0f6426c5f@sirena.org.uk>

On 20/05/2026 14:30, Mark Brown wrote:
> On Wed, May 20, 2026 at 02:16:21PM +0200, Krzysztof Kozlowski wrote:
>> On 20/05/2026 13:48, Jisheng Zhang wrote:
> 
>>> If you mean "Why this cannot be deduced from the compatible?", I think
>>> the slave dma port is part of the cdns xspi, so its io width belongs
>>> to xSPI device property.
>>> From another side, we have seen such property in other drivers such as
>>> the reg-io-width for the dw spi DW_SPI_DR port io width.
> 
>> So you mean it depends on SPI device? Then why spi-peripheral-props is
>> not applicable here?
> 
> That will be controller side, not device side.
> 
>> If this is not bus width, but DMA-something, is not really then SPI
>> device dependent, but rather DMA controller limitation, so either
>> deducible from compatible or something else is missing here.
> 
> My understanding is that this is a connection between the SPI and DMA
> controllers so it's not as obvious as it could be which side of that
> link should have the property, eg:
> 
>   https://www.cadence.com/content/dam/cadence-www/global/en_US/documents/tools/silicon-solutions/design-ip/controller-ip-qspi.pdf
> 
> shows a separate direct connection between the DMA controller and the
> xSPI controller, the DMA controller isn't interacting with registers on
> the CPU visible buses.  The width is probably a design time configurable
> option on both sides of the link.

Yes and that sounds a lot specific to particular controller, thus should
be implied by / deducible from the compatible.

Best regards,
Krzysztof

  reply	other threads:[~2026-05-20 13:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  3:17 [PATCH 0/2] spi: cadence-xspi: support 4bytes sdma-io-width Jisheng Zhang
2026-05-11  3:17 ` [PATCH 1/2] spi: dt-bindings: cdns,xspi: add sdma-io-width Jisheng Zhang
2026-05-15  8:00   ` Krzysztof Kozlowski
2026-05-19 23:38     ` Jisheng Zhang
2026-05-20  7:09       ` Krzysztof Kozlowski
2026-05-20 11:48         ` Jisheng Zhang
2026-05-20 12:16           ` Krzysztof Kozlowski
2026-05-20 12:17             ` Jisheng Zhang
2026-05-20 12:30             ` Mark Brown
2026-05-20 13:22               ` Krzysztof Kozlowski [this message]
2026-05-20 13:18                 ` Jisheng Zhang
2026-05-20 14:21                   ` Krzysztof Kozlowski
2026-05-30 12:36                     ` Jisheng Zhang
2026-05-11  3:17 ` [PATCH 2/2] spi: cadence-xspi: support 4bytes sdma-io-width Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37a3e9dd-88c2-4d8d-8ae4-6037a1eeedcc@kernel.org \
    --to=krzk@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jszhang@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome