mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Sergiu Cuciurean <sergiu.cuciurean@analog.com>,
	linux-kernel@vger.kernel.org, groeck@chromium.org,
	bleung@chromium.org
Subject: Re: [PATCH] platform: chrome: cros_ec_spi: Use new structure for SPI transfer delays
Date: Tue, 3 Mar 2020 11:01:26 +0100	[thread overview]
Message-ID: <37aa3520-10c9-ca3a-228c-68dec8f8a3a7@collabora.com> (raw)
In-Reply-To: <20200227140917.10131-1-sergiu.cuciurean@analog.com>

Hi Sergiu

On 27/2/20 15:09, Sergiu Cuciurean wrote:
> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
> ---

Applied for 5.7

>  drivers/platform/chrome/cros_ec_spi.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
> index 46786d2d679a..665ab154bb4f 100644
> --- a/drivers/platform/chrome/cros_ec_spi.c
> +++ b/drivers/platform/chrome/cros_ec_spi.c
> @@ -127,7 +127,8 @@ static int terminate_request(struct cros_ec_device *ec_dev)
>  	 */
>  	spi_message_init(&msg);
>  	memset(&trans, 0, sizeof(trans));
> -	trans.delay_usecs = ec_spi->end_of_msg_delay;
> +	trans.delay.value = ec_spi->end_of_msg_delay;
> +	trans.delay.unit = SPI_DELAY_UNIT_NSECS;
>  	spi_message_add_tail(&trans, &msg);
>  
>  	ret = spi_sync_locked(ec_spi->spi, &msg);
> @@ -416,7 +417,8 @@ static int do_cros_ec_pkt_xfer_spi(struct cros_ec_device *ec_dev,
>  	spi_message_init(&msg);
>  	if (ec_spi->start_of_msg_delay) {
>  		memset(&trans_delay, 0, sizeof(trans_delay));
> -		trans_delay.delay_usecs = ec_spi->start_of_msg_delay;
> +		trans_delay.delay.value = ec_spi->start_of_msg_delay;
> +		trans_delay.delay.unit = SPI_DELAY_UNIT_USECS;
>  		spi_message_add_tail(&trans_delay, &msg);
>  	}
>  
> 

      reply	other threads:[~2020-03-03 10:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 14:09 Sergiu Cuciurean
2020-03-03 10:01 ` Enric Balletbo i Serra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37aa3520-10c9-ca3a-228c-68dec8f8a3a7@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=bleung@chromium.org \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergiu.cuciurean@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®