From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Will Deacon" <will@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 16/18] perf: qcom_l2: Convert to platform remove callback returning void
Date: Sat, 16 Dec 2023 00:30:04 +0100 [thread overview]
Message-ID: <37ab347b-2d94-42a9-97d0-274ed8a4c791@linaro.org> (raw)
In-Reply-To: <a2587688c54834482d68fe2a44f415a649ad6477.1702648125.git.u.kleine-koenig@pengutronix.de>
On 15.12.2023 14:59, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2023-12-15 23:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 13:59 [PATCH 00/18] perf: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 01/18] perf: alibaba_uncore_drw: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 02/18] perf: amlogic: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 03/18] perf: arm-cci: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 04/18] perf: arm-ccn: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 05/18] perf: arm-cmn: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 06/18] perf: arm_cspmu: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 07/18] perf: arm_dmc620: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 08/18] perf: arm_dsu: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 09/18] perf: arm_smmuv3: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 10/18] perf: arm_spe: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 11/18] perf: fsl_imx8_ddr: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 12/18] perf: fsl_imx9_ddr: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 13/18] perf: hisilicon: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 14/18] perf: marvell_cn10k_ddr: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 15/18] perf: marvell_cn10k_tad: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 16/18] perf: qcom_l2: " Uwe Kleine-König
2023-12-15 23:30 ` Konrad Dybcio [this message]
2023-12-15 13:59 ` [PATCH 17/18] perf: thunderx2: " Uwe Kleine-König
2023-12-15 13:59 ` [PATCH 18/18] perf: xgene: " Uwe Kleine-König
2024-01-10 8:56 ` [PATCH 00/18] perf: " Uwe Kleine-König
2024-01-12 13:50 ` Will Deacon
2024-01-12 18:53 ` Uwe Kleine-König
2024-02-09 18:31 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ab347b-2d94-42a9-97d0-274ed8a4c791@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®