From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jim Wylder <jwylder@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] regmap-i2c: Subtract reg size from max_write
Date: Mon, 3 Jun 2024 13:08:11 +0100 [thread overview]
Message-ID: <37abbb4e-cac4-4278-98fb-0af75e5b3ef4@sirena.org.uk> (raw)
In-Reply-To: <ZlwfQ3ERbo5snLcK@surfacebook.localdomain>
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
On Sun, Jun 02, 2024 at 10:29:07AM +0300, Andy Shevchenko wrote:
> > (bus->max_raw_write == 0 || bus->max_raw_write > quirks->max_write_len))
> > - max_write = quirks->max_write_len;
> > + max_write = quirks->max_write_len -
> > + (config->reg_bits + config->pad_bits) / BITS_PER_BYTE;
> Interesting. regmap-spi does this slightly differently, i.e. reg/8 + pad/8.
> I'm wondering which one is more correct (potential off-by-one I suppose).
The above seems more correct if we have less than a full byte of padding.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-06-03 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 21:14 Jim Wylder
2024-05-24 4:18 ` Greg Kroah-Hartman
2024-05-29 11:08 ` Mark Brown
2024-06-02 7:29 ` Andy Shevchenko
2024-06-03 12:08 ` Mark Brown [this message]
2024-06-04 9:15 ` Andy Shevchenko
2024-06-04 11:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37abbb4e-cac4-4278-98fb-0af75e5b3ef4@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jwylder@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®