From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E52802C0274 for ; Wed, 3 Jun 2026 05:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780465184; cv=none; b=mPtrGrn08dQKtGZH1ri4MKT4+k7x2eUqvSBQFWx/xDC0o0ouvNDqO+XwOnUg/Wts70NcS906qTYDQqrDkc+eiAHvF5CGnveDi04N61Jdm/22ykPn/bn/IdU+w8Bn3fpsOeoebqccusMs0RFdy02Mpl6g03vbqdTecUCWWYSq6u0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780465184; c=relaxed/simple; bh=QWXlDTxJzDkrthRwYVwzN1NdNghfVqA6sohnVAuEH14=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f9QsRo0paSJJ+39tRCJ0o+9aOYhomRfs3p50SYsgzXqI3dsuOoynn4hXj/G8WQA1UY7fleoRgqt6PbIVGwX7q5wG6izYjEApvTL/iyI0yIPbG4nCIUcUADQbfMdDqLziDqvq13FY9+byWsmJ+jZwkhoYgBubiRtvGzOiSSYH/CY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gFwvN/NT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EbWxI49c; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gFwvN/NT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EbWxI49c" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6535WKfK2928931 for ; Wed, 3 Jun 2026 05:39:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oCMutz/MyDhFR2IPTdBR86gHzqmBqi9zc2xD34Nwwhs=; b=gFwvN/NT7sPgzj62 CKGfx2dursqnvLzRufm2muLcqMueBJEB+BZxAbEt4edrnlERAoS6j0X4Ajqx+gaK CWje20/aKu6STz3GfeF6hjFnaNSqgsiDWLE4aL5QL+Zs3Nyr95e9wbpn/yte9H7r 2A10xTZZRoPxz31s3zTCJURFa7fXLTWBwXHRSOTSoL9vLH4qSM8ZmKa3Ey9x5vtV 87PG/GyLawCCKaQ0fBcHilkCoaFpapxASjXZH5D0QgtCf+z2Zlgmhi+yscU6KBwU GYq4ko++njlorEOxyUzmrBALO/wONWxVhQNTN2kGxiD3Nyw+qxUR+z3VHr3TF351 eCOhHg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejabg0tqm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Jun 2026 05:39:42 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-36d97955899so3038253a91.0 for ; Tue, 02 Jun 2026 22:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780465182; x=1781069982; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oCMutz/MyDhFR2IPTdBR86gHzqmBqi9zc2xD34Nwwhs=; b=EbWxI49cIWjdLxRg7ZoGlgyLnx42Sk/VGtwF+pnTvTppF1vTzJ9fv1aPdWcXB7cUMR SnOgbHtzBZW5J0qA+/ucGro5gAHAFVMOAEzpe3oNAQBhB1nnXZ09AxhVFRH+fNui0kdU x6jdW2dFRx86p0h7pawdL/NTBLFCXGyWa7eBUiz4bm6OCFCbThk/HfmKLe99yiAsYiHY Uk9y/EB/buTA8nPnitMNJfASgkg1DImI/ltR94FztvDiQ7kiNFPBQE0RLia5w+MwWi2O kpwQGTYfFTVvZ0lQRAnIQU/e9W5UY/xLJIdYEDyoAACzzlVmjMJuXFx4V9NHB1dzKxPR OLIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780465182; x=1781069982; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oCMutz/MyDhFR2IPTdBR86gHzqmBqi9zc2xD34Nwwhs=; b=ZGGzemSeSsbyRueAjQ1yOFOaVfuwDkYUBbfsW+nCHAtCS07V6TrlRTkGTEQ047WZs/ VgeL74Pd7NPosPaK5XWaQR6A7Lm7GxeBaAimzu6RKS6P6plX3st10gyEenZ60N+r5w1S iklBzEStBjsjfo4PNdyYOaSYpV0HMxXXQRN439NDbsCg+f0fZwuBELFhynO/zQ0KAu4O 8Z45DulBH/09z/92TKqxyn8mIsmw+Dzm3lFz+HzK1m5JATr5DYAEYzDfqFNDjAElbjFf elu4j26LXJfxt+lCPdMuMqAVZ82PODRHv2Vs2f3fMfkFGGNBjENtz3aB/h0cVGfEpLAj XpFA== X-Forwarded-Encrypted: i=1; AFNElJ9mcemmwwNKA1Hp9I4dfTX3WFXeDZgAyvGVC3eZSZrCqNZkBWYgbZ3rUhBam+auhmqA64YwXlfXpf4ri/c=@vger.kernel.org X-Gm-Message-State: AOJu0Yzfo8Ruf8jha/7pZDK1EoHFHGPrG1G8li3w7Nv5375Xnya67GBT AJDPjOnBvJfOSK2FzOu894VReO69YgYWdEOE5ZDmecEh/x6DGYsgSCJ/8hJ57s7+T8foU0CPom8 /mgwN2U9N5c8C469vbSE3kXokGQZ1c4DFCRc4mFuzLYMSfw6qEldNXchWDkhtBdJMyg4= X-Gm-Gg: Acq92OGilLBq8qGO5hczRSqG/JMOjO6tlS3UZ8UVjUa8Larh90UL9Ux7nyzOWTLfjfi WzrV3jcTzV/SeOi077swRAEbG8MbEl32LiH6XB67m0hKxhaTQL1+n1daSsFs70zUME5d8fPzpQ/ 8LoTBAMDjxgKlA3hMoAennuCjReR3BYgmXPt+4srCWZkz70XbJpIEJInfzd1ZQzqfh3Jaxzvru4 +6TKIm6n9fwFUfCfFv27qkX/gmmuNBWAk+hoRpWTscHLExEwYMUrQs87JjFGWjlfQWPkEjxe1to 3g4JtZE0OA94wuwyyUXlmyLazZlf8B7bvgJ0GV8zfwo7GRpHYqZbUHKE9igh8d3DgUwvnJyGB0P KqpJdeFF2wQUWB8JEEBdF755Qh5Tt+CbXWCvFaElCRsHijEC+f2py2RUfsWWl X-Received: by 2002:a05:6a00:4fc9:b0:841:dcbf:e82b with SMTP id d2e1a72fcca58-84284e19ebamr2089924b3a.12.1780465181472; Tue, 02 Jun 2026 22:39:41 -0700 (PDT) X-Received: by 2002:a05:6a00:4fc9:b0:841:dcbf:e82b with SMTP id d2e1a72fcca58-84284e19ebamr2089869b3a.12.1780465180927; Tue, 02 Jun 2026 22:39:40 -0700 (PDT) Received: from [10.204.78.54] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842829188b9sm1687035b3a.59.2026.06.02.22.39.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 22:39:40 -0700 (PDT) Message-ID: <37ae68ba-6639-4bd2-9483-5aa0156fd772@oss.qualcomm.com> Date: Wed, 3 Jun 2026 11:09:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/15] accel/qda: Create compute context bank devices on QDA compute bus To: Dmitry Baryshkov Cc: Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Bharath Kumar , Chenna Kesava Raju , srini@kernel.org, andersson@kernel.org, konradybcio@kernel.org, robin.clark@oss.qualcomm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org References: <20260519-qda-series-v1-0-b2d984c297f8@oss.qualcomm.com> <20260519-qda-series-v1-6-b2d984c297f8@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 5VIizUZWo_cYmTBc9FWh9jZZNsYFLoUr X-Authority-Analysis: v=2.4 cv=Ev3iaycA c=1 sm=1 tr=0 ts=6a1fbe1e cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=qYmJ1cgbGSsHLxxvYMEA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: 5VIizUZWo_cYmTBc9FWh9jZZNsYFLoUr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDA1MSBTYWx0ZWRfXw8J5pqxZuXCN 4rtvliwcrO3gPSDWvdx0mOa2bC04n+QFo4KQJmZgbbW4l5t8P5DqTsSDMJmhL25XTM1EoA85ERN vGj0z5544B2uwBCf6bO9Zhiu4ydfT14BU+gwyj8FTUMVPymNPuRuFwR21W4ZYdR+X79zTiazCqP Ms0aVECiwW1oVQS8LGQGGNdGKhZsLZl2x6+wPvEV9L0vpjuneIUy+ZIm313PEPtDPR0ylhyeiI0 8eAJRYOcp4a5ErUoXWZZaNSPZwG1Lyk0T2KYnSxtIVgnkl+6ftEiFyWUGb80cIrpPdZsaw0wK3T 7MU91alknTAurtPypWzbJTFXXVYjLd3MbzNkmll0xD1Q/od/0qNO7MjPvBffUFBlIavLoclFy/U 88X2hSsCqRbfupQwO7IGMA9HuSBNgvjE8LN8LEwHRSW9NVTrZL21/+gsW7XlrtQXjUSoKP3wPn3 jRFli8D5BacsbywjLig== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030051 On 20-05-2026 19:53, Dmitry Baryshkov wrote: > On Tue, May 19, 2026 at 11:45:56AM +0530, Ekansh Gupta via B4 Relay wrote: >> From: Ekansh Gupta >> >> Introduce the CB (compute context bank) device management layer for the >> QDA driver. Each DSP domain node in the device tree may contain child >> nodes with compatible "qcom,fastrpc-compute-cb", each representing one >> IOMMU context bank. The driver enumerates those child nodes during >> RPMsg probe and creates a corresponding device on the qda-compute-cb >> bus for each one. >> >> The CB devices are created via create_qda_cb_device(), which registers >> them on the qda-compute-cb bus so that the IOMMU subsystem assigns each >> device its own IOMMU domain, enabling per-session address space >> isolation for DSP buffer mapping. >> >> The new qda_cb.c file provides two functions: >> >> qda_create_cb_device() >> Reads the "reg" property from the DT child node to obtain the >> stream ID, constructs a unique device name of the form >> "qda-cb--", and registers the device on the compute bus. >> A qda_cb_dev entry is allocated and appended to qdev->cb_devs so >> that the list can be walked during teardown. >> >> qda_destroy_cb_device() >> Removes the device from its IOMMU group before calling >> device_unregister(), ensuring the IOMMU domain is released cleanly. >> >> CB devices are populated before the DRM device is registered and >> destroyed before it is unplugged, so no DRM operation can race with >> CB teardown. On probe failure after population, qda_cb_unpopulate() >> is called to clean up any CBs that were successfully created before >> the error. >> >> Assisted-by: Claude:claude-4-6-sonnet >> Signed-off-by: Ekansh Gupta >> --- >> drivers/accel/qda/Makefile | 1 + >> drivers/accel/qda/qda_cb.c | 99 +++++++++++++++++++++++++++++++++++++++++++ >> drivers/accel/qda/qda_cb.h | 32 ++++++++++++++ >> drivers/accel/qda/qda_drv.c | 1 + >> drivers/accel/qda/qda_drv.h | 3 ++ >> drivers/accel/qda/qda_rpmsg.c | 12 +++++- >> 6 files changed, 147 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/accel/qda/Makefile b/drivers/accel/qda/Makefile >> index 424176f652a5..143c9e4e789e 100644 >> --- a/drivers/accel/qda/Makefile >> +++ b/drivers/accel/qda/Makefile >> @@ -6,6 +6,7 @@ >> obj-$(CONFIG_DRM_ACCEL_QDA) := qda.o >> >> qda-y := \ >> + qda_cb.o \ >> qda_drv.o \ >> qda_rpmsg.o >> >> diff --git a/drivers/accel/qda/qda_cb.c b/drivers/accel/qda/qda_cb.c >> new file mode 100644 >> index 000000000000..77caf8438c67 >> --- /dev/null >> +++ b/drivers/accel/qda/qda_cb.c >> @@ -0,0 +1,99 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include "qda_drv.h" >> +#include "qda_cb.h" >> + >> +int qda_create_cb_device(struct qda_dev *qdev, struct device_node *cb_node) >> +{ >> + struct device *cb_dev; >> + u32 sid = 0; >> + char name[64]; >> + struct qda_cb_dev *entry; >> + >> + drm_dbg_driver(&qdev->drm_dev, "Creating CB device for node: %s\n", cb_node->name); >> + >> + of_property_read_u32(cb_node, "reg", &sid); >> + >> + snprintf(name, sizeof(name), "qda-cb-%s-%u", qdev->dsp_name, sid); >> + >> + cb_dev = create_qda_cb_device(qdev->dev, name, DMA_BIT_MASK(32), cb_node); > > Wrong prefix. Pass the name format and the params to this function. Use > kasprintf in it. ack> >> + if (IS_ERR(cb_dev)) { >> + drm_err(&qdev->drm_dev, "Failed to create CB device for SID %u: %ld\n", >> + sid, PTR_ERR(cb_dev)); >> + return PTR_ERR(cb_dev); >> + } >> + >> + entry = kzalloc_obj(*entry); >> + if (!entry) { >> + device_unregister(cb_dev); >> + return -ENOMEM; >> + } >> + >> + entry->dev = cb_dev; >> + list_add_tail(&entry->node, &qdev->cb_devs); >> + >> + drm_dbg_driver(&qdev->drm_dev, "Successfully created CB device for SID %u\n", sid); >> + return 0; >> +} >> + >> +void qda_cb_unpopulate(struct qda_dev *qdev) >> +{ >> + struct qda_cb_dev *entry, *tmp; >> + >> + list_for_each_entry_safe(entry, tmp, &qdev->cb_devs, node) { >> + list_del(&entry->node); >> + qda_destroy_cb_device(entry->dev); >> + kfree(entry); >> + } >> +} >> + >> +int qda_cb_populate(struct qda_dev *qdev, struct device_node *parent_node) >> +{ >> + struct device_node *child; >> + int count = 0, success = 0; >> + >> + for_each_child_of_node(parent_node, child) { >> + if (of_device_is_compatible(child, "qcom,fastrpc-compute-cb")) { >> + count++; >> + if (qda_create_cb_device(qdev, child) == 0) { >> + success++; >> + dev_dbg(qdev->dev, "Created CB device for node: %s\n", >> + child->name); > > Stop counting successes. > >> + } else { >> + dev_err(qdev->dev, "Failed to create CB device for: %s\n", >> + child->name); > > Unwind, return error. > ack>> + } >> + } >> + } >> + if (count == 0) >> + return 0; >> + return success > 0 ? 0 : -ENODEV; >> +} >> + >> +void qda_destroy_cb_device(struct device *cb_dev) >> +{ >> + struct iommu_group *group; >> + >> + if (!cb_dev) { > > How can it be? I'll remove this.> >> + pr_debug("qda: NULL CB device passed to destroy\n"); >> + return; >> + } >> + >> + dev_dbg(cb_dev, "Destroying CB device %s\n", dev_name(cb_dev)); >> + >> + group = iommu_group_get(cb_dev); >> + if (group) { >> + dev_dbg(cb_dev, "Removing %s from IOMMU group\n", dev_name(cb_dev)); > > Be uniform. It's either drm_dbg_foo() or dev_dbg() all over the place. > Don't mix them. ack> >> + iommu_group_remove_device(cb_dev); >> + iommu_group_put(group); >> + } >> + >> + device_unregister(cb_dev); >> +} >> @@ -59,9 +61,17 @@ static int qda_rpmsg_probe(struct rpmsg_device *rpdev) >> } >> qdev->dsp_name = label; >> >> + ret = qda_cb_populate(qdev, rpdev->dev.of_node); >> + if (ret) { >> + dev_err(qdev->dev, "Failed to populate child devices: %d\n", ret); >> + return ret; >> + } >> + >> ret = qda_register_device(qdev); >> - if (ret) >> + if (ret) { >> + qda_cb_unpopulate(qdev); >> return ret; > > Unwinding registration? did I miss something here? The intention to free up the CB devices in case the device registration fails.> >> + } >> >> drm_info(&qdev->drm_dev, "QDA RPMsg probe complete for %s\n", qdev->dsp_name); >> return 0; >> >> -- >> 2.34.1 >> >> >