From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAE42183CA6 for ; Thu, 15 May 2025 06:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747290855; cv=none; b=dX3k9CazSV69fxK14Vaoud5hoqNWVB4V/sJLfqHM+B/bY4ulwla7OCc/SCbuzkFa0Ru5hXAZjld0cIs0TCOUPZyxfkQ6zm1F7bFPDctkHxCLgP9Cz2EyOyrh1Yd1oF5dNR9bgZWwcfdbZ6OdRBaEQK92CQQUqhF4nSSgHwk6KF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747290855; c=relaxed/simple; bh=UCpHFms/9fZX+PC3YHyq6WBmI7oksVfgK9RI1AUF438=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WPQgrodotDkS+Xm1Lq21KY7WVSD5D8STIk1Aq45WBccr3Ur9K2OVOAwF420RgdaZPvdUbCV5TSJZokAXuF+ef7VpsRzpMXrks4QgB3h3H2TfA0+1QwAqMdNCyxYJxul+vG2/m/9jooYaWGwd1ibKDYfAL/IMDPJel3tGPNTNHq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OKbHql4N; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OKbHql4N" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43edecbfb94so6019675e9.1 for ; Wed, 14 May 2025 23:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747290850; x=1747895650; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o/T0UCXB5vuqasYwa49l0chQi6vqaR/vGdzNl5dXsTs=; b=OKbHql4NjfeTykc17uNo8rHZ2OMXQ+2CIImGuBJeTJh9rccamrjEdgAxVD4n/UQ8x2 2tikjFXC/bffpnk0gE7Db/exYYQdXMSxjdXPJeomdyKHZ5VlcBFE6AUIj6wGJFdKukMf 1HQ68YJMF8Qjh/DGMziLgVjJz1RClLyBrC+m+SiE7Cku99zcz1gL/cKm/dKMVd7y1Vwp 9q4mzXR+OjEwgt36BLnK3LpvSQWnOm7m9jDanrc8E2ikFiqqx8/P4aQpCRB4VeZIkskl lSoQs1hO5wPmn7LNAvjzKPLELTEAYFoMoRQQLdYm+oc0/EorSvTnHnaN7cNVLLHzNcQt yH7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747290850; x=1747895650; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o/T0UCXB5vuqasYwa49l0chQi6vqaR/vGdzNl5dXsTs=; b=TERBMTX3EcKQwS/piecJyqdGdKEa3dlfB1HahSDdWjlUxNGfnmdh3kvnmz7Zr4j1Zz Ai1mKe3tk5dKeWSdNH5pAgVXgVpiIjsU0TN9pXJpsrx47dbAI6uyez0mvz0496yOKOP8 5+vuL1b9ziwTpe7969g7yVXWKIeo4d72VpUO66QnnHrxhpyfR3n271k18CI394zaYvlG duO15De8scZViviHzDuZscNJvbzrDW1i9ofZ23aTj3Dfa1/FVntsdJlhsy1yXrmCfRNR RFY7h6XE1B6HYx9kdNoFCAOoYgwjgGeqSocdUrC4T1BFvi+BAwRmBNfSOijbQfBurRqh 4UEg== X-Forwarded-Encrypted: i=1; AJvYcCWXeAK//p1iLrzkzYqBq28V1ttx0KcrAJvWiy4JdmZ9yGlIjrNJbLk5YuKsuNSNopPNO+WcoPMVQ2V5geM=@vger.kernel.org X-Gm-Message-State: AOJu0YwfRPqryJWoZ+U8OEaMTYVp5ouCxYzNolcJO7+r0EAOs77Npldz miYusCLznqvGw3PWB0h/ydrqtAnGBhKXo44LlYF34/bvdmeqmGf4/aVN+X2SbYg= X-Gm-Gg: ASbGncvlYpeFNalUsgkgRVMFrHjdiPbnZhJXEWTsfJ48i9ZejwvFzzGF6bruYF/v6Nl QohB+XYloY4uOcznh9NNiP0pra24lSNXT5GxHs9+6szrw1BJPCN6hRWe2PHT6emih0Ox0NASvlD KROQqc/bBh4A0rZOxSgTSWtkBMiK0RSGQ2dHZtsC6D+GT4YN24d2RNytwGQT4nstDPWY+Oc9FGn Ru4WuLgLgdEkh955W9+5xYG9WTzxFbrFhghTAS6iV4XTg3MAYnye0XeJbGkV5O/N7IJNngSn4KU g/b56Q6lnzvdGBBq43lMLwL0NdJdHaQ1i2YnxfAqnirbAck5ipTHukoQK4GczyP8D7C2yhjELg/ rEe9JnJjaUU9y X-Google-Smtp-Source: AGHT+IGi6GK0v/GAXDSDVd1UWmFfUHkAK0muwDMNzaFEMuRS6/TbSssIhPYz9lFtq+QsKOZ2rwrtRA== X-Received: by 2002:a05:600c:a0d:b0:43e:a7c9:8d2b with SMTP id 5b1f17b1804b1-442f21684a7mr50470315e9.24.1747290850242; Wed, 14 May 2025 23:34:10 -0700 (PDT) Received: from [10.61.1.70] (110.8.30.213.rev.vodafone.pt. [213.30.8.110]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f39e8545sm58519295e9.31.2025.05.14.23.34.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 May 2025 23:34:09 -0700 (PDT) Message-ID: <37aeea50-e149-44bc-87a8-9095afe29d42@linaro.org> Date: Thu, 15 May 2025 07:34:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/18] clk: qcom: common: Add support to configure clk regs in qcom_cc_really_probe To: Jagadeesh Kona , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Vladimir Zapolskiy , Dmitry Baryshkov Cc: Ajit Pandey , Imran Shaik , Taniya Das , Satya Priya Kakitapalli , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20250515-videocc-pll-multi-pd-voting-v4-0-571c63297d01@quicinc.com> <20250515-videocc-pll-multi-pd-voting-v4-6-571c63297d01@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250515-videocc-pll-multi-pd-voting-v4-6-571c63297d01@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/05/2025 20:08, Jagadeesh Kona wrote: > + if (!pll->config || !pll->regs) { > + pr_err("%s: missing pll config or regs\n", init->name); > + continue; > + } If you are printing error, why aren't you returning error ? I understand that it probably makes platform bringup easier if we print instead of error here. I think this should be a failure case with a -EINVAL or some other indicator you prefer. Assuming you amend to return an error you may add my Reviewed-by: Bryan O'Donoghue