From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 494EB18D4C8 for ; Tue, 30 Jul 2024 10:30:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722335412; cv=none; b=PbFVFYl6HEjEVffeq+x6gwDzcbUKxPsWRo6ohmEeRsq7a7pYj917G7CN8R+nPPBvMfQu2v3NCQMnhw3BtPE8rmIi6bWcIbs74hdvnrPAsIQUFB3gFOnNoTWrx8V9xrU8uO+XC9/K2fKbr65tTdNrXk6BlUOvFrZcPgVnlVn5g0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722335412; c=relaxed/simple; bh=O9SbpH6gaHIzGnpq5yhKSvdFI//O+nZc1t9nY3SdA0I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eO8HfRmvByLofz+pnTlL2tspPS9kUufHanR8uFsAGciWy38lvpqIjy9SSQRZLyJxek3URGAIL8kHwYPt/k0lugPgR3sFslZYq6P1dby66/ynw8LtDKIxIi8h5/D9URbawiaJSxCvfrENJJj/lpfzfAuaYwEH3uOXuZnCnEjEkOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fel2iMH/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fel2iMH/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722335410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=71oJ12BexAxBLwTBNsEMg163ErQlFG2G4IQL0JA3vsQ=; b=fel2iMH/mBd2n+SLCDKS46+T9lYbzHrZYO5XezZ3KKPtE05NPYpuNqWHb0CEN2KRoF69Yn Af9ndKzotDSwZxeYVJYEcVoUEBJlF6mq42AAxXaeCI94ZUMae2y5PvHiF0aGWog03ab8g2 sNYYNyOJF52yfgDgWxuPeFEOBtPdEaQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-G3eRtfT7O46oNenyOR4XqA-1; Tue, 30 Jul 2024 06:30:08 -0400 X-MC-Unique: G3eRtfT7O46oNenyOR4XqA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-428086c2187so2164495e9.2 for ; Tue, 30 Jul 2024 03:30:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722335406; x=1722940206; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=71oJ12BexAxBLwTBNsEMg163ErQlFG2G4IQL0JA3vsQ=; b=T1u/cJkvYkfnSTrY0e8gH/on2dc43o0TH92lGO223+ZVXuIXegiXb7tpS3qe3sKpNZ /eQP8/4Rnl+uEruQfDLJkV5ttESWE68aDHFo3WIqIPekF5YevFChIT7LRI8y9PiKh1xg Wdi8icO6ZPHOJJjwdxxqu5A8t4eXFfx+ZZYZ4QxtUI+jla+cLdMszAhmKXonDfi/toF9 xO5Zn+5Pq4IyEYV04Wb42tGcvfad5wf3e6tlHBh7Mydx4PyR7MZ/H9Xv4KA7/NRKiuwa CqZJa5rXnZuujqy3xy63qDMrI0TyMdcn45mEmIRYn/vDxWR4URL8eHJr0Tk8LIE484ou GRMA== X-Forwarded-Encrypted: i=1; AJvYcCVQ/aFhAGWsyy/AnjoNcONRDhTsDnuIGaszGI9uijXnMvao0rD3lyA4oLZWmIRVrL6c/VueGd+JxukysVwSIIxRT3lPOzTxUZrLe0kN X-Gm-Message-State: AOJu0Yw2/myV/wRpK5uw8uBTsZjtUm57Hj/HlhCkWOoGkpEqeUvq897f OEyaCfbRuqxb11eLUmJPJdTkdmaMqOxPX4MaU1jTsh7e+fBFKQ0WHte74753HZMVXc2E7h2nrw0 AmqiR3neZr87ud7q0a+8lB5wlMSZHJBvwlqzgLN4/h0j/SnNN/2nrjKCMR6JRow== X-Received: by 2002:a05:600c:5113:b0:428:18d9:4654 with SMTP id 5b1f17b1804b1-42818d94831mr34713865e9.6.1722335405978; Tue, 30 Jul 2024 03:30:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE78IgR8WxTBbit7KcSMrv8J8w859v4JL3/v1Vk6XrSheVtSe3hh+vqkGPAcKITQxqhvXEW6A== X-Received: by 2002:a05:600c:5113:b0:428:18d9:4654 with SMTP id 5b1f17b1804b1-42818d94831mr34713765e9.6.1722335405555; Tue, 30 Jul 2024 03:30:05 -0700 (PDT) Received: from ?IPV6:2a0d:3344:1712:4410:9110:ce28:b1de:d919? ([2a0d:3344:1712:4410:9110:ce28:b1de:d919]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b36857dc2sm14269596f8f.77.2024.07.30.03.30.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 03:30:05 -0700 (PDT) Message-ID: <37af317c-a40c-4af3-840a-5bbedad2e31b@redhat.com> Date: Tue, 30 Jul 2024 12:30:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net: ethernet: mtk_eth_soc: drop clocks unused by Ethernet driver To: Daniel Golle Cc: Jakub Kicinski , Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Matthias Brugger , AngeloGioacchino Del Regno , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <5f7fc409ecae7794e4f09d90437db1dd9e4e7132.1722207277.git.daniel@makrotopia.org> <20240729190634.33c50e2a@kernel.org> <738f69e6-1e8d-4acc-adfa-9592505723fe@redhat.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/30/24 12:22, Daniel Golle wrote: > On Tue, Jul 30, 2024 at 10:53:19AM +0200, Paolo Abeni wrote: >> On 7/30/24 04:06, Jakub Kicinski wrote: >>> On Mon, 29 Jul 2024 00:00:23 +0100 Daniel Golle wrote: >>>> Clocks for SerDes and PHY are going to be handled by standalone drivers >>>> for each of those hardware components. Drop them from the Ethernet driver. >>>> >>>> The clocks which are being removed for this patch are responsible for >>>> the for the SerDes PCS and PHYs used for the 2nd and 3rd MAC which are >>>> anyway not yet supported. Hence backwards compatibility is not an issue. >>> >>> What user visible issue is it fixing, then? >> >> Indeed this looks like more a cleanup than a fix. @Daniel why net-next >> without fixes tag is not a suitable target here? > > There is no user visible issue. I didn't know that this would be the > condition for going into 'net'. I will resend the patch to net-next. See: https://elixir.bootlin.com/linux/v6.10.2/source/Documentation/process/maintainer-netdev.rst#L68 The main point here is the patch looks more a cleanup than a fix. If so, please also drop the fixes tag when re-posting, thanks! Paolo