From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B74839C001 for ; Wed, 25 Mar 2026 14:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774447585; cv=none; b=MiB9vdwJknjydskInYP5AfyPaz48xOa1R4FgaS9060Jn3Di+JH1x4kCmePKAUSHH6akATrUG4cvoPTJE4j6u91MqzAu6zM1GaMdOzsgrzHTdlWpRUhypZfsvGEwN0EXQWOA7VvbO/5E4v/JDnwXmGyKeQVhhCC8vA8DnacDvjAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774447585; c=relaxed/simple; bh=2zFYnK3If3R/+VikmY1WNt//lwRC21G0j8XDz06ZRpA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HxGurx/8yikmrDoAqeLo1HGL4ce1M9Qh95zAGYpoQOxj5PN+NN+EAKn+RR5AF3hkDPuZDqF6Hq/mBb9VNdgxywTXx8pF5FPdoES4351CDlQ2QDT63lkPhsNsvXpHQeEqtU/MNcmTUQK+dNFcTZ03MYTMoPpnnqIB1NhXM+qUg6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OE+25jXK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OE+25jXK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60DECC4CEF7; Wed, 25 Mar 2026 14:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774447584; bh=2zFYnK3If3R/+VikmY1WNt//lwRC21G0j8XDz06ZRpA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OE+25jXKUV/hrSVrmqaOgdXoJFIFbgnP2O8EbYvWeib7aNojSCZo3diNdGytffiaQ /WoxXzK2pth0a9wxkH8vzR1FJoPIgV9/pMcjom5cUO5EQlIAVZR30odM6TvtyzQLBs vrpn0C6clpUG2E62g24wFre40JibMSz9eQTtk0ejODF7yMt61xo53JXSyWAddO8xCy GGgTbMSTXuLcHLZs7JhnCNetGdNznFuf3oU3d0t8/HVoGPnpl2ApkLgFlePsBKEG9R mOMsxKBNxK8vbhlwNHWL3bhZ0/I5//Arn9DjVQfrizfK9JXxQmrV+po7kLPkZ98Dur 6Qx60Krmg131A== Date: Wed, 25 Mar 2026 14:06:22 +0000 From: "Lorenzo Stoakes (Oracle)" To: Vernon Yang Cc: akpm@linux-foundation.org, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang Subject: Re: [PATCH mm-new v8 1/4] mm: khugepaged: add trace_mm_khugepaged_scan event Message-ID: <37b02aa8-164a-43cb-a45e-96162b9da38e@lucifer.local> References: <20260221093918.1456187-1-vernon2gm@gmail.com> <20260221093918.1456187-2-vernon2gm@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260221093918.1456187-2-vernon2gm@gmail.com> On Sat, Feb 21, 2026 at 05:39:15PM +0800, Vernon Yang wrote: > From: Vernon Yang > > Add mm_khugepaged_scan event to track the total time for full scan > and the total number of pages scanned of khugepaged. > > Signed-off-by: Vernon Yang > Acked-by: David Hildenbrand (Red Hat) > Reviewed-by: Barry Song > Reviewed-by: Lance Yang > Reviewed-by: Dev Jain LGTM, so: Reviewed-by: Lorenzo Stoakes (Oracle) > --- > include/trace/events/huge_memory.h | 25 +++++++++++++++++++++++++ > mm/khugepaged.c | 2 ++ > 2 files changed, 27 insertions(+) > > diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h > index 4e41bff31888..384e29f6bef0 100644 > --- a/include/trace/events/huge_memory.h > +++ b/include/trace/events/huge_memory.h > @@ -237,5 +237,30 @@ TRACE_EVENT(mm_khugepaged_collapse_file, > __print_symbolic(__entry->result, SCAN_STATUS)) > ); > > +TRACE_EVENT(mm_khugepaged_scan, > + > + TP_PROTO(struct mm_struct *mm, unsigned int progress, > + bool full_scan_finished), > + > + TP_ARGS(mm, progress, full_scan_finished), > + > + TP_STRUCT__entry( > + __field(struct mm_struct *, mm) > + __field(unsigned int, progress) > + __field(bool, full_scan_finished) > + ), > + > + TP_fast_assign( > + __entry->mm = mm; > + __entry->progress = progress; > + __entry->full_scan_finished = full_scan_finished; > + ), > + > + TP_printk("mm=%p, progress=%u, full_scan_finished=%d", > + __entry->mm, > + __entry->progress, > + __entry->full_scan_finished) > +); > + > #endif /* __HUGE_MEMORY_H */ > #include > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index c0f893bebcff..e2f6b68a0011 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2527,6 +2527,8 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, enum scan_result > collect_mm_slot(slot); > } > > + trace_mm_khugepaged_scan(mm, progress, khugepaged_scan.mm_slot == NULL); > + > return progress; > } > > -- > 2.51.0 >