From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AE3E149C77 for ; Tue, 4 Jun 2024 17:06:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717520776; cv=none; b=WaEzKqPaL9KQgKO9DdzHdd5cTp9bx87oFwCSXz7b9BhwIRi/Ttldu/tff1p13jNIwmg/NJE/6+aIwpy1q/AFexyvloHmRvotVGDGz0q4ih6/Ydhd92ed22Bx6mwosL5Sxh4kn3KMQ/nU/Q3SgKI/gyS0bWijhpaWt+KKRIX/KvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717520776; c=relaxed/simple; bh=7FZMerzyumByug0YBJaZePO62jxn9Zgedg66wnJtGLQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ft9e50d+eSeMJRwDwhJJJMOy8nQbpusfBHocgy/cREYtE6fJzm9eU0I+czfDqU8oyMK63cs3OlxW7bOuBKq6ls12uuvkLQCKKBojfD9IvHRHkc/W6g58dExfEWcNZ1Y4cK06fE5it213rJIB/TaLe3IPKcRqt/xQNcTh5V3xTgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=i3E6SxfJ; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i3E6SxfJ" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a68c8b90c85so392056666b.2 for ; Tue, 04 Jun 2024 10:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717520773; x=1718125573; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4aUMBd6S6vH1Fq76iwhEyjBkvlh36Pc3VvYRxup98QU=; b=i3E6SxfJRRCVXelXM9VViV381xYdplJpsdn/xfmEDSpzUS50fakhUXufIKuM3wHvkm iKj0beU/ibLDnZtvyzkSWR1oT91xa+FJCuH24iubMbhjPa5hZ4yfaja/w7Lr52cXvS3w Wny81Gj1+tnHjsFK39Y/wBvp25uSglOyoiJQH2pwyFHhUHbX+/PVpdOFhPpwDt9lP7u6 +ARARApUmnnmEN9fmS2gEtVFQf6MPjtZ047hyIvTtLLOcDxN+5hgKptliA9gh1HylDl0 ES42ncwvuZuAZ+f95x0GLkOJbPb2Qkv+Ei/4Qtkv2JH9ievmLFB6TcOMMvnS3E9U1QxW htHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717520773; x=1718125573; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4aUMBd6S6vH1Fq76iwhEyjBkvlh36Pc3VvYRxup98QU=; b=PmQXeKclBeIIZwhTffX77dkqF1qP/PTbyDZTtX0JPUhzECsHMv9b+Yd3TKITO54o7V 52wOrV+H26IOgM89cqWUe2S2zLJ8oWbwfS0mVIcIljkZzDvmRHai7PEmKyE2p1ThjzGc F6gpptg0yxf8YfvqraWmjcBTzVo2g5sEYyKrJN0anpfy0S479cfi9i/7ffH7ant2wrkH alBbLf/5+X+s4QXyAlzEF/5QEv2I9ggX+EKiCqQRSn6VddAZZdjWJn/2mUbKOqOP50Ew NiaMH+m8BYsElCfUqycu2N6Td6Z07YzRtk8kCUPisyj2H58HGGmkiTZNeHcRkXf/eSiq 01pQ== X-Forwarded-Encrypted: i=1; AJvYcCXdR8aF9tRqifYXfmP4jgCao3/Pzy9ZabtMdmo2AnckBOjfe6TEfZtF+N2keGmh5y5L9ug/jtfJvrjay4Knw0O9IyGtfQOjR666uQRs X-Gm-Message-State: AOJu0YyFwmH4I7osRg5llh+AO6Wlws9PbGo0odQVCpa2H5fgOtolHa27 a7CCxfoQG26+553/EunrC93BdyKfebiDCbL7BYPezBBC5hkJurlMfX/qW2v26so= X-Google-Smtp-Source: AGHT+IHT8X9AMfx+BZpwbKKAI0BGP41IwtZlUxVZrzOm9sWMjqE5bRIO+v8abCGhYG5qwitWIODsOA== X-Received: by 2002:a17:907:770c:b0:a67:7649:3c3c with SMTP id a640c23a62f3a-a69a000e966mr10970966b.56.1717520772786; Tue, 04 Jun 2024 10:06:12 -0700 (PDT) Received: from ?IPV6:2a00:f41:909a:a11e:b2c0:1360:9a97:b2b8? ([2a00:f41:909a:a11e:b2c0:1360:9a97:b2b8]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a69127f2901sm291675066b.48.2024.06.04.10.06.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 10:06:12 -0700 (PDT) Message-ID: <37b0404d-bba5-4a77-ad86-62c6dd308d37@linaro.org> Date: Tue, 4 Jun 2024 19:06:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/adreno: Add support for Adreno 505 GPU To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= Cc: Rob Clark , Sean Paul , Abhinav Kumar , Dmitry Baryshkov , Marijn Suijten , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniil Titov References: <20240604-a505-v1-1-82ee1c04d200@gmail.com> <49fe3b01-4f00-4ffc-80cf-2a0add1ebaad@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/4/24 18:45, Barnabás Czémán wrote: > On Tue, Jun 4, 2024 at 2:27 PM Barnabás Czémán wrote: >> >> On Tue, Jun 4, 2024 at 1:55 PM Konrad Dybcio wrote: >>> >>> >>> >>> On 6/4/24 02:20, Barnabás Czémán wrote: >>>> From: Daniil Titov >>>> >>>> This GPU is found on SoCs such as MSM8937 (450 MHz), MSM8940 (475 MHz), >>>> SDM439 (650 MHz). >>>> >>>> Signed-off-by: Daniil Titov >>>> Signed-off-by: Barnabás Czémán >>>> --- >>> >>> This all looks very good, just a nit >>> >>> [...] >>> >>>> + /* >>>> + * Increase inactive period to 250 to avoid bouncing >>>> + * the GDSC which appears to make it grumpy >>>> + */ >>>> + .inactive_period = 250, >>> >>> Are you sure this is actually necessary? >> Every A5XX GPU is using the same value, but i have never tried with >> DRM_MSM_INACTIVE_PERIOD. > This was the original patch > https://lore.kernel.org/all/20180507224750.9383-1-jcrouse@codeaurora.org/ > where the inactive period was increased for a530. I cannot test > suspend on msm8937 yet. The suspend here refers to device suspend, not system suspend. Adreno goes into device suspend every time you stop using it, i.e. after the rendering is done and there's no more work to do. I suppose a good test scenario here would be to keep running and closing kmscube in a rapid fashion and checking if the GPU starts crashing for unknown reasons (the dmesg would denote that) > I can check on msm8953 with a506 maybe if a506 works fine with > DRM_MSM_INACTIVE_PERIOD > then a505 would be fine with it also. The more testing the merrier :) Konrad