From: "Huang, Kai" <kai.huang@intel.com>
To: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Yamahata, Isaku" <isaku.yamahata@intel.com>
Cc: "michael.roth@amd.com" <michael.roth@amd.com>,
"Annapurve, Vishal" <vannapurve@google.com>, "Christopherson,,
Sean" <seanjc@google.com>,
"ackerleytng@google.com" <ackerleytng@google.com>,
"Chen, Bo2" <chen.bo@intel.com>,
"Shahar, Sagi" <sagis@google.com>,
"isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"dmatlack@google.com" <dmatlack@google.com>,
"zhi.wang.linux@gmail.com" <zhi.wang.linux@gmail.com>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>
Subject: Re: [RFC PATCH v2 3/6] KVM: x86/mmu: Pass round full 64-bit error code for the KVM page fault
Date: Thu, 22 Jun 2023 23:28:22 +0000 [thread overview]
Message-ID: <37b868c53c9f35e8ec051573562a4598df38d72d.camel@intel.com> (raw)
In-Reply-To: <b659f86ac7128965e05a7a660c38734667530fc0.1687474039.git.isaku.yamahata@intel.com>
On Thu, 2023-06-22 at 16:16 -0700, Yamahata, Isaku wrote:
> The upper 32 bits of error code are discarded at kvm_mmu_page_fault()
> by lower_32_bits(). Now it's passed down as full 64 bits.
> Because only FNAME(page_fault) depends on it, move lower_32_bits() into
> FNAME(page_fault).
I haven't looked into the code yet, but the last sentence around
FNAME(page_fault) doesn't make a lot sense IIUC?
For instance, we can have a shadow EPT table when EPT is enabled in L0 and
exposed to L1. If we want to pass 64-bit error code to the handler, how can
FRAME(page_fault)() depend on the lower 32-bit value?
next prev parent reply other threads:[~2023-06-22 23:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 23:16 [RFC PATCH v2 0/6] KVM: guest memory: Misc enhacnement isaku.yamahata
2023-06-22 23:16 ` [RFC PATCH v2 1/6] KVM: selftests: Fix test_add_overlapping_private_memory_regions() isaku.yamahata
2023-06-22 23:16 ` [RFC PATCH v2 2/6] KVM: selftests: Fix guest_memfd() isaku.yamahata
2023-06-22 23:16 ` [RFC PATCH v2 3/6] KVM: x86/mmu: Pass round full 64-bit error code for the KVM page fault isaku.yamahata
2023-06-22 23:28 ` Huang, Kai [this message]
2023-06-23 2:54 ` Isaku Yamahata
2023-06-23 17:18 ` Sean Christopherson
2023-06-24 4:15 ` Huang, Kai
2023-06-26 21:48 ` Sean Christopherson
2023-06-22 23:16 ` [RFC PATCH v2 4/6] KVM: x86: Introduce fault type to indicate kvm page fault is private isaku.yamahata
2023-06-23 20:04 ` Sean Christopherson
2023-06-26 1:07 ` Michael Roth
2023-06-26 18:21 ` Sean Christopherson
2023-06-27 23:58 ` Michael Roth
2023-06-28 16:53 ` Sean Christopherson
2023-06-22 23:16 ` [RFC PATCH v2 5/6] KVM: Add flags to struct kvm_gfn_range isaku.yamahata
2023-06-28 6:41 ` Yuan Yao
2023-06-28 17:03 ` Isaku Yamahata
2023-06-28 15:21 ` Michael Roth
2023-06-28 17:05 ` Isaku Yamahata
2023-06-22 23:16 ` [RFC PATCH v2 6/6] KVM: x86: Add is_vm_type_supported callback isaku.yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37b868c53c9f35e8ec051573562a4598df38d72d.camel@intel.com \
--to=kai.huang@intel.com \
--cc=ackerleytng@google.com \
--cc=chao.p.peng@linux.intel.com \
--cc=chen.bo@intel.com \
--cc=dmatlack@google.com \
--cc=erdemaktas@google.com \
--cc=isaku.yamahata@gmail.com \
--cc=isaku.yamahata@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=sagis@google.com \
--cc=seanjc@google.com \
--cc=vannapurve@google.com \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®