mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: invalid vht params rate 1920 100kbps nss 2 mcs 9
Date: Mon, 17 Jun 2024 08:40:23 -0700	[thread overview]
Message-ID: <37ba6cb0-d887-4fcf-b7dc-c93a5fc5900f@gmail.com> (raw)
In-Reply-To: <87iky7mvxt.fsf@kernel.org>

Hi Kalle,

On 6/17/24 8:27 AM, Kalle Valo wrote:
> James Prestwood <prestwoj@gmail.com> writes:
>
>> Hi Paul,
>>
>> On 6/16/24 6:10 AM, Paul Menzel wrote:
>>> Dear Linux folks,
>>>
>>>
>>> Linux 6.10-rc3 (commit a3e18a540541) logged the warning below when
>>> connecting to a public WiFi:
>>>
>>>      ath10k_pci 0000:3a:00.0: invalid vht params rate 1920 100kbps
>>> nss 2 mcs 9
>> This has been reported/discussed [1]. It was hinted that there was a
>> firmware fix for this, but none that I tried got rid of it. I got fed
>> up enough with the logs filling up with this I patched our kernel to
>> remove the warning. AFAICT it appears benign (?). Removing the warning
>> was purely "cosmetic" so other devs stopped complaining about it :)
>>
>> [1] https://www.mail-archive.com/ath10k@lists.infradead.org/msg13406.html
> More reliable link to the discussion:
>
> https://lore.kernel.org/ath10k/76a816d983e6c4d636311738396f97971b5523fb.1612915444.git.skhan@linuxfoundation.org/
>
> I think we should add this workaround I mentioned in 2021:
>
>     "If the firmware still keeps sending invalid rates we should add a
>      specific check to ignore the known invalid values, but not all of
>      them."
>
>     https://lore.kernel.org/ath10k/87h7mktjgi.fsf@codeaurora.org/
>
> I guess that would be mcs == 7 and rate == 1440?
I think its more than this combination (Paul's are different). So how 
many combinations are we willing to add here? Seems like that could get 
out of hand if there are more than a few invalid combinations. Would we 
also want to restrict the workaround to specific hardware/firmware?
>

  reply	other threads:[~2024-06-17 15:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-16 13:10 Paul Menzel
2024-06-17 15:09 ` James Prestwood
2024-06-17 15:27   ` Kalle Valo
2024-06-17 15:40     ` James Prestwood [this message]
2024-06-18 10:33       ` Kalle Valo
2024-06-18 10:48         ` Baochen Qiang
2024-06-26  8:53         ` Baochen Qiang
2024-06-26  9:12           ` Paul Menzel
2024-06-26 10:16             ` Kalle Valo
2024-06-26 11:48               ` Paul Menzel
2024-06-26 12:34                 ` Kalle Valo
2024-07-05  2:47             ` Baochen Qiang
2024-07-05  6:55               ` Paul Menzel
2024-07-05 10:51                 ` Baochen Qiang
2024-07-05 11:52                   ` Paul Menzel
2024-07-08  1:53                     ` Baochen Qiang
2024-07-08 10:36                       ` Kalle Valo
2024-07-08 10:33                   ` Kalle Valo
2024-07-09  1:33                     ` Baochen Qiang
2024-06-27 17:42           ` James Prestwood
2024-06-27 18:25             ` Kalle Valo
2024-06-28  1:25               ` Baochen Qiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37ba6cb0-d887-4fcf-b7dc-c93a5fc5900f@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome