From: Markus Elfring <Markus.Elfring@web.de>
To: Zhang Qiang <qiang.zhang@windriver.com>, linux-usb@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>
Subject: Re: [PATCH] usb: gadget: function: printer: The device interface is reset and should return error code
Date: Sun, 28 Jun 2020 15:43:10 +0200 [thread overview]
Message-ID: <37bf94a0-92a0-ca4e-a4e4-5dd44aef2b88@web.de> (raw)
I suggest to choose a more succinct patch subject.
> After the device is disconnected from the host side, the interface of
> the device is reset. If the userspace operates the device again,
> an error code should be returned.
Please use an imperative wording for the commit message.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=719fdd32921fb7e3208db8832d32ae1c2d68900f#n151
> Signed-off-by: Zqiang <qiang.zhang@windriver.com>
Did you really specify your real name here?
Regards,
Markus
next reply other threads:[~2020-06-28 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 13:43 Markus Elfring [this message]
2020-06-28 14:13 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2020-06-28 1:57 qiang.zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37bf94a0-92a0-ca4e-a4e4-5dd44aef2b88@web.de \
--to=markus.elfring@web.de \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=qiang.zhang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®