From: Andrew Lunn <andrew@lunn.ch>
To: Gavin Gao <attinagaoxu@gmail.com>
Cc: Alexey Charkov <alchark@gmail.com>,
Jiaxing Hu <gahing@gahingwoo.com>,
Frank.Sae@motor-comm.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com,
heiko@sntech.de, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH net-next v2] net: phy: motorcomm: enable the reference clock for YT8521 and YT8531
Date: Tue, 28 Jul 2026 22:54:41 +0200 [thread overview]
Message-ID: <37c2162d-134d-48c5-92d8-3355306f15ec@lunn.ch> (raw)
In-Reply-To: <CAK2JjQVsJbC5wuLs1wFvose0S9ho6FDNPbhteveWOttE0prjeA@mail.gmail.com>
On Tue, Jul 28, 2026 at 09:57:32PM +0800, Gavin Gao wrote:
> Hi Alexey,
>
> I slightly prefer keeping the helper.
>
> This looks like a common pattern for the Motorcomm family rather than a
> YT8521/YT8531-specific detail. Other PHYs in the same series may need the
> same optional reference clock handling later, and a small helper keeps
> that path easy to reuse without duplicating the same code.
Please don't top post.
Look around at other drivers. Is it generally put into a tiny helper,
or used inline?
My gut feeling from reviewing lots of drivers is that it is inline.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-07-28 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 20:56 Jiaxing Hu
2026-07-28 2:14 ` Gavin Gao
2026-07-28 4:16 ` Alexey Charkov
2026-07-28 13:57 ` Gavin Gao
2026-07-28 20:54 ` Andrew Lunn [this message]
2026-07-29 6:07 ` Gavin Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37c2162d-134d-48c5-92d8-3355306f15ec@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Sae@motor-comm.com \
--cc=alchark@gmail.com \
--cc=attinagaoxu@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gahing@gahingwoo.com \
--cc=heiko@sntech.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®