From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FF8E13CA93 for ; Sat, 26 Oct 2024 04:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.118 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729915273; cv=none; b=cq2j9sR282d41BRYrc/bIsIQKRKOWbM5BByLegADoJRgxXTo5SqCdfs98ktY4lWwmKxeaNy5jBf7axECE1OSDzhnWcP0VeZzY4B7a2qMC/OoIe3ONmrD5/G5UprVXzDnXA3bA0zVDFBUSQOiJSPNSXIpmcwhqNKk7KeRZyYevbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729915273; c=relaxed/simple; bh=4EZ3d1UlteexM+K+BBK+MaKCU/DLwbA3xw7TmAIU27M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F6zXrEJ33TK6x1bY6sVGjYyN5H0rXxpfcjBneuczWQwf6cu0WM8jcj3vu/ohNvqXSHvZx9Ap//ETP5l+9yX7Ov2SITr8qqyP87c3MqJ5/mOCBNAIf0B5M1JjsECTZJOWu4COUZTVyQ3MsVc0l6zxIi32a0h/l9DCLNGOlkHTa+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=ITIxwkFU; arc=none smtp.client-ip=115.124.30.118 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="ITIxwkFU" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1729915266; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=94xNPQ7reY27xXutMfor02Xwq25M9OnrXWxLpCbP0ak=; b=ITIxwkFUR89cjBGGLHNjd3Ok3WFaqLEbDxrjsVLduQd2LSNXjIp0dwwM3CGGLmlPndGnOzet3zHZHFE+DXoMdo5A8V+WbEGHW8mWfZTZAcpJA7viVyQ4bvn+MQSggUrQ6T65Z/ImIpsVVBFXbieG7Chtl1LH9v3KCNJik2DRgkk= Received: from 192.168.0.100(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WHu3gJ3_1729915265 cluster:ay36) by smtp.aliyun-inc.com; Sat, 26 Oct 2024 12:01:06 +0800 Message-ID: <37c82981-42bd-4208-88bc-5de234e6db13@linux.alibaba.com> Date: Sat, 26 Oct 2024 12:01:05 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: shmem: fallback to page size splice if large folio has poisoned subpages To: Andrew Morton Cc: Matthew Wilcox , hughd@google.com, david@redhat.com, wangkefeng.wang@huawei.com, shy828301@gmail.com, dhowells@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <01423085-1622-41ed-a882-64291f3e97ab@linux.alibaba.com> <20241025154527.31873b55fb75d778c431f5ef@linux-foundation.org> From: Baolin Wang In-Reply-To: <20241025154527.31873b55fb75d778c431f5ef@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/10/26 06:45, Andrew Morton wrote: > On Fri, 25 Oct 2024 11:41:28 +0800 Baolin Wang wrote: > >> >> >> On 2024/10/25 11:31, Matthew Wilcox wrote: >>> On Fri, Oct 25, 2024 at 11:26:39AM +0800, Baolin Wang wrote: >>>> The tmpfs has already supported the PMD-sized large folios, and splice() >>>> can not read any subpages if the large folio has a poisoned subpage, >>>> which is not good as we discussed in previous mail[1]. >>> >>> folios do not have subpages. folios have pages. do not use the term >>> "subpage" anywhere. ever. >> >> OK. This is my previous habit of naming it. Will change 'subpages' to >> 'pages' for folios. > > While at it, please try to avoid depending upon references to previous > email discussions. The links may be bad 10 years from now, and it's > laborious for readers to trawl through the online discussion archives > to extract the information they need. > > Including the link is fine, and potentially useful. But please also > include the relevant information right here in the changelog. Sure. Will do in v2.