From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5A172C0F8E for ; Tue, 14 Oct 2025 15:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760454927; cv=none; b=cu/vF7+FbUfVOLkbx3KMDCSJPWI7geLANGkqTVsw8zWbtq88WlHJ3DmWHIcWuwn9ahNq/srCcpLMUXph7PyeTfRcM5oFv3uz5hXez+Z2VAuLH1GQLlrEQGP9pbqo2oiFM/A2nhRy1LvkmkL7KYjgSCi8rnLce3y2fW1PfjDxvlU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760454927; c=relaxed/simple; bh=Gc9gPNIGe4cVGaM7/VR1c6hckG2H84TGLOzGhxUKmtc=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=a3kydMC1jzqFhKt6CFg2tr3bvHBMOVh6d5cRhx09b3E0ubTYHjbP74tRRbBVz3fzbX3URd1FJOW3rOy89217ycOMuu8nbJ1f7P367Gjez8RL2dkidbq+W9aSa5Uy/NSmH0Y8dRDPI1oEpn/ipDfW2jkDTHe9U5bjKXOcA2Fqsfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=HvPyWdV1; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="HvPyWdV1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1760454922; bh=Gc9gPNIGe4cVGaM7/VR1c6hckG2H84TGLOzGhxUKmtc=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=HvPyWdV1wxFBvZyKYK3CZn8nC/VkI2tIysn96BCFz5XzMqZhqLF+EJYt7bYehfEYF yoK6MX1lb1DKoZuGGqne34tIlvIzbxtWvWg7ZgmL/EjLEDMr4uH4ByWdnp1fG6D+kL SkqJl7/hrQVERBOne8VnHDTO/rJ60WLoqN4s4xRmW9GKRS6lDrlEPTt2R3VOFhi7RT /MjiGfjUPQcPqxuiAE2GaL1wMQdU/7Q12PEJO2+BKIQCrbyHKgcv18UOk8cYCNgWK1 OC0djV0mm7rNaUwhdSSmq+Ucvrwkyl9b42aA0bjK8m1zowDBSVA/WzCVsmqbORV0Fo F+pDy1WCE3STg== Received: from [192.168.1.90] (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id C878F17E1292; Tue, 14 Oct 2025 17:15:21 +0200 (CEST) Message-ID: <37c99206-4bd2-40e5-95f6-71c109bd031c@collabora.com> Date: Tue, 14 Oct 2025 18:15:21 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/6] Add HDMI CEC support to Rockchip RK3588/RK3576 SoCs From: Cristian Ciocaltea To: Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Dmitry Baryshkov , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Catalin Marinas , Will Deacon Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Algea Cao , Derek Foreman , Daniel Stone References: <20250903-rk3588-hdmi-cec-v4-0-fa25163c4b08@collabora.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 9/3/25 10:52 PM, Cristian Ciocaltea wrote: > Hello Heiko, > > On 9/3/25 9:50 PM, Cristian Ciocaltea wrote: >> The first patch in the series implements the CEC capability of the >> Synopsys DesignWare HDMI QP TX controller found in RK3588 & RK3576 Socs. >> This is based on the downstream code, but rewritten on top of the CEC >> helpers added recently to the DRM HDMI connector framework. >> >> The second patch is needed for RK3576 in order to fixup the timer base >> setup according to the actual reference clock rate, which differs >> slightly from RK3588. >> >> The following three patches setup platform data with the new information >> expected by the HDMI QP transmitter library, while improving the error >> handling in the probe path. >> >> Please note the CEC helpers were affected by a resource deallocation >> issue which could crash the kernel and freeze the system under certain >> test conditions. This has been already fixed in v6.17-rc1 via commit >> 19920ab98e17 ("drm/display: hdmi-cec-helper: Fix adapter >> unregistration"). >> >> Signed-off-by: Cristian Ciocaltea >> --- >> Changes in v4: >> - Fixed the bisect-related issues reported by Daniel by implementing >> the following operations in dw_hdmi_qp_bind(): >> * Disable CEC support when the related IRQ is not available >> * Set ref_clk_rate to vendor default in case it was not provided by >> the platform driver >> * In both scenarios, also print a warning message to highlight the >> need for fixing the platform driver >> - Simplified dw_hdmi_qp_cec_init() a bit >> * Removed the now obsolete cec->irq validation test >> * Removed the superfluous error checking and logging around >> devm_request_threaded_irq() call (it already handles all that) >> - Collected R-b tags from Daniel >> - Rebased series onto next-20250903 > > I forgot to mention that luckily there are no conflicts with the patches > introducing the hw-specific bitfield operations in next-20250903, which this > revision is based on. > > I verified the series still applies cleanly onto drm-misc-next, while commit > ad24f6e10a5f ("drm/rockchip: dw_hdmi_qp: switch to FIELD_PREP_WM16 macro") > responsible for the macro conversion can be further cherry-picked without > issues on top of all that. The resulting file content of > drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c is identical to what's > expected after applying this patch set onto next-20250903. Could we get this merged, please? This would unblock some other patchsets conflicting with it. I've just checked and it applies cleanly on top of v6.18-rc1. Also seems to work fine, at least I haven't noticed any regressions so far. Thanks, Cristian