From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Keerthy <j-keerthy@ti.com>, <linus.walleij@linaro.org>
Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<t-kristo@ti.com>
Subject: Re: [PATCH v4 2/2] gpio: davinci: Do not assume continuous IRQ numbering
Date: Wed, 13 Jun 2018 12:25:04 -0500 [thread overview]
Message-ID: <37cadc4b-7fc6-5909-b499-7e747a7ee1cd@ti.com> (raw)
In-Reply-To: <1528861237-24254-2-git-send-email-j-keerthy@ti.com>
On 06/12/2018 10:40 PM, Keerthy wrote:
> Currently the driver assumes that the interrupts are continuous
> and does platform_get_irq only once and assumes the rest are continuous,
> instead call platform_get_irq for all the interrupts and store them
> in an array for later use.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> Tested for GPIO Interrupts on da850-lcdk board.
>
> Changes in v4:
>
> * Corrected the gpio offset calculation from irq number
> using the lookup.
>
> Changes in v3:
>
> * Changed irqs type from unsigned to int
>
> Changes in v2:
>
> * Extended the logic of using saved IRQs to unbanked IRQs
> as per Grygorii's suggestion.
>
> drivers/gpio/gpio-davinci.c | 63 ++++++++++++++++++++----------
> include/linux/platform_data/gpio-davinci.h | 3 +-
> 2 files changed, 44 insertions(+), 22 deletions(-)
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
regards,
-grygorii
next prev parent reply other threads:[~2018-06-13 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 3:40 [PATCH v4 1/2] gpio: davinci: Shuffle IRQ resource fetching from DT to beginning of probe Keerthy
2018-06-13 3:40 ` [PATCH v4 2/2] gpio: davinci: Do not assume continuous IRQ numbering Keerthy
2018-06-13 17:25 ` Grygorii Strashko [this message]
2018-06-14 11:39 ` Linus Walleij
2018-06-14 11:36 ` [PATCH v4 1/2] gpio: davinci: Shuffle IRQ resource fetching from DT to beginning of probe Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37cadc4b-7fc6-5909-b499-7e747a7ee1cd@ti.com \
--to=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®