From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964973AbcHDQFm (ORCPT ); Thu, 4 Aug 2016 12:05:42 -0400 Received: from foss.arm.com ([217.140.101.70]:52166 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758699AbcHDQFl (ORCPT ); Thu, 4 Aug 2016 12:05:41 -0400 Subject: Re: [PATCH 2/2] coresight: fix handling of ETM trace register access via sysfs To: Mathieu Poirier References: <1470240752-17331-1-git-send-email-sudeep.holla@arm.com> <1470240752-17331-2-git-send-email-sudeep.holla@arm.com> Cc: Sudeep Holla , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" From: Sudeep Holla Organization: ARM Message-ID: <37cade42-0cc0-e623-59a7-ecdc9e959ba8@arm.com> Date: Thu, 4 Aug 2016 16:58:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/16 16:46, Mathieu Poirier wrote: > On 3 August 2016 at 10:12, Sudeep Holla wrote: >> The ETM registers are classified into 2 categories: trace and management. >> The core power domain contains most of the trace unit logic including >> all(except TRCOSLAR and TRCOSLSR) the trace registers. The debug power >> domain contains the external debugger interface including all management >> registers. >> >> This patch adds coresight unit specific function coresight_simple_func >> which can be used for ETM trace registers by providing a ETM specific >> read function which does smp cross call to ensure the trace core is >> powered up before the register is accessed. >> >> Cc: Mathieu Poirier >> Signed-off-by: Sudeep Holla > > Hey Sudeep, > > I'm good with this patch - just a few things to amend below. > > Many thanks, > Mathieu > >> --- >> drivers/hwtracing/coresight/coresight-etb10.c | 2 +- >> .../hwtracing/coresight/coresight-etm3x-sysfs.c | 2 +- >> .../hwtracing/coresight/coresight-etm4x-sysfs.c | 58 ++++++++++++++++------ >> drivers/hwtracing/coresight/coresight-etm4x.h | 1 + >> drivers/hwtracing/coresight/coresight-priv.h | 9 +++- >> drivers/hwtracing/coresight/coresight-stm.c | 2 +- >> drivers/hwtracing/coresight/coresight-tmc.c | 2 +- >> 7 files changed, 54 insertions(+), 22 deletions(-) >> >> Hi Mathieu, >> >> I think the latest release of the firmware(inparticular SCP v1.16.0) for > > Is this public? If so please give me the link so that we test with > the same environment. > Yes I believe so. You should be able to grab latest @[1] I agree with all the other comments, will repost v2 soon. -- Regards, Sudeep [1] https://snapshots.linaro.org/member-builds/armlt-platforms-release/28/juno-uefi.zip