From: Jon Hunter <jonathanh@nvidia.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>, <vinod.koul@intel.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<dmaengine@vger.kernel.org>, <gnurou@gmail.com>,
<thierry.reding@gmail.com>, <swarren@wwwdotorg.org>,
<ldewangan@nvidia.com>
Subject: Re: [PATCH v3 2/2] dmaengine: tegra210-adma: Add memcpy support
Date: Thu, 8 Sep 2016 15:19:57 +0100 [thread overview]
Message-ID: <37d4645c-6318-78bd-79bb-844fb6764a1b@nvidia.com> (raw)
In-Reply-To: <bafb9b89-2b45-c419-62d4-b25a50f8d6be@nvidia.com>
On 08/09/16 15:08, Jon Hunter wrote:
>
> On 06/09/16 19:42, Nicolin Chen wrote:
>> ADMA supports non-flow controlled Memory-to-Memory direction
>> transactions. So this patch just adds an initial support for
>> that. It passed a simple dmatest:
>> echo dma1chan0 > /sys/module/dmatest/parameters/channel
>> echo 1024 > /sys/module/dmatest/parameters/iterations
>> echo 0 > /sys/module/dmatest/parameters/dmatest
>> echo 1 > /sys/module/dmatest/parameters/run
>> dmesg | grep dmatest
>> Started 1 threads using dma1chan0
>> dma1chan0-copy0: summary 1024 tests, 0 failures 2054 iops 16520 KB/s (0)
>
> What board and kernel did you try this on?
>
> I have tried this on a tegra210-jetson-tx1 and I get :
>
> [ 202.569204] dmatest: Started 1 threads using dma1chan0
> [ 205.620318] dmatest: dma1chan0-copy0: result #1: 'test timed out' with src_off=0x86c dst_off=0xc80 len=0x307c (0)
> [ 208.692315] dmatest: dma1chan0-copy0: result #2: 'test timed out' with src_off=0x3288 dst_off=0x2720 len=0xa1c (0)
> [ 211.764323] dmatest: dma1chan0-copy0: result #3: 'test timed out' with src_off=0x2f44 dst_off=0x3164 len=0x3a4 (0)
> [ 214.836309] dmatest: dma1chan0-copy0: result #4: 'test timed out' with src_off=0x17d0 dst_off=0x2b10 len=0xe2c (0)
> [ 217.908305] dmatest: dma1chan0-copy0: result #5: 'test timed out' with src_off=0x23d8 dst_off=0xe90 len=0xb7c (0)
> ...
>
> I also tried a tegra210-smaug and I get:
>
> [ 167.508828] dmatest: Started 1 threads using dma1chan0
> [ 167.508870] dmatest: dma1chan0-copy0: dstbuf[0x0] not copied! Expected db, got 09
> [ 167.508873] dmatest: dma1chan0-copy0: dstbuf[0x1] not copied! Expected da, got 05
> [ 167.508875] dmatest: dma1chan0-copy0: dstbuf[0x2] not copied! Expected d9, got 26
> [ 167.508876] dmatest: dma1chan0-copy0: dstbuf[0x3] not copied! Expected d8, got 16
> ...
I tried this again on my audio testing branch for tegra210 and it worked ...
[ 36.427210] dmatest: Started 1 threads using dma1chan0
[ 37.036948] dmatest: dma1chan0-copy0: summary 1024 tests, 0 failures 2410 iops 19419 KB/s (0)
Do you have other patches in your branch? If so it would be good to understand the dependency. May be we are missing a clock somewhere?
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2016-09-08 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 18:42 [PATCH v3 0/2] Add memcpy support for tegra210-adma Nicolin Chen
2016-09-06 18:42 ` [PATCH v3 1/2] dmaengine: tegra210-adma: Add pre-check for cyclic callback Nicolin Chen
2016-09-06 18:42 ` [PATCH v3 2/2] dmaengine: tegra210-adma: Add memcpy support Nicolin Chen
2016-09-08 14:08 ` Jon Hunter
2016-09-08 14:19 ` Jon Hunter [this message]
2016-09-08 17:31 ` Nicolin Chen
2016-09-12 14:34 ` Jon Hunter
2016-09-12 20:50 ` Nicolin Chen
2016-09-13 8:52 ` Jon Hunter
2016-09-14 13:38 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37d4645c-6318-78bd-79bb-844fb6764a1b@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=dmaengine@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®