From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbdGZDwQ (ORCPT ); Tue, 25 Jul 2017 23:52:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43414 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbdGZDwO (ORCPT ); Tue, 25 Jul 2017 23:52:14 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EAA65C04D2EF Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jasowang@redhat.com Subject: Re: [PATCH] virtio-net: fix module unloading To: Andrew Jones , linux-kernel@vger.kernel.org Cc: mst@redhat.com, virtualization@lists.linux-foundation.org, Sebastian Andrzej Siewior References: <20170724133832.27364-1-drjones@redhat.com> From: Jason Wang Message-ID: <37d51fa3-21e4-ae55-6d5b-6ade97ae4bc8@redhat.com> Date: Wed, 26 Jul 2017 11:52:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170724133832.27364-1-drjones@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 26 Jul 2017 03:52:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年07月24日 21:38, Andrew Jones wrote: > Unregister the driver before removing multi-instance hotplug > callbacks. This order avoids the warning issued from > __cpuhp_remove_state_cpuslocked when the number of remaining > instances isn't yet zero. > > Fixes: 8017c279196a ("net/virtio-net: Convert to hotplug state machine") > Cc: Sebastian Andrzej Siewior > Signed-off-by: Andrew Jones > --- > drivers/net/virtio_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 99a26a9efec1..f41ab0ea942a 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2743,9 +2743,9 @@ module_init(virtio_net_driver_init); > > static __exit void virtio_net_driver_exit(void) > { > + unregister_virtio_driver(&virtio_net_driver); > cpuhp_remove_multi_state(CPUHP_VIRT_NET_DEAD); > cpuhp_remove_multi_state(virtionet_online); > - unregister_virtio_driver(&virtio_net_driver); > } > module_exit(virtio_net_driver_exit); > Acked-by: Jason Wang