From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24C3D329378 for ; Tue, 3 Feb 2026 22:16:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770156982; cv=none; b=YY+a0QRpWZvxyEPx/S3W/kbd9oKXnwQ1OHUwvJM5rlPHbcBuH+k9o2nbWuGc54wyuFQv/PZhCdYr+8dKehzmryV15f9k2oesTOluyk+//1cY6ZrmRGRBG9l8PMxtrkh3vZYV2WDtlVTXk1p0y40/qinMtUioNkAyip+RAgSxIuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770156982; c=relaxed/simple; bh=Is5GYtZerD0NK6E8ZXSCoqOK+wq8akx9no2ZxVMphmY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ToxQE7tyQy6kC+/fUl7ddMAzOwIS59sYrAUxObczYHw/Jhdurgh26hU4VDNSoMAIurn8aqcSSTlWEXTgQ9CG1G9/vD/6fYrGoGAYVDxxaIvkX3s3VHOV4K33vc1Or1hZ4sDA6Ttd1M2wVkQJtN6Ha/qClz1Wlt5gZjIDFQnrM0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=CNGGKORq; arc=none smtp.client-ip=209.85.161.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="CNGGKORq" Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-6611cab8ca3so3894622eaf.3 for ; Tue, 03 Feb 2026 14:16:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1770156979; x=1770761779; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7c0NPTkqLZrpseRrb77cJ9keUj/pZc1R94Glr/7UpBo=; b=CNGGKORqtFd3qtxzeCJZhThoKg8Nrfi+14pIM4nFOXok9C6uQOU0kJBh8Z6FQUWnMV 0CwzPvF6wDiDrqrQDqouK4LFcbWwm6T9ccEXMdohS3+ZVBkjEnp8TFM5nM9U2XwhFneX 90Dwo+3Kc2vVqXtZ+vzW+Q7AUaPibt/zqeUzKRD0QjxURzBPdpuNqFfuFQKF0NaZK5NR 9zWveKK5cHluQuRmeuwfqO8fAL6rzDU4AtJdzdxgcRu2Ks45N90CJo+OHE6VH45agw+l Z54HKeifdJeU2dKO8cK6pzz8psKCvWPH59Zq+9yIVB1Fo3E2JiZ427bEpljIAWxD6pda 2opA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770156979; x=1770761779; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7c0NPTkqLZrpseRrb77cJ9keUj/pZc1R94Glr/7UpBo=; b=ezG/HvW2JPucZaRH5f+wfD9Jc0KU1FytwLn5cALMdYwUmjtcWJTXmDGx3p0ST+k6pa ohz6+MwbyZN1YX9fpSv4ymX/gEJLo33t961yAG5R6cgmBK05RJENNHBFelpsFcse5ycB 910S84TPUmLsteQYYhi84M58QvrNNavZmAEddu6wypGafhem3IxEgQZN5JzVhZj+gMb7 T77krp57NvkbBOONqeAJ2ESO4jjm37Gofgyq1ld4SgbcD8QUHNgv7aeUop6KUwLcHech FgGpb1+1DGXKO2GJJximKvp5+Z036O6XauCcecBGudWRuuzb41HKyvqUDBgrV7F4vYVT 0qCw== X-Forwarded-Encrypted: i=1; AJvYcCV8IxyvbF3lQlte5xbx09d14xIAva+4A4tkQ1zAjxfIyijmj8m2FJB5hs5RqRo3bn5G/tBRyqvBv0yVvkA=@vger.kernel.org X-Gm-Message-State: AOJu0YzmEu27RtnxW+CCrz0yyuFOfL8BfJDUSJzsWb0jun9toUAlyYdu BPqxt02RdLULwhJR4z/Ly9IFPsHnamf/som/UqIy+HwkdXqytxj3fKaqSrMx/LWqfRk= X-Gm-Gg: AZuq6aIMBy80qcOaZoAGbfPc2/EgJrChaPtGdlFTokEBr2iG92lP+HVtlrUCLHy3cwt tFSQTy4ytt9xOjTxpxFvlEHJQ/aFllv5u+qis4EQSsAOPo8EH5lwZwWeHT+QvanIc9kVVo57bcJ lyvU3hXSGaJMzoeD9P0qXZV9C6lxplaOMq28bVM1BQQOpEe7g5axLvcnla8AW2YwaRuKA1aY2C0 Bsz3oudVFGj5OChMyp9HqfGeUF6r+uBPCwoH1alsuP0v3LYtbBA19efSbHfP8ov97NNBELTrpsq fywjS/KAXNXW3or1mEMv++2ApwmhS/UQaLu38hGFvZy0Z/L1e+65Mlk8XVo1ZXAdC/lf7fUVUtG JpKNzwBxSvWdiVRariFyWceDGfN9SnvArGXieUeXvtfmZuqmu3m5DucsqMZprPzjG3zQM+qdC8z 2p/gS+/Hns6sS3qd2zu/ATIY3ipSFtxc4d/O6HKuDw7J/qgOYKOg3tSfk= X-Received: by 2002:a05:6820:f09:b0:65f:66c5:c3e with SMTP id 006d021491bc7-66a20d658eemr547793eaf.22.1770156979083; Tue, 03 Feb 2026 14:16:19 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:8e13:880:992:e796? ([2600:8803:e7e4:500:8e13:880:992:e796]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-40a544e77fdsm481769fac.21.2026.02.03.14.16.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 14:16:18 -0800 (PST) Message-ID: <37d5b1a4-93e2-4fde-ab56-186d34f8835b@baylibre.com> Date: Tue, 3 Feb 2026 16:16:17 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 01/18] dt-bindings: clock: Add MediaTek MT8189 clock To: "irving.ch.lin" , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Richard Cochran , Bartosz Golaszewski , Chen-Yu Tsai , Miles Chen Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Qiqi Wang , sirius.wang@mediatek.com, vince-wl.liu@mediatek.com, jh.hsu@mediatek.com References: <20260202062840.342707-1-irving-ch.lin@mediatek.com> <20260202062840.342707-2-irving-ch.lin@mediatek.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260202062840.342707-2-irving-ch.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/2/26 12:28 AM, irving.ch.lin wrote: > From: Irving-CH Lin > > Add dt schema and IDs for the clocks of MediaTek MT8189 SoC. > The MT8189 clock IP provide clock control for main system > (apmixedsys, topcksys and vlpcksys) and > subsys (eg. peri, mfg, venc/vdec ...). > > +#define CLK_TOP_VOWPLL 174 This one seems out of place. It is not used in the driver. It is a fixed 1:1 divider AFAKCT, so should not be included. (And this line has spaces while the rest of the file uses tabs for indent.)