From: Balbir Singh <balbirs@nvidia.com>
To: Bradley Morgan <brads@mainlining.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] taskstats: reuse na in cgroupstats_user_cmd()
Date: Mon, 2 Nov 2026 13:54:00 +1100 [thread overview]
Message-ID: <37db45ed-872c-4519-8240-226aeb79232b@nvidia.com> (raw)
In-Reply-To: <20261101005743.3022780-3-brads@mainlining.org>
On 11/1/26 11:57 AM, Bradley Morgan wrote:
> cgroupstats_user_cmd() already pulled CGROUPSTATS_CMD_ATTR_FD into na to
> check that the user sent it, then indexes info->attrs[] a second time to
> read the value out of the very same attribute. Read it from na.
>
> No functional change.
>
> Signed-off-by: Bradley Morgan <brads@mainlining.org>
> ---
> kernel/taskstats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/taskstats.c b/kernel/taskstats.c
> index 35e9fa71526cc..9e11f92216861 100644
> --- a/kernel/taskstats.c
> +++ b/kernel/taskstats.c
> @@ -417,7 +417,7 @@ static int cgroupstats_user_cmd(struct sk_buff *skb, struct genl_info *info)
> if (!na)
> return -EINVAL;
>
> - fd = nla_get_u32(info->attrs[CGROUPSTATS_CMD_ATTR_FD]);
> + fd = nla_get_u32(na);
> CLASS(fd, f)(fd);
> if (fd_empty(f))
> return -EBADF;
Reviewed-by: Balbir Singh <balbirs@nvidia.com>
next prev parent reply other threads:[~2026-11-02 2:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 0:56 [PATCH 0/4] taskstats: four more tidy-ups in the genl path Bradley Morgan
2026-11-01 0:57 ` [PATCH 1/4] taskstats: use nla_put_u32() in mk_reply() Bradley Morgan
2026-11-01 0:57 ` [PATCH 2/4] taskstats: take the inode once in exe_add_tsk() Bradley Morgan
2026-11-02 2:57 ` Balbir Singh
2026-11-01 0:57 ` [PATCH 3/4] taskstats: reuse na in cgroupstats_user_cmd() Bradley Morgan
2026-11-02 2:54 ` Balbir Singh [this message]
2026-11-01 0:57 ` [PATCH 4/4] taskstats: use div_u64() for the elapsed time in tgid_stats_add_task() Bradley Morgan
2026-11-02 2:52 ` Balbir Singh
2026-11-02 2:59 ` [PATCH 1/4] taskstats: use nla_put_u32() in mk_reply() Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37db45ed-872c-4519-8240-226aeb79232b@nvidia.com \
--to=balbirs@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=brads@mainlining.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®