From: Stephen Boyd <sboyd@kernel.org>
To: "Alexandru Ardelean" <aardelean@deviqon.com>,
"Andrey Skvortsov" <andrej.skvortzov@gmail.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andrey Skvortsov <andrej.skvortzov@gmail.com>
Subject: Re: [PATCH] clk: fix slab-out-of-bounds error in devm_clk_release
Date: Tue, 22 Aug 2023 15:24:25 -0700 [thread overview]
Message-ID: <37ddd03b5c6f7a32f1733d9b6122d06b.sboyd@kernel.org> (raw)
In-Reply-To: <20230805084847.3110586-1-andrej.skvortzov@gmail.com>
Quoting Andrey Skvortsov (2023-08-05 01:48:47)
> Problem can be reproduces by unloading snd_soc_simple_card, because in
> devm_get_clk_from_child data were allocated as `struct clk`,
> but devm_clk_release expects `struct devm_clk_state`.
>
[...]
> Fixes: abae8e57e49a ("clk: generalize devm_clk_get() a bit")
> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> ---
Applied to clk-fixes but I removed the state->exit assignment because
that's the default. I also noticed that devm_clk_put() is broken in a
similar way. Sheesh!
prev parent reply other threads:[~2023-08-22 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-05 8:48 Andrey Skvortsov
2023-08-22 22:24 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ddd03b5c6f7a32f1733d9b6122d06b.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=aardelean@deviqon.com \
--cc=andrej.skvortzov@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®