From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6DFC351C36 for ; Mon, 4 May 2026 12:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777899577; cv=none; b=RsPqEFV4ScD0WS7CBwgiRGIgoyTsgHrsTb9WPd2ArbD1ZxC9lOrIQdPxh8DAQSrV1a0fYk40Q4ABeIdGM11MTjAu4GybPBjHTI/thQJ5CVBEOiI0hmWGRydGCwvZAp/aFia7PYG/tmsGzSBtd8f+VHNxptbZwObqASa7aHFHknk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777899577; c=relaxed/simple; bh=8oxK3IhGVNPPTa2xJCn3EsUQQ1fhP+dEFGLVno1UGGg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=FcWzBZnvwzQ6N9Geo18vlO/hRyVTDwd/DF/A3ZP2/THaXVBNRjScVkaodFc2Q1srmjYjLqH2WrC7c00+IUIus379fXlMiUHz72pim8P9LwcVRjNmeNcJCY7tXZ8dcNgir/QUrZ90v3SVv5pnCS6gP3zkjH/kfi9cEU2hZPaWuwc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=LXPW/T4f; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=zClKCYPG; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=fFNDdVze; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=pMvQpNhY; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="LXPW/T4f"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zClKCYPG"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="fFNDdVze"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="pMvQpNhY" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D02386B1C7; Mon, 4 May 2026 12:59:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777899574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UM5QyzgTjiWTX3lrq/APlllIDV3I//2OQDFSDNUZdog=; b=LXPW/T4fAT1YlLLx3TJdOUlzwyeyfr9q4OljvnS7U3K0PXbt3JVvvr2nUJKpP4Vx+3V7+s Vn4M6R7TxFvjdpoWh+7QFM5zYfMZIpDW/93WI+XLce00/fyG+4i+SF5LlxtrN5R5xvccT3 7SLF9ox5M9hnJNMpWtd1t3j2rgb7dn0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777899574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UM5QyzgTjiWTX3lrq/APlllIDV3I//2OQDFSDNUZdog=; b=zClKCYPGNZFf4UeKa5E8WVehlH5DfrM8QwfDLl8OAMQjFMiesOwJuIogbzgBZvtbpxBpUX 9PFliZMxzdDXtIBw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777899573; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UM5QyzgTjiWTX3lrq/APlllIDV3I//2OQDFSDNUZdog=; b=fFNDdVzellFRUmSCNWf2YPmyr+zqfL1hamSwqvQFNlCQOASXgm+1e8zfYoY+5tVjquVmX5 ju72RKrEyF0bjsQbxaTCEcs6/J1Ji9f794P56euLFAnyTqaJIYxbLoA+R2p/WTbfuS83mt sxSU6KC81FfqwrpDxf+z5+rWZCRWBZw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777899573; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UM5QyzgTjiWTX3lrq/APlllIDV3I//2OQDFSDNUZdog=; b=pMvQpNhYp+JlCkJSk1Ph2nmiTuv8YG2aBobD52oo08ClsNykpKJZ9UDTj6FXfMk3IIGcUB M6sFixzvOV6ZzODA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 92A9D593A3; Mon, 4 May 2026 12:59:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qBFxIjWY+Gl+eQAAD6G6ig (envelope-from ); Mon, 04 May 2026 12:59:33 +0000 Message-ID: <37e95374-bb59-4903-9a61-c90d221bf4cc@suse.de> Date: Mon, 4 May 2026 14:59:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/fb-helper: Fix clipping when damage area spans a single scanline To: Francesco Lavra , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260210173545.733937-1-flavra@baylibre.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -4.30 X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[baylibre.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch,redhat.com,lists.freedesktop.org,vger.kernel.org]; RCPT_COUNT_SEVEN(0.00)[8]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; URIBL_BLOCKED(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo,suse.com:url]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,suse.de:mid,imap1.dmz-prg2.suse.org:helo,baylibre.com:email] X-Spam-Flag: NO Hi Am 30.04.26 um 17:35 schrieb Francesco Lavra: > Friendly ping Sorry, forgot this patch. It's merged now. Thanks a lot. Best regards Thomas > > On Tue, 2026-02-10 at 18:35 +0100, Francesco Lavra wrote: >> When the damage area resulting from a dirty memory range spans a single >> scanline, the width of the rectangle is calculated dynamically because it >> may not coincide with the framebuffer width. >> If the dirty range ends exactly at the end of the scanline, the `bit_end` >> variable is incorrectly assigned a 0 value, which results in a bogus clip >> rectangle where the x2 coordinate is 0. This prevents the dirty scanline >> from being flushed to the hardware. >> Change the calculation of the `bit_end` value to fix the x2 coordinate >> value in the above edge case. >> >> Fixes: ded74cafeea9 ("drm/fb-helper: Clip damage area horizontally") >> Signed-off-by: Francesco Lavra >> --- >>  drivers/gpu/drm/drm_fb_helper.c | 2 +- >>  1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_fb_helper.c >> b/drivers/gpu/drm/drm_fb_helper.c >> index 4b47aa0dab35..d545342d24b3 100644 >> --- a/drivers/gpu/drm/drm_fb_helper.c >> +++ b/drivers/gpu/drm/drm_fb_helper.c >> @@ -608,7 +608,7 @@ static void drm_fb_helper_memory_range_to_clip(struct >> fb_info *info, off_t off, >>                  * the number of horizontal pixels that need an update. >>                  */ >>                 off_t bit_off = (off % line_length) * 8; >> -               off_t bit_end = (end % line_length) * 8; >> +               off_t bit_end = bit_off + len * 8; >> >>                 x1 = bit_off / info->var.bits_per_pixel; >>                 x2 = DIV_ROUND_UP(bit_end, info->var.bits_per_pixel); -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)