From: Rajendra Nayak <rnayak@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
andy.gross@linaro.org, ulf.hansson@linaro.org,
viresh.kumar@linaro.org
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] arm64: dts: msm8996: Add rpmpd device node
Date: Tue, 10 Apr 2018 09:49:37 +0530 [thread overview]
Message-ID: <37ec8f55-8726-1ce1-70f6-3dfac7198158@codeaurora.org> (raw)
In-Reply-To: <152328979897.180276.15963925877442657158@swboyd.mtv.corp.google.com>
On 04/09/2018 09:33 PM, Stephen Boyd wrote:
> Quoting Rajendra Nayak (2018-03-15 21:08:22)
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> index 0a6f7952bbb1..43757a078146 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> @@ -297,6 +297,52 @@
>> #clock-cells = <1>;
>> };
>>
>> + rpmpd: qcom,rpmpd {
>
> power-controller? power-domain-controller? power-domains? Or something
> like that.
>
>> + compatible = "qcom,rpmpd-msm8996";
>> + #power-domain-cells = <1>;
>> + operating-points-v2 = <&rpmpd_opp_table>, /* cx */
>> + <&rpmpd_opp_table>, /* cx_ao */
>> + <&rpmpd_opp_table>, /* cx_vfc */
>> + <&rpmpd_opp_table>, /* mx */
>> + <&rpmpd_opp_table>, /* mx_ao */
>> + <&rpmpd_opp_table>, /* sscx */
>> + <&rpmpd_opp_table>; /* sscx_vfc */
>> + };
>> +
>> + rpmpd_opp_table: opp-table {
>
> This should go into the root of the tree? Otherwise it may be populated
> by the RPMh platform populate code which would be odd. We should go and
> update the platform populate code to always ignore operating-points-v2
> compatible nodes too.
>
>> + compatible = "operating-points-v2", "operating-points-v2-qcom";
>
> This is backwards? I thought more specific compatible went first.
thanks for the review, will fixup all of these when I respin.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2018-04-10 4:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 4:08 [PATCH 0/7] Add powerdomain driver for corners on msm8996 Rajendra Nayak
2018-03-16 4:08 ` [PATCH 1/7] PM / OPP: Add dev_pm_opp_get_of_node() Rajendra Nayak
2018-04-07 13:00 ` Stephen Boyd
2018-04-09 3:22 ` Viresh Kumar
2018-04-09 15:17 ` Jordan Crouse
2018-03-16 4:08 ` [PATCH 2/7] soc: qcom: rpmpd: Add a powerdomain driver to model corners Rajendra Nayak
2018-03-18 12:52 ` Rob Herring
2018-03-16 4:08 ` [PATCH 3/7] dt-bindings: opp: Introduce qcom-opp bindings Rajendra Nayak
2018-03-16 4:33 ` Viresh Kumar
2018-03-26 22:22 ` Rob Herring
2018-04-07 13:05 ` Stephen Boyd
2018-03-16 4:08 ` [PATCH 4/7] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2018-03-16 4:35 ` Viresh Kumar
2018-03-16 5:52 ` Rajendra Nayak
2018-03-16 4:08 ` [PATCH 5/7] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2018-03-16 4:38 ` Viresh Kumar
2018-04-09 16:03 ` Stephen Boyd
2018-04-10 3:40 ` Viresh Kumar
2018-04-10 4:19 ` Rajendra Nayak [this message]
2018-03-16 4:08 ` [PATCH 6/7] mmc: sdhci-msm: Adapt the driver to use OPPs to set clocks/performance state Rajendra Nayak
2018-03-16 4:41 ` Viresh Kumar
2018-03-16 4:08 ` [PATCH 7/7] soc: qcom: rpmpd: Add a max vote on all corners at init Rajendra Nayak
2018-03-16 4:41 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ec8f55-8726-1ce1-70f6-3dfac7198158@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®