From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BEEC313274 for ; Tue, 2 Dec 2025 12:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764679109; cv=none; b=laXL6TPW4hpD+8nSrgPejkxh4Hy3DW0wpznmAgTRz/mymHjwQWGRJNZ7x8AaEeuiDZ9jL/QyBTi2fB+5ShxeRKastA5S9XjdKFZY11vEtoHnol/ERRK6IfDEYnhb/kXHnG3nNHOBrxXePfsRX5qe42BpQ6lN0S7reMzNV/FD2d4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764679109; c=relaxed/simple; bh=uV2yKzrBnqbLp8nyRPDUN46vL0tWE3xD6CqzQmunFNM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=ap72l/YwYkLPV29t+8vSGOXk+9qMsnMkAI4Olb9//1Rp/ebq6l4sSS7T49gZc/8hkkPFZLjY7SyvCb0K2d5ibV8SjyLIz709ORBEfsjW1+34kQ9Pex7xMEtVuzkF1N+bVtPftxZhXKHfxZRKNi1il5juaNMKaKlyOrRujPKJTjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AjBQackm; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KF/VO+1d; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AjBQackm"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KF/VO+1d" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764679105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PV3JdNWJLnF3OTTD+K5SeEhcg1ng/+g4E+BqW+0ykII=; b=AjBQackmVOOW0H3EoOdtHjn83MTPsgvvLF6Ow4UoQSz2yKxbPcPHTxCYyBSqzT1ZNHZtUQ 60lGmBCWZVS7JofOma+pMIAwXwLArOEuYZQ1eIkT7EJdBbJl7fpU8tmqWv3eGys4ltIeKp UVD336ezEIgQdRabOji0BcjL4kfjkAE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-uTiDfp3KMHiTOVpGbI0Eww-1; Tue, 02 Dec 2025 07:38:24 -0500 X-MC-Unique: uTiDfp3KMHiTOVpGbI0Eww-1 X-Mimecast-MFC-AGG-ID: uTiDfp3KMHiTOVpGbI0Eww_1764679103 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4779ecc3cc8so25748785e9.3 for ; Tue, 02 Dec 2025 04:38:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764679103; x=1765283903; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=PV3JdNWJLnF3OTTD+K5SeEhcg1ng/+g4E+BqW+0ykII=; b=KF/VO+1dWxhe2UX8a9sXNqXBNgtn70i2/rLjd5IpSDzHuPjf7iqU6A7HFvvYR362vE yBmQjqN5UjhlgJ2uiDPmEZpdNY+njrEk6BR87a2qFhttAF+8j8gurcLyPQH2aTTBTNhm P+S8h/x1/osPia9hdmEVz+Ht6oR4+9Jg/Vly+3sj2dEUoafYCqGCVOkwIYg7nRgcgTYN JpwTqUQ0Kc9Dct5x3jvs0HjCat00tffhbrqS8n61jeveL6kBxm5fzrsleavbA4fd7Q29 M4uXkRsYezRk2K/Inh3mnWdb1VnMI6b5AHvwumpWPeb14bPm6ULXexe+klylMUR2KmSG qvTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764679103; x=1765283903; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PV3JdNWJLnF3OTTD+K5SeEhcg1ng/+g4E+BqW+0ykII=; b=nd8tMTN3aypWEi3JGWD6rWs6jr/yNp5SDYTSjbQZxK4LLNwjNXidVZoJ7Lllh4k8lg B8Z4rjFw1yRGfRUR2UcCNfpCuDsYgGf2hA95pdkqEOls/BzNDSQLyXwnwDjFjyCP8HBW gk5PwZsSYitL5N4hM4+EwD4kz3u6j6FcRAZ2IEdcmyDoCnaC4LRL/FgZsTyQ3R2XYD9y qHfQ2RADGh6xsTlrmY9kfj9XAgrFzZ7KLBUUnBB66HtHr+7gpkg+fGqRw7hnaHMfRwMY WCRzGlvZKNnycspLpFl/i6RrUcMmEdm5lS/CeiXZ4wVISgWxQ7EhEJIO3R0BdqzJ/uZO 3RdQ== X-Forwarded-Encrypted: i=1; AJvYcCVqCRt9A9SYekL49tb8DcjCD4CrJbYDSGuaLknZETgnBOZHs+fg1SjO+X5dH+GmupOfHK9V6bzixvTIHOU=@vger.kernel.org X-Gm-Message-State: AOJu0YzODV+aEi9V+6b2Z4wdm1uY/tcmPwu/T+oHZxyFCcqbMJ00H1uZ FcPASFLRC5CO6KlimaoM6hz5Jb9o2gcTINyHKdeI3apBuIq7wfyCtVBFVkLhMYvQ5Ux3GIaw5at zUgSRrjdvkv8jqgGQXcfdOq/o+83WXGBgnrAbB1AjqpEjqM6r3qaICe+9TJnx8VdPnA== X-Gm-Gg: ASbGnct4YJ3sva9eU/GYJ1hC2D5aOueJi0pXzrVKVNv58kZOsJPdQBwolOv0sh8aEMO J1eGKERd/wpehVQDHSUXgQeGkP4GL0PQ+VskKDhkNg0D7kOqLiChsO7uzaDzOMh1338nOFAgwyI YKBI6x0gnFg+g3TqLqPNsiCkUR3yly8zGcY86QfqIPJ4MlHVVhhTRLsJ256a/i/1OupLHgaqU92 X6ZMW5fHbiHxIrEcFgGWGclUtrQqmbW2jQqRALE+KZk10CS5+kxJqbRN+kmsGoE0Tc9OpHv9zQh 1ysshYpIRwEC98Wj7QYu5MRwWdMNgmFf1m4qZ5B8fBYxhj5uOeuc+xhSSFj/jjyWPZrv4pDpfIs R/fxX4SCqCG46Ag== X-Received: by 2002:a05:600c:5252:b0:477:89d5:fdac with SMTP id 5b1f17b1804b1-47904b26093mr348084835e9.31.1764679103391; Tue, 02 Dec 2025 04:38:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhY65J2KcZC7O5uPXBux2WRLGgbkP2OaDQQoHDloa+Y0pfFZ8qz7Pom+8kc+ipJeiPz/8PxA== X-Received: by 2002:a05:600c:5252:b0:477:89d5:fdac with SMTP id 5b1f17b1804b1-47904b26093mr348084515e9.31.1764679102987; Tue, 02 Dec 2025 04:38:22 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.136]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479279baac2sm14218335e9.4.2025.12.02.04.38.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Dec 2025 04:38:22 -0800 (PST) Message-ID: <37ecfff6-19da-4b0d-9623-129431d5a218@redhat.com> Date: Tue, 2 Dec 2025 13:38:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 1/1] net: mdio: reset PHY before attempting to access ID register To: Buday Csaba , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <5701a9faafd1769b650b79c2d0c72cc10b5bdbc8.1764337894.git.buday.csaba@prolan.hu> Content-Language: en-US From: Paolo Abeni In-Reply-To: <5701a9faafd1769b650b79c2d0c72cc10b5bdbc8.1764337894.git.buday.csaba@prolan.hu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/28/25 2:53 PM, Buday Csaba wrote: > When the ID of an Ethernet PHY is not provided by the 'compatible' > string in the device tree, its actual ID is read via the MDIO bus. > For some PHYs this could be unsafe, since a hard reset may be > necessary to safely access the MDIO registers. > > Add a fallback mechanism for such devices: when reading the ID > fails, the reset will be asserted, and the ID read is retried. > > This allows such devices to be used with an autodetected ID. > > The fallback mechanism is activated in the error handling path, and > the return code of fwnode_mdiobus_register_phy() is unaltered, except > when the reset fails with -EPROBE_DEFER, which is propagated to the > caller. > > Signed-off-by: Buday Csaba IMHO this deserves an explicit ack from phy maintainers. Unless such ack is going to land on the ML very soon, I suggest to defer this patch to the next cycle, as Jakub is wrapping the net-next PR. Thanks, Paolo