From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA2EBC43142 for ; Tue, 31 Jul 2018 14:26:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B93720841 for ; Tue, 31 Jul 2018 14:26:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XMWhwf+M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B93720841 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732408AbeGaQGw (ORCPT ); Tue, 31 Jul 2018 12:06:52 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:40556 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732222AbeGaQGv (ORCPT ); Tue, 31 Jul 2018 12:06:51 -0400 Received: by mail-io0-f193.google.com with SMTP id l14-v6so13161608iob.7 for ; Tue, 31 Jul 2018 07:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lcv7/ijN6gYHVjVHbvAVO+/gcdU9+BEB+pn28qZwMcw=; b=XMWhwf+MmY6sNmR43aF88udxFVrRdZe/1OpZz6JT92keZ21ZIGI5j1PkU9TtX2wl3u jF8oTIwelVDvDlrMwKcAraPXZ53rrblQ3EnyTperct018chXsrh6+EkXbIhmzCiggh6G 1SjB1HLGigpw9JjF9x1p9Zk9XIHmzOE9y3voM9W9ArDOp5yweLEnf+sPYy1oX/2d35uO zVT+ltQWSoaz0eAkN7nQd7h4UjLj+5Xw6EkNWs7GGEPDJyTnDDQf8MsGYuGa6grlSYUQ CsxGCUZwQW2MsfBWMYHs++f8uAobER6STVHsSL5Hz8WMCIscIWAGym/SuvA0BCY0mJkI cA5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lcv7/ijN6gYHVjVHbvAVO+/gcdU9+BEB+pn28qZwMcw=; b=tiU1FmdV15TqOPvHTpG87PYl2BFIoyalXGaCq0QkFQn3RcOgOkcSwfIOeB96UUw5OI rXB7a/nhYrGR1mNjbycfwMGo7Ogwf8DZkx+flj9wHbvseDTWq6Sy8IfCsGe9k0FW9xe1 SzooFyucGUny2SIhd93Nwa07QghaEKEndxjWsXhAOQ+qJmT85oHxYWyplHytp7rvJSNb L0xqfYdlUtokoDNmGmfN9EYI2ubZJ/RGAkVkPDj8LWYa/EozzPDQJgHn9G8na53OG/KA 8pkO8q9+XcjJz4gyjZ4iP0PCoqPG2sqy6TRjl2m3Rh0q7/SOA0PotBZAINgks/0/6n1t AyFw== X-Gm-Message-State: AOUpUlHxqTAXqDZGWOXn9hpSVnt30awQtaEq3c4fvpoO8JAupwS/90Vu 13FJGe02dS9wgUFOckP+ku8Up/yzbZo= X-Google-Smtp-Source: AAOMgpdBd0RLrRTTfZ9pEUlrJgV5/Upti6Jisg5rWrjGoL1A0A+31+R6Qg5kr0xLgZA2yyYIWVAwyQ== X-Received: by 2002:a6b:82da:: with SMTP id m87-v6mr16412556ioi.279.1533047177094; Tue, 31 Jul 2018 07:26:17 -0700 (PDT) Received: from [10.0.2.15] ([72.138.96.106]) by smtp.gmail.com with ESMTPSA id a11-v6sm1608004ita.21.2018.07.31.07.26.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Jul 2018 07:26:16 -0700 (PDT) Subject: Re: [PATCH 0/6] rapidio: move Kconfig menu definition to subsystem To: Alexei Colin , Andrew Morton Cc: John Paul Walters , Catalin Marinas , Russell King , Arnd Bergmann , Will Deacon , Ralf Baechle , Paul Burton , Alexander Sverdlin , Benjamin Herrenschmidt , Paul Mackerras , Thomas Gleixner , Peter Anvin , Matt Porter , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mips@linux-mips.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20180730225035.28365-1-acolin@isi.edu> From: Alex Bounine Message-ID: <37edb8c5-a16f-ea39-5da8-312d138ce442@gmail.com> Date: Tue, 31 Jul 2018 10:26:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180730225035.28365-1-acolin@isi.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Alexandre Bounine On 2018-07-30 06:50 PM, Alexei Colin wrote: > The top-level Kconfig entry for RapidIO subsystem is currently > duplicated in several architecture-specific Kconfig files. This set of > patches does two things: > > 1. Move the Kconfig menu definition into the RapidIO subsystem and > remove the duplicate definitions from arch Kconfig files. > > 2. Enable RapidIO Kconfig menu entry for arm and arm64 architectures, > where it was not enabled before. I tested that subsystem and drivers > build successfully for both architectures, and tested that the modules > load on a custom arm64 Qemu model. > > For all architectures, RapidIO menu should be offered when either: > (1) The platform has a PCI bus (which host a RapidIO module on the bus). > (2) The platform has a RapidIO IP block (connected to a system bus, e.g. > AXI on ARM). In this case, 'select HAS_RAPIDIO' should be added to the > 'config ARCH_*' menu entry for the SoCs that offer the IP block. > > Prior to this patchset, different architectures used different criteria: > * powerpc: (1) and (2) > * mips: (1) and (2) after recent commit into next that added (2): > https://www.linux-mips.org/archives/linux-mips/2018-07/msg00596.html > fc5d988878942e9b42a4de5204bdd452f3f1ce47 > 491ec1553e0075f345fbe476a93775eabcbc40b6 > * x86: (1) > * arm,arm64: none (RapidIO menus never offered) > > Responses to feedback from prior submission (thanks for the reviews!): > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-July/593347.html > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-July/593349.html > > Changelog: > * Moved Kconfig entry into RapidIO subsystem instead of duplicating > > In the current patchset, I took the approach of adding '|| PCI' to the > depends in the subsystem. I did try the alterantive approach mentioned > in the reviews for v1 of this patch, where the subsystem Kconfig does > not add a '|| PCI' and each per-architecture Kconfig has to add a > 'select HAS_RAPIDIO if PCI' and SoCs with IP blocks have to also add > 'select HAS_RAPIDIO'. This works too but requires each architecture's > Kconfig to add the line for RapidIO (whereas current approach does not > require that involvement) and also may create a false impression that > the dependency on PCI is strict. > > We appreciate the suggestion for also selecting the RapdiIO subsystem for > compilation with COMPILE_TEST, but hope to address it in a separate > patchset, localized to the subsystem, since it will need to change > depends on all drivers, not just on the top level, and since this > patch now spans multiple architectures. > > > Alexei Colin (6): > rapidio: define top Kconfig menu in driver subtree > x86: factor out RapidIO Kconfig menu > powerpc: factor out RapidIO Kconfig menu entry > mips: factor out RapidIO Kconfig entry > arm: enable RapidIO menu in Kconfig > arm64: enable RapidIO menu in Kconfig > > arch/arm/Kconfig | 2 ++ > arch/arm64/Kconfig | 2 ++ > arch/mips/Kconfig | 11 ----------- > arch/powerpc/Kconfig | 13 +------------ > arch/x86/Kconfig | 8 -------- > drivers/rapidio/Kconfig | 15 +++++++++++++++ > 6 files changed, 20 insertions(+), 31 deletions(-) >