From: Bryan O'Donoghue <bod@kernel.org>
To: david@ixit.cz, Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vikram Sharma <quic_vikramsa@quicinc.com>,
Kapatrala Syed <akapatra@quicinc.com>,
Hariram Purushothaman <hariramp@quicinc.com>,
Richard Acayan <mailingradian@gmail.com>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH] media: dt-bindings: Correct camss VDDA PLL supply description
Date: Sat, 13 Dec 2025 07:28:32 +0000 [thread overview]
Message-ID: <37ef8a9e-0ebc-4d31-99e1-3f0512d73412@kernel.org> (raw)
In-Reply-To: <20251212-docs-camss-fixes-v1-1-5c011505ff59@ixit.cz>
On 12/12/2025 22:55, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
> voltage from the description.
>
> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Added only Fixes tag for the initial commit, not all the copy-paste
> propagated ones.
> ---
> Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> index 019caa2b09c32..9009cfe993d75 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> @@ -130,7 +130,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> index ee35e3bc97ffd..cb922f90fe900 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> @@ -129,7 +129,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> index c99fe4106eee9..2231d7216f62a 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> @@ -268,7 +268,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> required:
> - clock-names
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> index 35c40fe223767..8e6ca94c88695 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> @@ -95,7 +95,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> index 82bf4689d3300..d50e096b900db 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> @@ -211,7 +211,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> required:
> - clock-names
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> index ebf68ff4ab961..ccd2d024bfd10 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> @@ -300,7 +300,7 @@ properties:
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + Phandle to regulator supply to PHY refclk pll block.
>
> required:
> - clock-names
>
> ---
> base-commit: d9771d0dbe18dd643760431870a6abf9b0866bb0
> change-id: 20251212-docs-camss-fixes-0fa525271951
>
> Best regards,
> --
> David Heidelberg <david@ixit.cz>
>
>
>
I think this is copy/paste legacy error.
The voltage level should be more usefully encoded in the name anyway.
---
bod
next prev parent reply other threads:[~2025-12-13 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <-p_V50_c9ufrDqGMvZ5pwIXywQxh2C6Rjo4IEUlVAeFJouqq3zlWRt-VsIRsCmGwuvslk9MU3XxtxyTZrXuSSg==@protonmail.internalid>
2025-12-12 22:55 ` David Heidelberg via B4 Relay
2025-12-13 3:18 ` Krzysztof Kozlowski
2025-12-13 7:28 ` Bryan O'Donoghue [this message]
2025-12-14 0:04 ` Vladimir Zapolskiy
2025-12-14 9:35 ` David Heidelberg
2025-12-16 1:10 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ef8a9e-0ebc-4d31-99e1-3f0512d73412@kernel.org \
--to=bod@kernel.org \
--cc=akapatra@quicinc.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=hariramp@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=quic_vikramsa@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®