From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E492BA45 for ; Sun, 5 Oct 2025 04:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759640123; cv=none; b=Ivcn0VVwyjGzih5SSj2Yn9fPF7xOqOcPLdYtaaZQjSckQoIhiQA7mmfoZo3qupf2YiCMV+QossLbWBxOhiliNUFfreh/OdlefgmG8mmktAOSS4QBxQBUfE+kEq6mkhMVVbyBg5ez2wHKpk7gtLNaOrGvbUrNzTqhkC8mg5hwNMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759640123; c=relaxed/simple; bh=uUxZnW5KUkMiHEzGNRHBsp+KaVM7fDpIrP+h9PlG5Rw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CFcBU/T2fIWNFyjaXwRdAed+74ti8Mix98pQ8IIGaDQRSDXzFy6EGMgDpRxmF5rbNC01i1FKOp/+KbY4in1yDjcEIhtR928MVccpLaqCJeQOXAxVNVNB5InaO/HqwOvzTLfZ5XMe6Ty1pS/nzcyaj3pdbwiWXRWm0pAQajsNjEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FUoKGH6d; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FUoKGH6d" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-781ea2cee3fso3559456b3a.0 for ; Sat, 04 Oct 2025 21:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759640121; x=1760244921; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l9ES7sgSCHDlhobwO0ZrFKVNTVshI11voBNNIhtfWjA=; b=FUoKGH6dnOK6ESX9CySoBBsh8dD9OYlQ9zEhdkedYJpLQATW4x17vUQ+BXDA3UDS9F wAnAAePn1EFbUKdyDkZXVPa4UaJSHm76B6pJmY7MT46h+7rH0x4bSEZ0xzGlSdRtVWbF 98NP18UNddcO6fMnABNOXRrToDiu5I7KwLuk0XrnfBD4dN68JGyVm1oHrwx+ia47Ntyi ixM1/UrgvvbVmt9GCEtAG/myNDMVwBctTMpGwZq515dLaAPSl5OINEqWWzlWDdgDd3kZ 6+/6uFHI2bL2d2cR0pHFSjmOjZBsU4W8+xeGo4sgo01l8V5TY23lTWPqlYqIQrZp2DKy EEWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759640121; x=1760244921; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l9ES7sgSCHDlhobwO0ZrFKVNTVshI11voBNNIhtfWjA=; b=KMyDFcyf6PoEb8HUr13eK6sYa28RD6XeQdxMBY3wEQEYwRrHgjbmaEER3G75K4/rMe qHNRxDBedx5kPb7ZNz9eoRtK0RpkPKrcMLfdWYApuGSeBBflcYy4v7SDDY/wSSaAtcvl H1AZOqFDlsE8J8+E97Egzhpe0/LFmhK0vNESjt/JWmcoTsl67fVjed8weBzF2A7kTy8Y 9Q31DfPDlzhmH9UjGgyfY4E+ye7zQxe5HMOMpyK9tbyC+ZDrTafnIV6X+xdT0f9N5zDY 4Kxna8IWXdQMgNnpkQl6HDDRLct5Y1xG5Hj3975VtOKygs87q/A05MbCHI4//sarJC9x ayXQ== X-Forwarded-Encrypted: i=1; AJvYcCWHz6fgNUx0Pi6S+toUQKs/tDb2q5msPu+4oBMOTqJCSpEoMnIVWLNyaVukXXwbSmE8878hyCQ13yWr+IM=@vger.kernel.org X-Gm-Message-State: AOJu0YyRNaRsq4ab3UNbIABvys3kmldPGWpFV27BTuaT8IfJT5X5aT1K XQbeL9SUsMdDYZyJu/3rZXtvtneHWcTkxhj9z5swIMYSZbpbyLS/s7kA X-Gm-Gg: ASbGncurzGMlGhqPcWtmhA6kd8Jz83Q362CFcVnpykU/ArJu5mLYyvgvSLeJgnXE2qR CI9+Nhd84pM7nxjRAwgPEoUW/Wf/jdxpsGDK31CkYTWfpSNP8Fv+dEvQdHjjgaQB9gFYhibnUWN wsm6lLQ9CwAhqcs5ovrbmd+nkAbE76GVByRiQdKJI4y6K2hS3JAVjFaJc07yLVngJ72kk4YjNwt OFcYXdEQsWgq5VJX/zm9HTWamq30WiEtRXhzfJCPKRJTzWkURFbbMgqP06uUml24yYw8KhuTXZU 960csMQsEjlWheNAvgKWE7PAdwh5d6YqV80jhPB2HMHVYgSPdAmTa+/JqYOtoGN9So55bOLOECk F8xmH2lPCFz1/e6HmGbIENZJRAMnQ0ztTUkpggCaBvby7t0WsHLJal7fr1rry33elfn7zZpfx8I BsuU6yUQesr3qfkFq8I8jMWQGDgWP79coJknc= X-Google-Smtp-Source: AGHT+IHrXDCzsLNximokCsFX8BTq6/xEQSVOcieVuoemZgV4yRTvna8trHt71DcqUkLSfovmVG7MFg== X-Received: by 2002:a05:6a21:999d:b0:2f6:cabe:a7a8 with SMTP id adf61e73a8af0-32b6209626amr10163253637.32.1759640121168; Sat, 04 Oct 2025 21:55:21 -0700 (PDT) Received: from [192.168.68.61] (104-12-136-65.lightspeed.irvnca.sbcglobal.net. [104.12.136.65]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b6099d4cfbesm8686558a12.28.2025.10.04.21.55.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Oct 2025 21:55:20 -0700 (PDT) Message-ID: <37f2603e-8c51-4f92-a7af-0e60cd577004@gmail.com> Date: Sat, 4 Oct 2025 21:55:19 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/5] Upstreaming Pinephone Pro Patches To: Dragan Simic Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Ondrej Jirman , "Leonardo G. Trombetta" References: <20250921-ppp_light_accel_mag_vol-down-v3-0-7af6651f77e4@gmail.com> <53eabe34a310ea9c74315fa09a604e4a@manjaro.org> <115da845d9161e6ecfa67cf189b84aa8@manjaro.org> Content-Language: en-US From: Rudraksha Gupta In-Reply-To: <115da845d9161e6ecfa67cf189b84aa8@manjaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Dragan, > Thanks for improving the patch descriptions in the v4 of this series. > I just went quickly through the v4 and it looks much better. > > It could be said that the new patch descriptions are now a bit too > verbose, in the sense that the test procedures and their results could > be summed up a bit better in prose, instead of providing the "raw" > inputs and outputs.  However, it's still better to have those, than > not to have anything.  Writing good prose is a skill that usually > requires learning and practice. Awesome! I was hoping that others would comment on the testing I've done (especially for the accelerometer and magnetometer patches) as I can't tell if userspace is wrong or if my testing/conclusion is wrong. Mobile Linux is very early stages at the moment, and I suspect the Pinephone and Pinephone Pro were used as reference devices with Megi's downstream kernel. Wrong mount matrices in the downstream kernel might be affecting userspace. This means that with the corrected mount matrices in this patch series, userspace is slightly broken (eg. since I fixed the accelerometer, the screen in Phosh and KDE Plasma are upside down. I suspect KDE's Kompass and Leonardo's compass app might be the same if I'm changing the mount matrix for the magnetometer). This is why I decided to showcase the raw values in my testing. If my testing is incorrect, please feel free to let me know. I think I will leave my testing in the commits itself this time. If the mount matrices are correct based on my testing, it will probably be helpful in the future in identifying why downstream is slightly broken. > You haven't done anything technically wrong, but the way you submitted > the v2 and v3 made them feel a bit like you picked those patches from > some random place and submitted them to the mailing list without really > understanding the subject matter.  In other words, it's the contributor's > job to convince everyone else that the submitted patches are fine to > become accepted, and the v2 and v3 simply lacked that. That's fair. I was under the assumption I had to keep the patches mostly in its original form. > I wonder how would some forge prevent "spamming"?  It isn't about the > possible "spamming", but about the act of submitting different versions, > which would be present regardless of the way they'd be submitted, and > the reviewers would need to be aware (i.e. "spammed") of them anyway. At least with Gitlab & Codeberg, a lot of the notifications can be muted (I believe updates to pull requests is one of them) and pipelines can be created to ensure that formatting is correct and that the proper sub maintainers are notified automagically. In my opinion, b4 just brings some of the forge's functionalities into an email based workflow, but will have to fight it's own problems such as: https://social.kernel.org/notice/AypvdTWyAs5km0Gc3k. I don't mean to detract from it; it is very commendable what Konstantin Ryabitsev is doing. If there are concerns about centralization, there are alternatives like Radical. I heard that Codeberg is looking to also decentralize in the future as well (Maybe using Radical's protocol? Not sure). If there is a call to action from the Linux maintainers about looking into decentralized forges, I bet there would be many projects excited to be used by the Linux kernel. It will also help get new people excited to be involved in the Linux kernel and potentially become kernel maintainers in the future I think I will leave it at that, as I don't want to further derail the conversation from the ppp series. Rudraksha