From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>,
Wesley Cheng <wcheng@codeaurora.org>,
"peter.chen@nxp.com" <peter.chen@nxp.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/3] usb: gadget: composite: Split composite reset and disconnect
Date: Fri, 8 Jan 2021 02:19:30 +0000 [thread overview]
Message-ID: <37f3412c-9e91-eb1e-3974-bb16546b4b39@synopsys.com> (raw)
In-Reply-To: <87k0srcyq7.fsf@kernel.org>
Hi Wesley,
Felipe Balbi wrote:
> Hi,
>
> Wesley Cheng <wcheng@codeaurora.org> writes:
>> +void composite_reset(struct usb_gadget *gadget)
>> +{
>> + /*
>> + * Section 1.4.13 Standard Downstream Port of the USB battery charging
>> + * specification v1.2 states that a device connected on a SDP shall only
>> + * draw at max 100mA while in a connected, but unconfigured state.
> The requirements are different, though. I think OTG spec has some extra
> requirements where only 8mA can be drawn max. You need to check for the
> otg flag. Moreover, USB3+ spec has units of 150mA meaning the device
> can't draw 100mA (IIRC).
>
We see issue with this patch series. For our device running at SSP, the
device couldn't recover from a port reset and remained in eSS.Inactive
state.
This patch series is already in Greg's usb-testing. Please review and
help fix it.
We can see the failure once the patch "usb: gadget: configfs: Add a
specific configFS reset callback" is introduced.
Thanks,
Thinh
next prev parent reply other threads:[~2021-01-08 2:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 23:03 [PATCH 0/3] Add vbus draw support to DWC3 Wesley Cheng
2020-12-29 23:03 ` [PATCH 1/3] usb: dwc3: gadget: Introduce a DWC3 VBUS draw callback Wesley Cheng
2020-12-29 23:03 ` [PATCH 2/3] usb: gadget: composite: Split composite reset and disconnect Wesley Cheng
2021-01-05 13:14 ` Felipe Balbi
2021-01-08 2:19 ` Thinh Nguyen [this message]
2021-01-08 8:35 ` Jack Pham
2021-01-08 22:04 ` Thinh Nguyen
2021-01-08 9:13 ` gregkh
2021-01-08 22:13 ` Thinh Nguyen
2020-12-29 23:03 ` [PATCH 3/3] usb: gadget: configfs: Add a specific configFS reset callback Wesley Cheng
2021-01-04 15:45 ` Greg KH
2021-01-04 19:03 ` Wesley Cheng
-- strict thread matches above, loose matches on Subject: below --
2020-11-14 8:12 [PATCH 0/3] Add vbus draw support to DWC3 Wesley Cheng
2020-11-14 8:12 ` [PATCH 2/3] usb: gadget: composite: Split composite reset and disconnect Wesley Cheng
2020-11-16 13:44 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37f3412c-9e91-eb1e-3974-bb16546b4b39@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®