From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6B751F2B88 for ; Thu, 25 Jun 2026 04:33:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782362020; cv=none; b=IGI6YKvlBPRVm1NTS4CjLk5zk2YzRZhPByR1YNoI3Rro7WXivkaFfJi0c/SSYY9lVHbRTx1DQ2f/QqmF3frW7rSgL1OadcNzKEW0KG/6rsvUSaPqKRtHYgrrXTvyNkdrY+yvQYUU14AqOzEicvB2i33BAB7ykInAFku6XCRHrU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782362020; c=relaxed/simple; bh=di87V4TuWc8GxaW2bpmtLqkg86RNsVY13ZKDNnUAke8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rwgZ/qhLDNvaoWPXv7BJSfdqtkGEqkaPWHKJ7wELKm1UUDbKnDXEfXlVi1x399A5YOCLEtJtKlGVQyk2jKJQwkpcDW1sexlnhYJbVJdJQkcLPNvGj+Yodw+fTzKlQSXxOAtMc/tBDyoI6la1J0SoCVM4rxYxqkGsIBrQ7wTa+D4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EWmExZUF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PWSH4snW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EWmExZUF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PWSH4snW" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65P3e6IJ655620 for ; Thu, 25 Jun 2026 04:33:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0+FT5jSvovKl8mmSq0cLr6FQpeeAxgbMVrgag/p1Y74=; b=EWmExZUF1I3+nn1z iwUXTnwl0sTFyMMiydaHqbC2SdsIEEj/T8YdA0Z2lp9x3g3z+5Ui/Yf29u7CFRd5 ZS5eTePRAFHD4tWDh21LqlNr5oZ9XT+WpRLtFVXeGX+Xd/lAN4oQjCt6SH7RNL58 HVWk6A6aVw8rtbBP4920wvJJ/OvKNmEvg8tqX7PwzWtJpH4utoGKh4liwjunQD6W J1bJamDStUNdGsziDCsoXAdLkCoa5aVVxUPCrj4l4CHPzQflZ37lDDyr5EzbErq0 bFebqKrzn9MWtRi6HN6cfCv4Qli7LfXjyTV3+WLyuM5Cb6VFHglxqixqV6Q2VFnY nv2AHQ== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0nv7hkm8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 04:33:38 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-30c011c7cb9so5194256eec.1 for ; Wed, 24 Jun 2026 21:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782362018; x=1782966818; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0+FT5jSvovKl8mmSq0cLr6FQpeeAxgbMVrgag/p1Y74=; b=PWSH4snWfILMzzVwiN+0Bwajlw7779aLYskcLfRHl0JNnfB4QW6AgHRo7WRIFqSlSN IscHnOQCASaLJAQTe2BkElc8W6J5PXQpUM7hjL9/tHd7KsxqhWTc+J+F71JQtQP3m332 7asklkRRdj16d/bN+gxfDUeXm0VmuHYS5Yip+ECcHFFmcf33NvizxnRSer7rMZPPyCLy oLFja2eyrfEVfDhaJOKPZwzXVL/SPXhpSswEAuNbNL50X4Ds4itnoQAG+NTBXT9OEEYG zFrXYidpzqwPxy6KAHqoRg5kJ9wyujVWcM/VIXlENW+KHgW6LMkY4f6MXz6Tp9zYJwET QawQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782362018; x=1782966818; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0+FT5jSvovKl8mmSq0cLr6FQpeeAxgbMVrgag/p1Y74=; b=I///tpUWbkR3SrT/VVFq7Ut09SKgNtf6Sn/Bv+BS1MLSontYZR3OEsJukaCKbJDYEi QKp9dZ+Oq7Dsznjby+Poss/BG1zjiq5svTr5wKmR1W0YRJQXC25n5Rm5ro50vvzD0NpY IABcX3j8/B3Vb7t0LR1VXomu11FuTGDaCiqRrayK8tv4uNwbQnpHcqDQYfZ4FpMfAyJu OHtU6rJgwpLbPjUsdT+75pgph9j29U9zYpw1UwM2XBmChYRN9+g60D5fmXMBdBjczxaC G/KWxTqYGeY09MQ42sEaKIqhHApKgGt1O/V1I+6wxFsyJghvmG6fIJ4qMx1XjiuYv180 vy2g== X-Forwarded-Encrypted: i=1; AHgh+RqvrF05IMP4ehAmtggvwncOE+7R46A+CNHaFJfT/X/pcOWqhJFtD0KsBYxfNsiAHjb+oC2u7+l21Oi4Ptc=@vger.kernel.org X-Gm-Message-State: AOJu0YzonDlXnh+8T6CdbTUMqHMeml9arBNqvzURYBo/D3AqYWJYzavI ydhndBbDf/pqwATCJ6i01VcHLHd0QuMdLYURn5J5xJ9DSKVKcJWMam3Dmyon/ME4vREx2PNQsOZ MONUtIXMc5NrWLyhNjnahNEc49lb3vH+FnSekOfFhpPhL3kdDIW6eyHYaqdl/Er6K294= X-Gm-Gg: AfdE7ckbXJLqkjBfLIuVpSU2qH9Gn2EGxIvRCo45c4q/RgrhoTSLNUlFGMVdvAvLlKK sgdRz4DzCNs50fn13g52EZOIQzyfrtFgrGaXSGq7QbHCXb7u3KUz19TCDfiCh2L8YZEfqGmOegW VkoLaXTJFc0dYgFz6VnO39a5bFbgLBRCtUYDXumKQ80zWj/N9hW6eeCbwz5KuLrv8xRMoaTsUYm lVpu3g4svKOc3Q+JlQMXe/yd82z6gp2gIncMyJspjxIHpYaNuof+xQyVsaXbUnQFZMb68uZDnus 5RU7jmpeEkUwpLsM4jVIK4IaTVIJScLsKFg0wuzuJiTNdU4z58OsSyUKGa0Pfxt+9Kk9JgVY6NR DGEd+pZsifhV12YeKfJOiSQt1+Cet9f6bA939u0U= X-Received: by 2002:a05:7300:7308:b0:2dd:c066:bf7 with SMTP id 5a478bee46e88-30c84e2074cmr1135172eec.11.1782362018187; Wed, 24 Jun 2026 21:33:38 -0700 (PDT) X-Received: by 2002:a05:7300:7308:b0:2dd:c066:bf7 with SMTP id 5a478bee46e88-30c84e2074cmr1135135eec.11.1782362017677; Wed, 24 Jun 2026 21:33:37 -0700 (PDT) Received: from [10.218.15.172] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7c52c664sm4251756eec.8.2026.06.24.21.33.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 21:33:37 -0700 (PDT) Message-ID: <37f34aff-c68f-43ca-b23c-500cc9bb119e@oss.qualcomm.com> Date: Thu, 25 Jun 2026 10:03:32 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] pinctrl: qcom: Unconditionally mark gpio as wakeup enable To: Konrad Dybcio , Bjorn Andersson , Linus Walleij , Neil Armstrong , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Maulik Shah References: <20260616-enable_wakeup_capable_gpios-v3-1-fb59647d89cb@oss.qualcomm.com> Content-Language: en-US From: Sneh Mankad In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDAzNyBTYWx0ZWRfX9lOuTK3xH4w+ AAcrPhIXaYqsSEG4twJao8McOmCeEnzzFW4xmomspEftbJBBAR/WzGZ5Z++IKIRUNDLWgqYM/gC DiJvxVuRX25TMNz9/kh5Na29JOBZqn4= X-Authority-Analysis: v=2.4 cv=RJiD2Yi+ c=1 sm=1 tr=0 ts=6a3cafa2 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=K6J0lT_fCWCxxGhrr3QA:9 a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-ORIG-GUID: WZAa4v64n-6W_43Q-a8mFwLl7HlT28wB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDAzNyBTYWx0ZWRfX1HmbamgnSXa8 BA+LRLhnSv+UjhxUDThgSAY2CQEQSzpua4luQvQT7Ezh7L+p4jUr6UNJMeoyP74Q/7yGgeHQ3Vc Fgpc+Kxdte2+roqzECAE0GEW7ZGbmS6xObbvoxObx1mqZtyffcASkASiUytxZR2De0kPIWG96FO Eaa192RgTlomZlyErUjGVlEz83iAdyhlM2AyHdicOkVT5OsDJEfcSZDU/4xMjr7k1jTj5gZTiH1 MvLRbbqo3O7YF2AnKcUBOFkCWPgMVBu2GxdIVPxsHf37JND8n0QTHf3yyUmdulCQoPP8TzyMPpT i3y0Gpeer6JTkSchAnTNmqRQqtxW7R99/L29KI5Jcbl/RsSKX58lIdsL7pTClahsXNbB11dOXtA IlqZggbnhWWTYycb9QEgQDe9+G6DB25E9I+CvbKaNeUk4KWMGSqcvqZ6ABX6+6ZrXmFrqWp+7H9 ZRQ7a2rDnVU3WDNGcow== X-Proofpoint-GUID: WZAa4v64n-6W_43Q-a8mFwLl7HlT28wB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_01,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250037 [...] > > This is a much better commit message, thank you! > > One question remains - should we set skip_wake_irqs for MPM too? > > My understanding is that no, since the MPM HW is simpler and doesn't > have a register for acking IRQs, so we need to do it from the recipient > (TLMM). Is that right? > Yes that is correct. skip_wake_irqs is set for PDC since PDC can handle interrupts during active time and SoC sleep time both, so any wakeup capable interrupt source can be handled via PDC at all times. However MPM can only handle interrupts when SoC is in low power mode, it does not have the functionality to detect them when SoC is active. skip_wake_irqs differentiates this behaviour. Thanks, Sneh