From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 034973C5DA8 for ; Thu, 12 Mar 2026 15:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773329091; cv=none; b=cHaLHuio3evUmfL6CesFReXsfW4pi1BUGMjvY7ZC41Zuok1y/Ew68W+CeAsx2zwQ6AXOYCT/uhuneP0NEEBjJLjJY/rz8AOS7qLp/D49Hw4nVWh/UBk1T2q8Fei3/xsv0j3QT9kJuCWHujMOnffcwzJYigQxoK8JnVYrOeyaopI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773329091; c=relaxed/simple; bh=gAhoZZtaU0dLQM0X7vjE0h9pHAa9S+Tp5bClV1KsDUU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=iHgSZVAOgSXf/dHRgNaXXQHDMsmDC2o1Acl/Y5NxDiEqyO0RxSZUi+oZebizGCBngHWPiTVOLbmTEbErBIE21mmCYtnakHWHSUulJCIaH7HTsR2mPKrdgsMfDIkGePTmi3kNs3N6+KSGUwIFlOgIU+r87yeXkOZJXwf+wAShSOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w0htl-0004bz-BF; Thu, 12 Mar 2026 16:24:29 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w0htj-0052iJ-0c; Thu, 12 Mar 2026 16:24:28 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1w0htk-00000000Cdx-1r4T; Thu, 12 Mar 2026 16:24:28 +0100 Message-ID: <37f389274e5c0e33c0e8fad8ffed0237b0127b07.camel@pengutronix.de> Subject: Re: [PATCH v8 4/5] reset: rzv2h-usb2phy: Keep PHY clock enabled for entire device lifetime From: Philipp Zabel To: Tommaso Merciai , tomm.merciai@gmail.com, peda@axentia.se Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Fabrizio Castro , Lad Prabhakar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Ulf Hansson , Greg Kroah-Hartman , Josua Mayer , Arnd Bergmann , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Thu, 12 Mar 2026 16:24:28 +0100 In-Reply-To: <6584aed8dc4fddb28c2184c83b92b4f3b419bc31.1773319566.git.tommaso.merciai.xr@bp.renesas.com> References: <6584aed8dc4fddb28c2184c83b92b4f3b419bc31.1773319566.git.tommaso.merciai.xr@bp.renesas.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Do, 2026-03-12 at 15:50 +0100, Tommaso Merciai wrote: > The driver was disabling the USB2 PHY clock immediately after register > initialization in probe() and after each reset operation. This left the > PHY unclocked even though it must remain active for USB functionality. >=20 > The behavior appeared to work only when another driver > (e.g., USB controller) had already enabled the clock, making operation > unreliable and hardware-dependent. In configurations where this driver > is the sole clock user, USB functionality would fail. >=20 > Fix this by: > - Enabling the clock once in probe() via pm_runtime_resume_and_get() > - Removing all pm_runtime_put() calls from assert/deassert/status > - Registering a devm cleanup action to release the clock at removal > - Removed rzv2h_usbphy_assert_helper() and its call in > rzv2h_usb2phy_reset_probe() >=20 > This ensures the PHY clock remains enabled for the entire device lifetime= , > preventing instability and aligning with hardware requirements. >=20 > Cc: stable@vger.kernel.org > Fixes: e3911d7f865b ("reset: Add USB2PHY port reset driver for Renesas RZ= /V2H(P)") > Signed-off-by: Tommaso Merciai Given the Cc: stable tag I assume I can apply this first, independently of the other patches? Reviewed-by: Philipp Zabel regards Philipp