From: Changhuang Liang <changhuang.liang@starfivetech.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Jack Zhu <jack.zhu@starfivetech.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: <linux-media@vger.kernel.org>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: media: VIDEO_STARFIVE_CAMSS should depend on ARCH_STARFIVE
Date: Wed, 29 Nov 2023 15:41:11 +0800 [thread overview]
Message-ID: <37f9de03-f058-46db-8c1b-e14239e42b3a@starfivetech.com> (raw)
In-Reply-To: <81476f48f7774fdd62e95458b160688952bb0068.1701196160.git.geert+renesas@glider.be>
On 2023/11/29 2:31, Geert Uytterhoeven wrote:
> The StarFive Camera Subsystem is only present on the StarFive JH7110
> SoC. Hence add a dependency on ARCH_STARFIVE, to prevent asking the
> user about this driver when configuring a kernel without StarFive SoC
> support.
>
> Fixes: bba185d141b12787 ("media: staging: media: starfive: camss: Add core driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
> drivers/staging/media/starfive/camss/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/starfive/camss/Kconfig b/drivers/staging/media/starfive/camss/Kconfig
> index bd184f42c98fa853..9ea5708fe40955e2 100644
> --- a/drivers/staging/media/starfive/camss/Kconfig
> +++ b/drivers/staging/media/starfive/camss/Kconfig
> @@ -5,6 +5,7 @@ config VIDEO_STARFIVE_CAMSS
> depends on VIDEO_DEV && OF
> depends on HAS_DMA
> depends on PM
> + depends on ARCH_STARFIVE || COMPILE_TEST
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> select VIDEOBUF2_DMA_CONTIG
prev parent reply other threads:[~2023-11-29 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 18:31 Geert Uytterhoeven
2023-11-29 7:41 ` Changhuang Liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37f9de03-f058-46db-8c1b-e14239e42b3a@starfivetech.com \
--to=changhuang.liang@starfivetech.com \
--cc=bryan.odonoghue@linaro.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jack.zhu@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®