mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Ray Liu <ray.liu@airoha.com>, Mark Brown <broonie@kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: airoha: Explicitly prevent continuous reads
Date: Wed, 18 Nov 2026 21:37:21 +0300	[thread overview]
Message-ID: <37fc133b-a5f3-4b4d-ba2a-002239bbcebc@iopsys.eu> (raw)
In-Reply-To: <20261118-winbond-upstreaming-airoha-cont-read-v1-1-acc0b6410868@bootlin.com>

Hello Miquel,

I think the patch is bad for the following reasons:
* As I know there is no CS issue with Airoha controller. It works properly.
* Airoha controller supports large reads (but only in PIO  mode). Thus
  continuous reading may work properly. Unfortunately PIO reading several
  times slower than DMA reading.
* DMA reading is much faster, but can't be used for continuous reading.
  Maximum transfer size is 8191 bytes.

Thus for new Airoha controllers (en7523, an7581 and newer) it's better do
not use continuous reading and read pages using DMA. Old controllers (like
en7512) does not support DMA, so they can benefit from continuous mode
reading.

On 11/18/26 16:59, Miquel Raynal wrote:
> The SPI NAND core currently treats the lack of "large reads" as an
> indication that continuous reads might not be properly supported, but
> this is fragile and might evolve. The real problem with the Airoha
> controller is that it lacks full control over its CS, which may be
> spuriously deasserted. We now have a flag for this, so set it and make
> it clear that this controller is not suitable for continuous reading, at
> least with chips processing a CS deassertion as an end of read
> condition.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  drivers/spi/spi-airoha-snfi.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c
> index 95bfde7c8e7f..1070d4697fcb 100644
> --- a/drivers/spi/spi-airoha-snfi.c
> +++ b/drivers/spi/spi-airoha-snfi.c
> @@ -1018,6 +1018,10 @@ static const struct spi_controller_mem_ops airoha_snand_nodma_mem_ops = {
>  	.exec_op = airoha_snand_exec_op,
>  };
>  
> +static const struct spi_controller_mem_caps airoha_snand_mem_caps = {
> +	.no_cs_assertion = true,
> +};
> +
>  static int airoha_snand_setup(struct spi_device *spi)
>  {
>  	struct airoha_snand_ctrl *as_ctrl;
> @@ -1121,6 +1125,7 @@ static int airoha_snand_probe(struct platform_device *pdev)
>  	ctrl->num_chipselect = 2;
>  	ctrl->mem_ops = dma_enable ? &airoha_snand_mem_ops
>  				   : &airoha_snand_nodma_mem_ops;
> +	ctrl->mem_caps = &airoha_snand_mem_caps;
>  	ctrl->bits_per_word_mask = SPI_BPW_MASK(8);
>  	ctrl->mode_bits = SPI_RX_DUAL;
>  	ctrl->setup = airoha_snand_setup;
>
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20261118-winbond-upstreaming-airoha-cont-read-1332872b972c
>
> Best regards,

      reply	other threads:[~2026-11-18 18:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:59 Miquel Raynal
2026-11-18 18:37 ` Mikhail Kshevetskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37fc133b-a5f3-4b4d-ba2a-002239bbcebc@iopsys.eu \
    --to=mikhail.kshevetskiy@iopsys.eu \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=ray.liu@airoha.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®