From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Nick Desaulniers <nick.desaulniers@gmail.com>,
Juergen Gross <jgross@suse.com>
Cc: ghackmann@google.com, mka@google.com, kees@google.com,
srhines@google.com, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: xen: remove the use of VLAIS
Date: Mon, 8 Jan 2018 10:54:24 -0500 [thread overview]
Message-ID: <37fc26d2-734a-4690-d4f2-6d0df82015a4@oracle.com> (raw)
In-Reply-To: <1515274788-24548-1-git-send-email-nick.desaulniers@gmail.com>
On 01/06/2018 04:39 PM, Nick Desaulniers wrote:
> Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and
> frowned upon by others.
>
> https://lkml.org/lkml/2013/9/23/500
>
> Here, the VLAIS was used because the size of the bitmap returned from
> xen_mc_entry() depended on possibly (based on kernel configuration)
> runtime sized data. Rather than declaring args as a VLAIS then calling
> sizeof on *args, we calculate the appropriate sizeof args manually.
> Further, we can get rid of the #ifdef's and rely on num_possible_cpus()
> (thanks to a helpful checkpatch warning from an earlier version of this
> patch).
>
> Suggested-by: Juergen Gross <jgross@suse.com>
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
Applied to for-linus-4.15.
-boris
next prev parent reply other threads:[~2018-01-08 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-24 18:02 [PATCH] " Nick Desaulniers
2018-01-02 8:18 ` Juergen Gross
2018-01-06 21:39 ` [PATCH v2] " Nick Desaulniers
2018-01-08 6:54 ` Juergen Gross
2018-01-08 15:54 ` Boris Ostrovsky [this message]
2018-01-08 16:10 ` Peter Zijlstra
2018-01-08 16:20 ` Boris Ostrovsky
2018-01-08 16:28 ` Juergen Gross
2018-01-08 16:35 ` [Xen-devel] " Boris Ostrovsky
2018-01-08 16:26 ` Juergen Gross
2018-01-08 18:49 ` Ingo Molnar
2018-01-09 5:35 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37fc26d2-734a-4690-d4f2-6d0df82015a4@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=ghackmann@google.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kees@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mka@google.com \
--cc=nick.desaulniers@gmail.com \
--cc=srhines@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®