From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B9813B2FF9 for ; Mon, 14 Sep 2026 06:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789365783; cv=none; b=ZMHeR9FzfkGVH6XS2KIKFxAqdtz3y9/b5eAAJzU91RfojfgXzL+6453xqjmTJU8drlU+P2urskUyP7l7JiB9moKT5K0Bg2ycjIiCMXnkFZg15ghRAeUrmMk1q0RYKgweuzLshNf6mRHETKhem9Fz7DHy8CFsTipqW46CPR5JA0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789365783; c=relaxed/simple; bh=Gv7lORaDNCNghahgjKYq5FlxBpKPlgY3TJoQDAGQytg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ci40nw8YwdWsaWPgHP7zapPivY5okJMnTqY0KsXvjIEYDWgWZAlX9jMNJarRdOMUS9PMxXYqioQM3K2aKjMg4lmeDh6fLaGT+7AIH0YKWL0cIDG9QouwUfDOAnKCIHZi4jwY6988/fdyqMkTgvoqeMAb571fKA5+On57LkVWHXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Qq10oqsP; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=n/sM3TBx; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qq10oqsP"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="n/sM3TBx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789365778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pqstWO1ZgVHH8TktNFCBcMfA6S7qInTZbOl2DmKbnYU=; b=Qq10oqsP3MV4jHwYiXRxqDokyQvZInyAGMr3RPAYzNXL2qp2qI8gDQ3n3dk0hNmiKXOjgj dy8s8ipeYOJs94wWhnqExfjgfRxj0bjJwh1ji7vpE9xdahfRL+UOv2j+jBCAD3ggWh5bOD xYtu6Hz+KfD5OF6n2razITMM54aTEsc= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-428-QimVAHgZOFS8F1tYU6xIYA-1; Mon, 14 Sep 2026 02:02:57 -0400 X-MC-Unique: QimVAHgZOFS8F1tYU6xIYA-1 X-Mimecast-MFC-AGG-ID: QimVAHgZOFS8F1tYU6xIYA_1789365776 Received: by mail-oo1-f70.google.com with SMTP id 006d021491bc7-6c153bab4c3so2656070eaf.0 for ; Sun, 13 Sep 2026 23:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1789365776; x=1789970576; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pqstWO1ZgVHH8TktNFCBcMfA6S7qInTZbOl2DmKbnYU=; b=n/sM3TBxn/n8f4by77c5V5AElTog9dUDPL3WH4dpbVzMQzwdXlLkK3OzMaqusOIpL1 6sbeSfHyBPtogZE1l+mginjBuga86IBuMYi6DeslXZ1Ju73LATZs+gvHx7sxW8KTPe4W ZVypHgSzEwA7oNR6ZSdLaNiVyRLhUjnPSeh3oJ2NXEWHZgEurNXCOK3dZgRagH0pBvDp 2H4y7ifJwH1OrWqc/WInmKPMek9NUFD+YuqgQ6ywMcZjVrB4Skv4iccvEsxputY/qbQT KaWhct6i4mGG8xR2iwAiCN9hNcqQtiix1l81tMszyMPU/wLB/TJ8Q4oWY5+Jz7EMCVD7 AqTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789365776; x=1789970576; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pqstWO1ZgVHH8TktNFCBcMfA6S7qInTZbOl2DmKbnYU=; b=gWi8iHZjWo4S1UNEaOnX+AxEC3FJH+yVan9hPZIlPkux8QhtmehP1NKC0uLUA3tnbB nuz9b1GuFdjHFcgY4y35Bf8CdijyOLMwTRpoGRQ3E24ZBiXT8Dt/VqT2Lb4dQgH4iqVx KKAWg0Vh4GOHWcUp1Fd3YesYR73ZEt+5nfj7h02tfZUYdMFCy152ZbGt+vyivxO5fU9k eorRPclafcqct3/ZRt04Qkqz5rx+CY92D+X375X0eF5nIWHhvEpkuw9imJV2p6CL9vCx X5u5maRPMze6eV+bdM8Uh6pMG6vIzhFYYQc47EOv2UeTRiIW6VtUpFJ3cXbNoQGmFilK /Y8w== X-Forwarded-Encrypted: i=1; AKwUvBzJ05xZdInlPbRaMbenxrUddj+rAqw3eO2M1/1udjmoz4+72tlvL77FyXIqS2TCCrfDyxXV0X+L9Hlrxaw=@vger.kernel.org X-Gm-Message-State: AFuF++nb7ZRsVVO9pbuLN04HDUkP9Z5hwqGtcqdBQhtp/Ra9lkdzC21B 0BCSv+q5/u65l/f/B+bucw4atIgoGBusOYslQxbJXew2ppnessJyhXFxNii5ytrX1cqn7tzinIA Ch+wJG0qwK2pHhGzq/yYsuqEMXu+RLpKNP/d/gZ4B3XoB0fCbP3Ht1j0MrlC8fc/m1A== X-Gm-Gg: AYBFou1fFhpubz0tl/u5araUCGF2X+O7HAS0CBWf1Y/tTvgZsluaSGrcE5qB4cl0MrK kOgwTmYkVWtVGg7/mGotDntKI+GbnpWrvGbtpGUAJXZZN1HVvlEeV/b4ycpADDNBLwCKfSo7bgC UHC76F69kDoga6ahUptBKR1SSbvUcRz93ynykHeAvaXb63YtuNqvnX1Lprc7hf22O5vnuZY1H6W k2YSbiC6LAiL4eFEyvdWUY809jS14GyYzejXCd+njY7DsGhP6oya7xHOvJrq8FddQ1fdpKSHoa6 QdkwPQwlgmEubOYuiGrYk/lqXZLQAOWP1ihZY2VdkqL62Qc/R6IpEad5qGYsgB6tpp0D7rRQvYH 0wuNWCnLzNcwZxqjhL9pRSu840pxcIP5tJj9EYXqg1Q== X-Received: by 2002:a05:6820:985:b0:6b7:46fc:1e6 with SMTP id 006d021491bc7-6c542f1e27bmr483602eaf.69.1789365776269; Sun, 13 Sep 2026 23:02:56 -0700 (PDT) X-Received: by 2002:a05:6820:985:b0:6b7:46fc:1e6 with SMTP id 006d021491bc7-6c542f1e27bmr483565eaf.69.1789365775779; Sun, 13 Sep 2026 23:02:55 -0700 (PDT) Received: from [192.168.68.52] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-143659a9a06sm23239081c88.0.2026.09.13.23.02.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Sep 2026 23:02:55 -0700 (PDT) Message-ID: <37ff6cc7-9a72-41df-a473-b45803ad5239@redhat.com> Date: Mon, 14 Sep 2026 16:02:46 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/3] arm_mpam: resctrl: Add pass-through resctrl_arch_preconvert_bw() To: Ben Horgan Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, corbet@lwn.net, x86@kernel.org, linux-doc@vger.kernel.org, dave.martin@arm.com References: <20260911163613.1131447-1-ben.horgan@arm.com> <20260911163613.1131447-3-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260911163613.1131447-3-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/12/26 2:36 AM, Ben Horgan wrote: > resctrl rounds up the percentage value of the MBA based on the bw_gran. As > MPAM uses a binary fixed point fraction format for MBA rather than a > decimal percentage, this introduces rounding errors. > > Without this additional rounding, if the user reads the value in an MB > schema and then writes it back to the schema, the value in hardware won't > change. However, with this additional rounding, this guarantee is broken > for systems with mbw_wd < 7. > > resctrl is introducing resctrl_arch_preconvert_bw() to allow the arch code > to specify the conversion resctrl does to the user-provided bandwidth > value. Add the MPAM version of resctrl_arch_preconvert_bw(). This does no > conversion. > > Signed-off-by: Ben Horgan > Reviewed-by: Reinette Chatre > --- > Changes since v3: > Parameter order switch (Reinette) > Add Reinette's R-b > > Changes since v4: > Add missing tearoff divider, --- > --- > drivers/resctrl/mpam_resctrl.c | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Gavin Shan