From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Korsgaard <peter@korsgaard.com>,
Guenter Roeck <linux@roeck-us.net>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property
Date: Fri, 3 Jan 2025 10:35:27 +0100 [thread overview]
Message-ID: <3803fad5-0dab-491c-b2bf-47ab888bb1a2@kernel.org> (raw)
In-Reply-To: <25a1b5bd-437c-4136-84d4-e1eab264d062@korsgaard.com>
On 03/01/2025 10:01, Peter Korsgaard wrote:
>
> Looking at lore, v1 used target-pwm which Gunter suggested I changed to
> default-rpm while explaining that it cannot be a generic property:
>
> https://lore.kernel.org/linux-devicetree/b717da30-1d4c-4e09-b98c-4aa41a235234@roeck-us.net/
>
> Which I then did as a v2, that then didn't get any additional feedback:
>
> https://lore.kernel.org/linux-devicetree/3aa21a01-c994-4b36-8893-181e55a60c5e@korsgaard.com/
>
> So if we agree on default-pwm, then I can send an update (a v4!) with
> the typo in the example fixed, OK?
Yes and we go back to my first comment about commit msg:
"Also mention here shortly how Rob's comment is addressed."
e.g. we cannot use default/target-rpm because of foo bar.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-03 9:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 17:50 Peter Korsgaard
2025-01-02 17:50 ` [PATCH 2/2] hwmon: (pwm-fan): Make default PWM duty cycle configurable Peter Korsgaard
2025-01-02 18:22 ` [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property Krzysztof Kozlowski
2025-01-03 7:59 ` Peter Korsgaard
2025-01-03 8:10 ` Krzysztof Kozlowski
2025-01-03 9:01 ` Peter Korsgaard
2025-01-03 9:35 ` Krzysztof Kozlowski [this message]
2025-01-03 9:42 ` Peter Korsgaard
2025-01-02 19:24 ` Rob Herring (Arm)
2025-01-03 9:16 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3803fad5-0dab-491c-b2bf-47ab888bb1a2@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peter@korsgaard.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®