From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752826AbbC3LHl (ORCPT ); Mon, 30 Mar 2015 07:07:41 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:18296 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659AbbC3LHi (ORCPT ); Mon, 30 Mar 2015 07:07:38 -0400 X-AuditID: cbfee68f-f791c6d000004834-b5-55192e78cbdd Date: Mon, 30 Mar 2015 11:07:36 +0000 (GMT) From: Maninder Singh Subject: restart_syscall: use freezable blocking call To: tglx@linutronix.de, "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" Cc: Yogesh Narayan Gaur , AJEET YADAV Reply-to: maninder1.s@samsung.com MIME-version: 1.0 X-MTR: 20150330110158914@maninder1.s Msgkey: 20150330110158914@maninder1.s X-EPLocale: en_US.windows-1252 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150330105247482@maninder1.s X-ParentMTR: 20150330105247482@maninder1.s X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=windows-1252 MIME-version: 1.0 Message-id: <380509604.92081427713655432.JavaMail.weblogic@epmlwas01c> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsWyRsSkSrdCTzLU4OVTVYvLu+awOTB6fN4k F8AYxWWTkpqTWZZapG+XwJXx8vFu5oI+mYpDu+UaGNdIdzFycggJqEks2vuYrYuRg0NCwETi /gwBkLCEgJjEhXvrgcJcQCVLGSV2/9jIDJEwkdjS2sAOkZjDKDH98W+wBIuAqsSi9SAJTg42 AX2Js3vXgcWFBUwlrvyawwrSICIwnVGia+V5JpAEs0CYxJaJ81ggrlCUWH/jCSOIzSsgKHFy 5hMWiG0qEnt/bIKKq0o83X4d6go5iSVTLzNB2LwSM9qfssDEp31dA1UjLXF+1gZGmHcWf38M FeeXOHZ7B1SvgMTUMwehajQlJn3byQgJCW2Jvl/lMOW7Ti1nhll1f8tcqFYJia0tT1ghXlGU mNL9kB3CNpA4smgOK7pXeAXcJNatWg8OOAmBXg6JLXNmsE5gVJqFpG4WklmzkMxCVrOAkWUV o2hqQXJBcVJ6kbFecWJucWleul5yfu4mRmBiOP3vWf8OxrsHrA8xCnAwKvHwOtRLhAqxJpYV V+YeYjQFxtNEZinR5Hxg+skriTc0NjOyMDUxNTYytzRTEuddKPUzWEggPbEkNTs1tSC1KL6o NCe1+BAjEwenVANjfBPzlp4I1VtC8+MfbQptNsu6FOBbsSq+/uak8Dc/r0udcmXffLuzPWLy ox+SE8W/czJ9f5k5tzz50qoAs6mLjuZsfzf9oelm8+xoLTuPjc5r3q73vLyhLKnZ1a06+UbC tn0uN78ZGryu3JD8a3f8Yv3J06ctuj3fTaZm2TVfM59pxW/UBBxXKrEUZyQaajEXFScCAPs0 4eYHAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGKsWRmVeSWpSXmKPExsVy+t/tXt0KPclQg0/L5Cwu75rD5sDo8XmT XABjVJpNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBQ JYWyxJxSoFBAYnGxkr6dTVF+aUmqQkZ+cYmtUrShuZGekYGeqZGeoWmslaGBgZEpUE1CWsbL x7uZC/pkKg7tlmtgXCPdxcjJISSgJrFo72M2EFtCwERiS2sDO4QtJnHh3nqgOBdQzRxGiemP fzODJFgEVCUWrYcoYhPQlzi7dx1YXFjAVOLKrzmsIA0iAtMZJbpWnmcCSTALhElsmTiPBWKb osT6G08YQWxeAUGJkzOfsEBsU5HY+2MTVFxV4un268wQcTmJJVMvM0HYvBIz2p+ywMSnfV0D VSMtcX7WBkaYqxd/fwwV55c4dnsHVK+AxNQzB6FqNCUmfdsJZHMA2doSfb/KYcp3nVrODLPq /pa5UK0SEltbnrBCvKIoMaX7ITuEbSBxZNEcVnSv8Aq4SaxbtZ59AqPsLCSpWUjaZyFpR1az gJFlFaNoakFyQXFSeoWhXnFibnFpXrpecn7uJkZwGnq2cAfjl/PWhxgFOBiVeHgd6iVChVgT y4orcw8xSnAwK4nw9qpLhgrxpiRWVqUW5ccXleakFh9iNAXG2kRmKdHkfGCKzCuJNzQ2MTc1 NrUwMDQ3N1MS5/1/LjdESCA9sSQ1OzW1ILUIpo+Jg1OqgXEXU6Vr+/YPq/UiQg8aOK76rG9y a/uuw9IzKpzSZrp9uxcQMOXYDmXPiWcWRfg4b3Pg3SSZ9+XztkeudpsLjgcs4TyXO1Ps+JPv 0jdOP5QOOTv9+HzBxtvKgXmCHpKc304/Vvsv/eXs495O5ZvSh3WWVBTzSUQfjExY3xuW6Z2o 13TW9d7X5DlKLMUZiYZazEXFiQBXSU2WWQMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t2UB7kwk017871 Hello All, Avoid waking up every thread sleeping in a restart_syscall call during suspend and resume by calling a freezable blocking call. Previous patches modified the freezer to avoid sending wakeups to threads that are blocked in freezable blocking calls. Ref: https://lkml.org/lkml/2013/5/1/424 We have faced similiar issue of sleep fail when calling restart() system call in stress testing. Patch :- Subject: restart_syscall: use freezable blocking call Avoid waking up every thread sleeping in a restart_syscall call during suspend and resume by calling a freezable blocking call. Previous patches modified the freezer to avoid sending wakeups to threads that are blocked in freezable blocking calls. Ref: https://lkml.org/lkml/2013/5/1/424 Backtrace: [] (__schedule+0x0/0x5d8) from [] (schedule+0x8c/0x90) [] (schedule+0x0/0x90) from [] (schedule_hrtimeout_range_clock+0xdc/0x110) [] (schedule_hrtimeout_range_clock+0x0/0x110) from [] (schedule_hrtimeout_range+0x1c/0x20) r9:d16c9be0 r8:8b7d9c2c r7:00000000 r6:00000000 r5:d16c8028 [] (schedule_hrtimeout_range+0x0/0x20) from [] (poll_schedule_timeout+0x48/0x6c) [] (poll_schedule_timeout+0x0/0x6c) from [] (do_sys_poll+0x2c8/0x378) r5:d16c9f78 r4:00000000 [] (do_sys_poll+0x0/0x378) from [] (do_restart_poll+0x40/0x5c) [] (do_restart_poll+0x0/0x5c) from [] (sys_restart_syscall+0x2c/0x30) r4:fffffe7a [] (sys_restart_syscall+0x0/0x30) from [] (ret_fast_syscall+0x0/0x48) esTask03 R running 0 270 204 0x00000001 Signed-off-by: Yogesh Gaur samsung.com> Signed-off-by: Amit Arora samsung.com> Reviewed-by : Ajeet Yadav samsung.com> --- kernel/time/hrtimer.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c index 37e50aa..75ebc3f 100644 --- a/kernel/time/hrtimer.c +++ b/kernel/time/hrtimer.c @@ -1775,7 +1775,7 @@ schedule_hrtimeout_range_clock(ktime_t *expires, unsigned long delta, * A NULL parameter means "infinite" */ if (!expires) { - schedule(); + freezable_schedule(); return -EINTR; } @@ -1789,7 +1789,7 @@ schedule_hrtimeout_range_clock(ktime_t *expires, unsigned long delta, t.task = NULL; if (likely(t.task)) - schedule(); + freezable_schedule(); hrtimer_cancel(&t.timer); destroy_hrtimer_on_stack(&t.timer); -- 1.7.1 Thanks and Regards, Maninder Singh{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I