From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, admiyo@os.amperecomputing.com,
Sudeep Holla <sudeep.holla@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Robert Moore <robert.moore@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH net-next v22 1/2] mailbox/pcc: support mailbox management of the shared buffer
Date: Mon, 14 Jul 2025 22:37:44 +0300 [thread overview]
Message-ID: <3806fc87-e574-46cf-98af-158c37f640e0@suswa.mountain> (raw)
In-Reply-To: <20250710191209.737167-2-admiyo@os.amperecomputing.com>
Hi,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/admiyo-os-amperecomputing-com/mailbox-pcc-support-mailbox-management-of-the-shared-buffer/20250711-031525
base: net-next/main
patch link: https://lore.kernel.org/r/20250710191209.737167-2-admiyo%40os.amperecomputing.com
patch subject: [PATCH net-next v22 1/2] mailbox/pcc: support mailbox management of the shared buffer
config: x86_64-randconfig-161-20250711 (https://download.01.org/0day-ci/archive/20250712/202507120609.Myazax08-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202507120609.Myazax08-lkp@intel.com/
smatch warnings:
drivers/mailbox/pcc.c:498 pcc_send_data() error: uninitialized symbol 'ret'.
vim +/ret +498 drivers/mailbox/pcc.c
86c22f8c9a3b71 Ashwin Chaugule 2014-11-12 490 static int pcc_send_data(struct mbox_chan *chan, void *data)
86c22f8c9a3b71 Ashwin Chaugule 2014-11-12 491 {
c45ded7e11352d Sudeep Holla 2021-09-17 492 int ret;
bf18123e78f4d1 Sudeep Holla 2021-09-17 493 struct pcc_chan_info *pchan = chan->con_priv;
e332edef98ddac Adam Young 2025-07-10 494 struct acpi_pcct_ext_pcc_shared_memory __iomem *pcc_hdr;
e332edef98ddac Adam Young 2025-07-10 495
e332edef98ddac Adam Young 2025-07-10 496 if (pchan->chan.rx_alloc)
e332edef98ddac Adam Young 2025-07-10 497 ret = pcc_write_to_buffer(chan, data);
Hi Adam! :)
ret is uninitialized on the else path.
e332edef98ddac Adam Young 2025-07-10 @498 if (ret)
e332edef98ddac Adam Young 2025-07-10 499 return ret;
8b0f57889843af Prakash, Prashanth 2016-02-17 500
c45ded7e11352d Sudeep Holla 2021-09-17 501 ret = pcc_chan_reg_read_modify_write(&pchan->cmd_update);
c45ded7e11352d Sudeep Holla 2021-09-17 502 if (ret)
c45ded7e11352d Sudeep Holla 2021-09-17 503 return ret;
c45ded7e11352d Sudeep Holla 2021-09-17 504
e332edef98ddac Adam Young 2025-07-10 505 pcc_hdr = pchan->chan.shmem;
e332edef98ddac Adam Young 2025-07-10 506 if (ioread32(&pcc_hdr->flags) & PCC_CMD_COMPLETION_NOTIFY)
e332edef98ddac Adam Young 2025-07-10 507 pchan->chan.irq_ack = true;
e332edef98ddac Adam Young 2025-07-10 508
3db174e478cb0b Huisong Li 2023-08-01 509 ret = pcc_chan_reg_read_modify_write(&pchan->db);
e332edef98ddac Adam Young 2025-07-10 510
3db174e478cb0b Huisong Li 2023-08-01 511 if (!ret && pchan->plat_irq > 0)
3db174e478cb0b Huisong Li 2023-08-01 512 pchan->chan_in_use = true;
3db174e478cb0b Huisong Li 2023-08-01 513
3db174e478cb0b Huisong Li 2023-08-01 514 return ret;
86c22f8c9a3b71 Ashwin Chaugule 2014-11-12 515 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-07-14 19:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 19:12 [PATCH net-next v22 0/2] MCTP Over PCC Transport admiyo
2025-07-10 19:12 ` [PATCH net-next v22 1/2] mailbox/pcc: support mailbox management of the shared buffer admiyo
2025-07-11 6:51 ` kernel test robot
2025-07-14 19:37 ` Dan Carpenter [this message]
2025-07-14 23:02 ` Adam Young
2025-07-10 19:12 ` [PATCH net-next v22 2/2] mctp pcc: Implement MCTP over PCC Transport admiyo
2025-07-11 11:02 ` kernel test robot
2025-07-11 12:52 ` Jeremy Kerr
2025-07-11 20:03 ` Adam Young
2025-07-14 8:21 ` Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3806fc87-e574-46cf-98af-158c37f640e0@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=admiyo@os.amperecomputing.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jassisinghbrar@gmail.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®