From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753615AbbKWQ6M (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Nov 2015 11:58:12 -0500
Received: from mout.kundenserver.de ([212.227.17.24]:50807 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750972AbbKWQ6J (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Nov 2015 11:58:09 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Pali =?ISO-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>,
        Sebastian Reichel <sre@kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Andreas Dannenberg <dannenberg@ti.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module
Date: Mon, 23 Nov 2015 17:57:28 +0100
Message-ID: <3809374.hKy9fQ2ldj@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1448297631-8916-1-git-send-email-afd@ti.com>
References: <1448297631-8916-1-git-send-email-afd@ti.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:+RVx5xt4NsBS7bE3h+N9pnuAwIKOgKAN76qksJuW23ZntnQSItw
 oMRJTJWu3jEoZvotJ6nPEQ/kKv5oZb1L/2nU+iLa0QZOQV8uPeZIiQ+7WRyRId3oHfP/69X
 CDXhVN10Z+T7QFaz1g+NO5dUYmowWLq3e4axqWkAusV/Jn+cHd1PY53dz0+jqoiFzc6e86W
 A5FjiYJwmpgcn8dFI+eKw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:uRtTeg00Kys=:YAt7k9e39z7D2hytFNnJHq
 aQFeXcN5sGRRse+mHCC3SD7CapDtrp5PmQqoEJObAvdqBsg3jVKN9ndii+knM4VkeGf1ZoCWr
 TrkJh7JDS5nL+rHFCwt6iMbll0TSLolJA0MHeP32HhF4QoVeN6IPGgnfcDLvPWJ9v+iI8L9Wc
 zfFYsFCYZVu0SRQ1T2Ov6Y7sOtSco1IY0L3sIOm3aFDKN5UYvS3WOGXEAI6QDwZ/+NV+RRdmA
 oVculNad7BVtkYtOnnyEQ3C2iC06kEGFWve3GhLV995jHSN7FVBDZ9yJgAmb6DHL1cuZnKI1B
 KyahX2pmZ4UG22GCY+M8KaItl3wltwldlNN9ybGKutiwNiWYuPifKcivu8ThHAJ6KG+z06tJe
 Tw7JKHkWuh4K9JVRqvdFeykujXqUQM2G66A/OKe5RSKn8o29h2XWEnDo7p3NJ1zHN9ovyPbd3
 DN9IIt72fa0F43bHPGhXqjXxjrBDAYo/Beu9k/nRKNN2ReR09yGFdSqaboPQxfS2Zw6uazX9j
 zFhEA4fbmSxUtUSYHxmP66/IWjWKkJPdufwXe5DCT1udyHD/EjvBSvxYeFwqeVmm+edr3YWnU
 mR06UwL2p2U/NPeYKU2+BvlMu1sPL6kXknjkRj9478MMdCbJ8Ca/dGD10l+fvDCI5KMwzwheu
 dlxjZ94+S9uTqQNHKUBfg1yfumBsAV6BcT80KKIzyFtCzTkq0WzCTcfbENgyagsyK6iDhGP9d
 R1cikjC+Q7T0tgOu
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote:
> Separate out I2C functionality into a module. This fixes several small
> issues and simplifies the driver initialization.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>

That looks good to me overall, it should help with the randconfig
warnings I've been seeing and makes the driver structured more logically.

The one part I wonder about is whether the platform_driver portion
should also be split out into a separate module in the same way.

	Arnd