From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A521C47D92E for ; Wed, 22 Jul 2026 09:50:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784713851; cv=none; b=WbOVLUSAutVpjWq4PBIUhIqjO4skIPBIeaIdbFdjIliciAYKGr88R3c50KDwES2ZIDu+T31UCVvtvNKfnr9RbCJk8xWMfXfwWiKYhlH0448nj69dusJIe236w2hOuiocaqpKEZZYnlkCKeWf8xLsY8v/LMutlW3gcz6BTv1vxBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784713851; c=relaxed/simple; bh=zr58osoMX0jqB7Ny+PyJro8uAgdhkpoQJr5hOMzDFy0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aLmXPtFRjlO9aEF0IsXCnQUNF8J2GhnJx+vzu6wFv6pJTqcmKdcxgw9EkaelU/JD6OcNJj76Ooq9jWiHM0Zx9L/UbJ9BlRDn+38v5E/P/LR6zd2BJfP0gMafkvx1scLZCPaUrXH6V6ww4EBRFOvvMUlBErbg8Pd2jgTmUNNT9Qs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T+yPaN4x; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EvcXTpt8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T+yPaN4x"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EvcXTpt8" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M8x69I140605 for ; Wed, 22 Jul 2026 09:50:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=d2S3NyHe7JKxNxgaSFpKvPq/ rKGPVUbh4HkCUkp0pt4=; b=T+yPaN4xCigNC5oa/en9SmTdTOMoSifsGS8W2UkB S9UcGQ4BfvtI1dqU4J1vYhxtYjmkXBon6Wh8WsvDM6L8iiljaN41GLL9HJDejAUc QyphX2mpDQ2VAkhaTMUy3+JKTmWhb/RuIu6sPTuPX+30bFm8iL/ae5jztVsNsFHa Km9E+BDObU9X9c+Micf3Gc94VPX6hNALZToMRBhL4drApev1Osf64XVrTJQRezLt D0hBBjtQo3F0f2wZDL1zSGFSWXTsXU72Ghnr+b/46fzpJlbJcvO3xHn4cGCh2zPA tKE4idNRgv5yFu0tuwOvbB+XQo6M4bSppba9LGW9PDqYtg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjtn2r99v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 09:50:42 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cefa1a2be6so108143885ad.0 for ; Wed, 22 Jul 2026 02:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784713842; x=1785318642; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=d2S3NyHe7JKxNxgaSFpKvPq/rKGPVUbh4HkCUkp0pt4=; b=EvcXTpt8LhtN1KcEaLyWUHyrMGpFf57B6DVWgjejDjqsRtpKUfd/HeOb361PPGQ0Ko xNf6S3IyHYqDK3+koKYqUWP4NLukP8rQi5HGiGhXRNzOjW7Ssn+an1Ri+zwFGHUZZHoP kQsrkFe6nblIrBdGB0Gc/NWSR4fARHt1Rp4NVDNZY6m/ASLip9eUwY9AiHiN1W5DdSkK SBuXL4W5iVeLtAAY32y4ACrjEdTec7GpssY+oaPiHCIA5CrlpKhRQvOxEJlqIBFjqOgT DixN/UKyGEzHQGrIBLk+EJ4pO++nLWe9zhPrT73o5oHicHqjBuGUxtISABplQ8kHJO0s 8lww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784713842; x=1785318642; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=d2S3NyHe7JKxNxgaSFpKvPq/rKGPVUbh4HkCUkp0pt4=; b=ABbrryh73/IQlWxRn3nNPwoG0ubQBXI3Yk/j9SNrxc4lSX+2ipYPpY9X+zhC+0NczN FOBy29AOs3Finic1KFhYyhErDuR1hLQfbrHusCxK5KfV5tT0oSwsZu6j34vAa0qrofdw Xi2B4nkkyfC/qBoil2Sf+l14S7kolxbd2PdrLwLyXH4kSttzLc/y/hpS4qacE1vK+z2K vSSXnI0hiaCiF5lUZ3ECJCeLddJjepK/WPPB0lv05t0B7FY1h/ffLJ5RmJEuArBPmkLj zq6TK/qVhdRYzjrlSNkkMlEDKqTWvYvGqQBlhjvB8CJLjQFXof5FFybnSWmaO/VsNbtH pRsw== X-Forwarded-Encrypted: i=1; AHgh+RpBcVB2EI5zTqg1wBxD3l+a6O4h/I5h+xgX9O722qzRhrp+VMMHz3yjbX1589i/D9sEP+ZVzpEYOCFt2wc=@vger.kernel.org X-Gm-Message-State: AOJu0YxWRr+C6NeKCKWT7qQS/VxdiXCc1XTAQmLSgBfTb8Cf4Pv5PjTp ryC6Tf3CE8c3bIUfIfKaGdwqPn10DKF7/fw6QKpV87YkHod0zl6uijFGIQg1rDkwBwsu5T3IsE7 Sn26yKJiRTIb40QEsO6eEjxdkZ52BGSmuvVaGAMuLeu8nD360LJWJOHYpUeFIeQzfhcM= X-Gm-Gg: AR+sD11nkExP7KgOFCmdIf4EF916tIkDXfNljWYzf0suv47v4iqnr92Rr4j1MZeKTaR EfUT8Ds/AVEs6yAEXkdyeQkOtj+n51davbYD3uEherX79IHnAkB7zXPUQn+NIPkjqu4xGdh5BDh J95MoJwqh928fQ4eckKalyza9TVwsRMim42oRabWDYttO0UWZ6Uq0j60EqKmF8IDYfSqeT1Axbc bgvdZ6nmNa94WxIm5nTDzNf++ohWnvLmzI4TPLMCI5zYp98qguVpxVbRK6505mv9kib+6ot/N4+ 42VMgsO5KS4TY0Mtk49Kng6w6nXO976D2vuQF9R5Et7xhlgBWDind91DqNxltrpfIfP/lipdmvP A6qxBs97m9KK/X9mMTDdibafnoj/C5ijBXQ== X-Received: by 2002:a17:903:15cf:b0:2ca:be8:62d with SMTP id d9443c01a7336-2cf349b5923mr232470695ad.32.1784713841750; Wed, 22 Jul 2026 02:50:41 -0700 (PDT) X-Received: by 2002:a17:903:15cf:b0:2ca:be8:62d with SMTP id d9443c01a7336-2cf349b5923mr232470145ad.32.1784713841271; Wed, 22 Jul 2026 02:50:41 -0700 (PDT) Received: from hu-pkondeti-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc8b0cdsm7758862eec.11.2026.07.22.02.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 02:50:40 -0700 (PDT) Date: Wed, 22 Jul 2026 15:20:28 +0530 From: Pavan Kondeti To: Shivendra Pratap Cc: Sebastian Reichel , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Ulf Hansson , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Souvik Chakravarty , Andy Yan , Matthias Brugger , John Stultz , Moritz Fischer , Bartosz Golaszewski , Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Greg Kroah-Hartman , Kathiravan Thirumoorthy , mfd@lists.linux.dev, Srinivas Kandagatla Subject: Re: [PATCH v23 02/13] power: reset: reboot-mode: Support up to 3 magic values per mode Message-ID: <38115586-9913-4d6e-9447-e82aee811dd1@quicinc.com> References: <20260714-arm-psci-system_reset2-vendor-reboots-v23-0-e7453c548c21@oss.qualcomm.com> <20260714-arm-psci-system_reset2-vendor-reboots-v23-2-e7453c548c21@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260714-arm-psci-system_reset2-vendor-reboots-v23-2-e7453c548c21@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDA5MyBTYWx0ZWRfX0AlbTbo8/PW7 wk/igan6fsuIYgElVBqdUiKomsxUzhqJT/BOtVhoJRI/23clQi/xq6XEbA3zLwb6KpJ1F4ACCGX tA4nAorXU0phKMr1ZaqAgwbDIBy9pHk2CeDOIgvWXz8O4SAiLjl1OSXDFuaUILkoVl+dJhQi0Nj l5GKwFMTFu4roq23Vfm+m24ACV09ndeHOJ/w5eLMB+yZoGYX9DWpVZVa15WbGZdS7WFNgjDhqoS 7klqAN+NQ/b9uEYWNK30ZXvTv67zw6AeSiIMvnHo6/E7E6TH0y2sq9rShgdAcx5R7gSwCJfPLQZ 8yZfSzdkh9argwnqfY0KTjAcpGAsLNRO4GklDnSZvdJqxctSb4kJ21Oo9Zsa4VaabOATws5MHAq Zb8e/dXnQy9/QQiZSgCzUVsLamHLPjjE9lP2b9c8B+8yuLQ0lLvU+kBFv1G4qBgRoeiT5mKkqaJ 7BXz02BvEJ3jIjST3Ow== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDA5MyBTYWx0ZWRfX5VtzJZjdzRGg 5Ci5IO67vM/vzScHmpGc8/MsbSVbFgFl1psWLFYftUp5kEMU/57uNIwidMKzKHpISDK56EMYCib SuPWXc8rykAxJhePkVpujz4YPtDVH+0= X-Proofpoint-GUID: R7AiHXQvbMBObfOGToMEh8CSardrkjpW X-Proofpoint-ORIG-GUID: R7AiHXQvbMBObfOGToMEh8CSardrkjpW X-Authority-Analysis: v=2.4 cv=T+28ifKQ c=1 sm=1 tr=0 ts=6a609272 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=2zDJ_gd8kjYVRJQFbS0A:9 a=CjuIK1q_8ugA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_03,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220093 On Tue, Jul 14, 2026 at 10:46:30PM +0530, Shivendra Pratap wrote: > ARM PSCI vendor-specific resets, require a 32-bit reset_type and a 64-bit > cookie as arguments. This cannot be implemented via the reboot-mode > framework, which supports a single 32-bit argument as magic value. > > Extend the reboot-mode framework to support up to three 32-bit arguments > as magic, per reboot-mode. > > Signed-off-by: Shivendra Pratap > --- > drivers/power/reset/nvmem-reboot-mode.c | 10 ++++---- > drivers/power/reset/qcom-pon.c | 8 ++++--- > drivers/power/reset/reboot-mode.c | 41 +++++++++++++++++++++----------- > drivers/power/reset/syscon-reboot-mode.c | 8 ++++--- > include/linux/reboot-mode.h | 4 +++- > 5 files changed, 46 insertions(+), 25 deletions(-) > > diff --git a/drivers/power/reset/nvmem-reboot-mode.c b/drivers/power/reset/nvmem-reboot-mode.c > index d260715fccf6..ac69b5f39fb4 100644 > --- a/drivers/power/reset/nvmem-reboot-mode.c > +++ b/drivers/power/reset/nvmem-reboot-mode.c > @@ -17,14 +17,16 @@ struct nvmem_reboot_mode { > struct nvmem_cell *cell; > }; > > -static int nvmem_reboot_mode_write(struct reboot_mode_driver *reboot, > - unsigned int magic) > +static int nvmem_reboot_mode_write(struct reboot_mode_driver *reboot, u32 *magic, int count) > { > struct nvmem_reboot_mode *nvmem_rbm; > size_t buf_len; > void *buf; > int ret; > > + if (count != 1) > + return -EINVAL; > + The count can be different per mode. Because `struct mode_info` has `count` member. This single `count` check across all modes may not be useful. Either drivers need to use count passed to them or drivers needs to receive `struct mode_info` in the callabck. Thanks, Pavan