From: Stefan Berger <stefanb@linux.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: linux-integrity@vger.kernel.org, aik@ozlabs.ru,
david@gibson.dropbear.id.au, linux-kernel@vger.kernel.org,
nayna@linux.vnet.ibm.com, gcwilson@linux.ibm.com, jgg@ziepe.ca
Subject: Re: [PATCH v2 3/4] tpm: Implement tpm2_init to call when TPM_OPS_AUTO_STARTUP is not set
Date: Tue, 25 Feb 2020 13:20:39 -0500 [thread overview]
Message-ID: <3813980a-6c5e-c99f-7b37-b20b72eb6a8a@linux.ibm.com> (raw)
In-Reply-To: <20200225170015.GE15662@linux.intel.com>
On 2/25/20 12:00 PM, Jarkko Sakkinen wrote:
> On Thu, Feb 13, 2020 at 03:23:28PM -0500, Stefan Berger wrote:
>> From: Stefan Berger <stefanb@linux.ibm.com>
>>
>> Implement tpm2_init() that gets the TPM 2 timeouts and command durations
>> and command code attributes. This function is to be called in case the
>> TPM_OPS_AUTO_STARTUP flag is not set and therefore tpm2_auto_startup()
>> is not called.
>>
>> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> The commit makes zero effort trying to explain what the heck tpm_init()
> is and when it should be used and why the function name tpm2_init().
Are you saying the explanation of when to use tpm2_init above is not
enough? 'bviously we are trying to cover the case of using the TPM 2 by
a driver that doesn't use the TPM_OPS_AUTO_STARTUP flag and therefore
the TPM 2 timeouts and command durations and command code attributes are
not set as they would be if tpm2_auto_startup() was to be called and
tpm2_init() is the alternative to call. I didn't like tpm2_init()
either... any suggestions for a better name?
Stefan
>
> /Jarkko
next prev parent reply other threads:[~2020-02-25 18:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 20:23 [PATCH v2 0/4] Enable vTPM 2.0 for the IBM vTPM driver Stefan Berger
2020-02-13 20:23 ` [PATCH v2 1/4] tpm: of: Handle IBM,vtpm20 case when getting log parameters Stefan Berger
2020-02-25 16:54 ` Jarkko Sakkinen
2020-02-13 20:23 ` [PATCH v2 2/4] tpm: ibmvtpm: Wait for buffer to be set before proceeding Stefan Berger
2020-02-25 16:57 ` Jarkko Sakkinen
2020-02-25 18:14 ` Stefan Berger
2020-02-26 15:00 ` Jarkko Sakkinen
2020-02-13 20:23 ` [PATCH v2 3/4] tpm: Implement tpm2_init to call when TPM_OPS_AUTO_STARTUP is not set Stefan Berger
2020-02-25 17:00 ` Jarkko Sakkinen
2020-02-25 18:20 ` Stefan Berger [this message]
2020-02-26 15:02 ` Jarkko Sakkinen
2020-02-26 17:35 ` Stefan Berger
2020-02-13 20:23 ` [PATCH v2 4/4] tpm: ibmvtpm: Add support for TPM 2 Stefan Berger
2020-02-19 19:23 ` [PATCH v2 0/4] Enable vTPM 2.0 for the IBM vTPM driver Stefan Berger
2020-02-20 19:59 ` Jarkko Sakkinen
2020-02-20 20:00 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3813980a-6c5e-c99f-7b37-b20b72eb6a8a@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=gcwilson@linux.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®