From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 347E53F65EF for ; Mon, 14 Sep 2026 09:14:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789377255; cv=none; b=aSG8ZOhuxwqv267DasRqBtFv6oOrvE/80bf2/NqWCU8VBy98abFxQLE1mXGTdigYKHAWxkk3sdEkLGT9UQ4SvZX3g7RQXuNz1Ey87nEXjgv9KmxHHvrkSNVkG/YZKhFJfeHJNs9rPCAgL7UGxfoJxJ+qBn0uUp0fLnK7EETyaXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789377255; c=relaxed/simple; bh=U+cJ/1BKoeCdFn/U2zPCDc6LZkZbVVMWzpvjm0ovy50=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W5X9+NfPM/ulJ91eaXqwfaI9HZAhqFBUmmPJuDDBIUGnhlDxvK+fFtcS/6KxvGMvK6YpFHl0xxhEbnICTXMBYf4GkYe0Ry8KvV/qmGFQTeT2xuaxV2lvOxz6wF8hYorbBAIGoDSGSoVq4aqhbCqOadJ0An5n0RrBPB1MlGHh6ps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i02qEmAt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XPuqnkRK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i02qEmAt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XPuqnkRK" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68E5imqI4057530 for ; Mon, 14 Sep 2026 09:14:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZG9wl1M74lgDTaTfHkBv64HRev6yjML1GUvpwSVAtcI=; b=i02qEmAtCReWHuXf PV8RoA7hS1OM7zLF14PeNOkQk/eyewJ6Sc6ErzaoTOl1sGlljFmif6f2h4hHhV0S b0LtC6OEwbNfYXc2eJw/akOU031MRtodGEqA8ep06uu4XdPjji4c/R0EId5rR6/J 0xMB3iyTkbbByGmrbWUB0UdqUqlVyOpnfr+0x4xzJ22vfPXUYWTycpDpNlBPeq83 GPsb4iVt/PTMiUigDPfmFPXgC8Bt5G+J6RFTHKqBrzmepBWusY9HrF2Ib6Dcm6ap dxepQI1jSPUSFADDalSKRle80DyhKhIje83OlMS70M5xd5yOtYmJ0Obar4rDoZbq ddLxAg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gp3hsspq3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 14 Sep 2026 09:14:12 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9375d92d0caso38257785a.0 for ; Mon, 14 Sep 2026 02:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789377246; x=1789982046; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZG9wl1M74lgDTaTfHkBv64HRev6yjML1GUvpwSVAtcI=; b=XPuqnkRKVg6gVjF2QSUgLqssflIlpccHue1bWE4+rRaj1Zf3lSEv4o8jXyHk3id7wD cPWnvRPccEWT/QVtwnOMp37U6fHJRozTPHi+thL5pkcAtJrpglvyVybRAc44Oz1UJxHB 5G4+0bY6oUSN60RM1caqmNtRdvvLTDpsY4E+rc66jkvAXOcfT5BgXUssTCeA4PoPT+xk aM8SwYrz1kzmN3o5abnaJjKO5jpwXI+pdBMF8r/tVluLifrQ8rikjLFh4aXpJxMg6Wc5 Al0IVJtSqY19Rslh+/bxgMl/lZQI0iK423BgvAg0TvFjsnQj8MyMm3hgl0m3ITqlL3Bm A+bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789377246; x=1789982046; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZG9wl1M74lgDTaTfHkBv64HRev6yjML1GUvpwSVAtcI=; b=GbwZWA0rb+InxXWBCpXw9c3NH1IXlJ/C2LIu3Ct8B0pZJc0GQ4UIjpXZtqwabEeY2b 43ran9WMYgfVooATfNVMxFP95ENPg4LOA1Q6ik4WYsXy79PbXTW/roX7rIHxSnA0mQGX 3m0tGvVCmEXqi9ct/7trQIOufxd1jQPsT4f+hANn9M7PKAAxXdjny/sJGeK81L9nhwcV wmxLt6ywM43UHSZjvgVqacf+dar0DmBXZ73TRZc+A9T0RvrghN7IspKdx37zhBWqwno5 eMWRvRbaGQnjjs32ZuAwjNiISWlSpaiwV8qC+fpOA5VXt0+caAj9nCTzI5OspF+V+k2d axwQ== X-Forwarded-Encrypted: i=1; AKwUvBzlLc0rdCXkIfOSddka+q/FniH1iDbOOhm2MNOSpErAov5d2NrdlLooDLoBWxGhCnTTVU52sv9CeHXUBEU=@vger.kernel.org X-Gm-Message-State: AFuF++n0rKZVoEHCrchhvt3BGyfCAx5ZWloIfSDhwFq2PjStmMVD8vEm ziJgTyvi+YNS2Zd9BPvyBXJAPdCI4oFOVTBKL5uwT+38CcDeTYHwJ0HRqB3VnRj4oTBInWumA5X s2QoElm+kLFAMI/i/EKcKy15XPOmGAwV56VhDLHnNBlEeUwhjVOA8ogbWvA1IF+ls5RZDbhjy+e 0= X-Gm-Gg: AYBFou2MzVBlUdJ2Y6o+4yB32taTC8XbO8okH6W3YBmETMKfrlBdW7gbEUqDdoj1ceL 8PdJ7UVTtIDcVZqRPQPuL6Cmsz6x2e9ctWoHyS/QbqOiWzO6EgyloMxLnuR13buwlhIvinZgSN/ qH2UYGjZ8GFrM1aVzAb1bevDOVNoJ3T4Lk++CHrbOOumi8rVub3uRTETgxxVpq3hrOncgfJkR+J syrvQ7E1AJGJ30RAV/rGmPwVjcbZaNEN+kQLoIoX1IfnUuN/Q1pQ/wrxd81nEbAQW0A6yvGadd6 e8DbE8SV65N4hS75bmefAPhwaO9n8e8ENWp5elJE3YXZbpDDyW/5NW8UVEMIdicVPYXpcXvcpjA r3s5tOkPP2rkXrfozP0/Fuw== X-Received: by 2002:a05:620a:6018:b0:939:47f4:935a with SMTP id af79cd13be357-93a29c955b9mr163374285a.5.1789377245762; Mon, 14 Sep 2026 02:14:05 -0700 (PDT) X-Received: by 2002:a05:620a:6018:b0:939:47f4:935a with SMTP id af79cd13be357-93a29c955b9mr163369885a.5.1789377245246; Mon, 14 Sep 2026 02:14:05 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c29660219ecsm393573266b.16.2026.09.14.02.14.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2026 02:14:04 -0700 (PDT) Message-ID: <381607db-0e7e-4d27-a992-64cd722c23fc@oss.qualcomm.com> Date: Mon, 14 Sep 2026 11:14:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] arm64: dts: qcom: glymur: Add UFS nodes To: Pradeep P V K , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , gopikrishna.garmidi@oss.qualcomm.com, jagadeesh.kona@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, nitin.rawat@oss.qualcomm.com, sibi.sankar@oss.qualcomm.com, Taniya Das References: <20260911-glymur_ufs_qcb_enablement-v1-0-b9fc5e2ee99a@oss.qualcomm.com> <20260911-glymur_ufs_qcb_enablement-v1-3-b9fc5e2ee99a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260911-glymur_ufs_qcb_enablement-v1-3-b9fc5e2ee99a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDEzMSBTYWx0ZWRfX5DYkc16WxTRY jzcRiGgGRUWZo/11tBFwN3bS5yGNI+3c+S/BC8uKJlfRh4LGXETsZVnSWst0vaqJnjCDElWEXne SiyxSXjkbZuoSJ/uXEA6LsNfj4YYcqSQxKrPoIdyxL9XIzySOQFPSAqo60ggRLBrU63gO3lcKwQ MDwb2BXPFvlZ1CqlXs68cRymu22d0BKmVx5N9HDskAL0h1N94fNA82D0nMUnssoLafyiME2u0vJ E3s7kSoN5LLQMcUKzzRO0ryyg0wKo1nen7GnBpfbR+eTwyOYpjdPyoWlTAhC7t57AqUEpUpXOGY vAmp+urK1WEMSKLp1Z0MNE8a6gURNHdextbuE456k8pALCNTC4sEqvGnqnsJ6ojsulVyF67M2zD qFttaGcdMpGVIRytTtStZEWGI0XyNLWgWV9nfoA7iB5RJhypXFJY3BFSo4kMnLRvybYilk31y87 kFFRzFG/k5WOWm/QEBQ== X-Authority-Analysis: v=2.4 cv=IZwSymqa c=1 sm=1 tr=0 ts=6aa7bae4 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=Xzt-r8i8nvNm0dTu8BUA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: TAcE4ioR3gfWCKSJvu1mZCPpaHxoX7yv X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDEzMSBTYWx0ZWRfX5BTrIkvOgtus rwPQ1uR9DloUZ2SI7kh6fw+sAzSui4f4CBb5S1cN5ZtZ1oZL3R6wwdg3J5tVnXrFaOhUlA1pTTe EVMJO4jiLUfZJ+0B17O1UeoDnpgP2qE= X-Proofpoint-ORIG-GUID: TAcE4ioR3gfWCKSJvu1mZCPpaHxoX7yv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_02,2026-09-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 impostorscore=0 malwarescore=0 phishscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140131 On 9/11/26 6:47 PM, Pradeep P V K wrote: > Add UFS PHY and UFS host controller nodes for Glymur SoC. > > Signed-off-by: Pradeep P V K > --- > arch/arm64/boot/dts/qcom/glymur.dtsi | 114 ++++++++++++++++++++++++++++++++++- > 1 file changed, 111 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi > index 624a9edd602c..7bbc804ed340 100644 > --- a/arch/arm64/boot/dts/qcom/glymur.dtsi > +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi > @@ -812,9 +812,9 @@ gcc: clock-controller@100000 { > <0>, /* QUSB4 1 PHY RX 1 */ > <0>, /* QUSB4 2 PHY RX 0 */ > <0>, /* QUSB4 2 PHY RX 1 */ > - <0>, /* UFS PHY RX Symbol 0 */ > - <0>, /* UFS PHY RX Symbol 1 */ > - <0>, /* UFS PHY TX Symbol 0 */ > + <&ufs_mem_phy 0>, /* UFS PHY RX Symbol 0 */ > + <&ufs_mem_phy 1>, /* UFS PHY RX Symbol 1 */ > + <&ufs_mem_phy 2>, /* UFS PHY TX Symbol 0 */ The comment is no useful, please drop it > <&usb_0_qmpphy QMP_USB43DP_USB3_PIPE_CLK>, > <&usb_1_qmpphy QMP_USB43DP_USB3_PIPE_CLK>, > <&usb_2_qmpphy QMP_USB43DP_USB3_PIPE_CLK>, > @@ -4103,6 +4103,114 @@ rng: rng@10c3000 { > reg = <0x0 0x010c3000 0x0 0x1000>; > }; > > + ufs_mem_phy: phy@1d80000 { > + compatible = "qcom,glymur-qmp-ufs-phy"; > + reg = <0x0 0x01d80000 0x0 0x2000>; > + > + clocks = <&rpmhcc RPMH_CXO_CLK>, > + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, > + /* UFS and PCIE4 shares the same clkref on glymur */ s/shares/share > + <&tcsr TCSR_PCIE_4_CLKREF_EN>; > + > + clock-names = "ref", > + "ref_aux", > + "qref"; > + > + resets = <&ufs_mem_hc 0>; > + reset-names = "ufsphy"; > + > + #clock-cells = <1>; > + #phy-cells = <0>; > + > + status = "disabled"; > + }; > + > + ufs_mem_hc: ufshc@1d84000 { > + compatible = "qcom,glymur-ufshc", > + "qcom,ufshc", > + "jedec,ufs-2.0"; > + reg = <0x0 0x01d84000 0x0 0x3000>, > + <0x0 0x01da0000 0x0 0x15000>; > + > + reg-names = "std", Stray \n above [...] > + ufs_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-100000000 { > + opp-hz = /bits/ 64 <100000000>, > + /bits/ 64 <0>, > + /bits/ 64 <0>, > + /bits/ 64 <100000000>, > + /bits/ 64 <0>, > + /bits/ 64 <0>, > + /bits/ 64 <0>, > + /bits/ 64 <0>; > + required-opps = <&rpmhpd_opp_low_svs>; > + }; > + > + opp-403000000 { There's another (201.5 MHz) OPP at SVS Konrad